feat: Drop unsupported service variants. - #37790
Merged
Merged
Conversation
kdmccormick
reviewed
Dec 18, 2025
| help_string=lms.format_help(), | ||
| settings_base='lms/envs', | ||
| default_settings='lms.envs.devstack', | ||
| service_variant='cms', |
Member
There was a problem hiding this comment.
lms, right?
Suggested change
| service_variant='cms', | |
| service_variant='lms', |
We haven't done anything specila for lms-xml for over a decade and we dropped lms-preview support last year when we added preview capabality to the new Authoring MFE. #36460
feanil
force-pushed
the
feanil/drop_unsupported_variants
branch
from
December 18, 2025 17:10
4e724fd to
0f7a7e5
Compare
kdmccormick
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We haven't done anything specila for lms-xml for over a decade and we
dropped lms-preview support last year when we added preview capabality
to the new Authoring MFE.
#36460