From edffaed880b829da584695c9d9b384e84a0e0b17 Mon Sep 17 00:00:00 2001 From: Muneeb Ur Rehman Date: Mon, 9 May 2022 16:48:05 +0500 Subject: [PATCH 1/6] feat: create skeleton for learner_pathway app --- openedx/core/djangoapps/learner_pathway/__init__.py | 0 openedx/core/djangoapps/learner_pathway/admin.py | 3 +++ openedx/core/djangoapps/learner_pathway/apps.py | 6 ++++++ .../core/djangoapps/learner_pathway/migrations/__init__.py | 0 openedx/core/djangoapps/learner_pathway/models.py | 3 +++ openedx/core/djangoapps/learner_pathway/tests.py | 3 +++ openedx/core/djangoapps/learner_pathway/views.py | 3 +++ 7 files changed, 18 insertions(+) create mode 100644 openedx/core/djangoapps/learner_pathway/__init__.py create mode 100644 openedx/core/djangoapps/learner_pathway/admin.py create mode 100644 openedx/core/djangoapps/learner_pathway/apps.py create mode 100644 openedx/core/djangoapps/learner_pathway/migrations/__init__.py create mode 100644 openedx/core/djangoapps/learner_pathway/models.py create mode 100644 openedx/core/djangoapps/learner_pathway/tests.py create mode 100644 openedx/core/djangoapps/learner_pathway/views.py diff --git a/openedx/core/djangoapps/learner_pathway/__init__.py b/openedx/core/djangoapps/learner_pathway/__init__.py new file mode 100644 index 000000000000..e69de29bb2d1 diff --git a/openedx/core/djangoapps/learner_pathway/admin.py b/openedx/core/djangoapps/learner_pathway/admin.py new file mode 100644 index 000000000000..8c38f3f3dad5 --- /dev/null +++ b/openedx/core/djangoapps/learner_pathway/admin.py @@ -0,0 +1,3 @@ +from django.contrib import admin + +# Register your models here. diff --git a/openedx/core/djangoapps/learner_pathway/apps.py b/openedx/core/djangoapps/learner_pathway/apps.py new file mode 100644 index 000000000000..d70ab6d5912d --- /dev/null +++ b/openedx/core/djangoapps/learner_pathway/apps.py @@ -0,0 +1,6 @@ +from django.apps import AppConfig + + +class LearnerPathwayConfig(AppConfig): + default_auto_field = 'django.db.models.BigAutoField' + name = 'learner_pathway' diff --git a/openedx/core/djangoapps/learner_pathway/migrations/__init__.py b/openedx/core/djangoapps/learner_pathway/migrations/__init__.py new file mode 100644 index 000000000000..e69de29bb2d1 diff --git a/openedx/core/djangoapps/learner_pathway/models.py b/openedx/core/djangoapps/learner_pathway/models.py new file mode 100644 index 000000000000..71a836239075 --- /dev/null +++ b/openedx/core/djangoapps/learner_pathway/models.py @@ -0,0 +1,3 @@ +from django.db import models + +# Create your models here. diff --git a/openedx/core/djangoapps/learner_pathway/tests.py b/openedx/core/djangoapps/learner_pathway/tests.py new file mode 100644 index 000000000000..7ce503c2dd97 --- /dev/null +++ b/openedx/core/djangoapps/learner_pathway/tests.py @@ -0,0 +1,3 @@ +from django.test import TestCase + +# Create your tests here. diff --git a/openedx/core/djangoapps/learner_pathway/views.py b/openedx/core/djangoapps/learner_pathway/views.py new file mode 100644 index 000000000000..91ea44a218fb --- /dev/null +++ b/openedx/core/djangoapps/learner_pathway/views.py @@ -0,0 +1,3 @@ +from django.shortcuts import render + +# Create your views here. From 237db2c2a9eda7123b9e6bf94eb8790d55513b39 Mon Sep 17 00:00:00 2001 From: Muneeb Ur Rehman Date: Mon, 9 May 2022 17:07:22 +0500 Subject: [PATCH 2/6] feat: add learner_pathway app for quality checks --- .github/workflows/pylint-checks.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pylint-checks.yml b/.github/workflows/pylint-checks.yml index 344119d3122a..4f95444df552 100644 --- a/.github/workflows/pylint-checks.yml +++ b/.github/workflows/pylint-checks.yml @@ -21,7 +21,7 @@ jobs: - module-name: openedx-1 path: "openedx/core/types/ openedx/core/djangoapps/ace_common/ openedx/core/djangoapps/agreements/ openedx/core/djangoapps/api_admin/ openedx/core/djangoapps/auth_exchange/ openedx/core/djangoapps/bookmarks/ openedx/core/djangoapps/cache_toolbox/ openedx/core/djangoapps/catalog/ openedx/core/djangoapps/ccxcon/ openedx/core/djangoapps/commerce/ openedx/core/djangoapps/common_initialization/ openedx/core/djangoapps/common_views/ openedx/core/djangoapps/config_model_utils/ openedx/core/djangoapps/content/ openedx/core/djangoapps/content_libraries/ openedx/core/djangoapps/contentserver/ openedx/core/djangoapps/cookie_metadata/ openedx/core/djangoapps/cors_csrf/ openedx/core/djangoapps/course_apps/ openedx/core/djangoapps/course_date_signals/ openedx/core/djangoapps/course_groups/ openedx/core/djangoapps/courseware_api/ openedx/core/djangoapps/crawlers/ openedx/core/djangoapps/credentials/ openedx/core/djangoapps/credit/ openedx/core/djangoapps/dark_lang/ openedx/core/djangoapps/debug/ openedx/core/djangoapps/demographics/ openedx/core/djangoapps/discussions/ openedx/core/djangoapps/django_comment_common/ openedx/core/djangoapps/embargo/ openedx/core/djangoapps/enrollments/ openedx/core/djangoapps/external_user_ids/ openedx/core/djangoapps/zendesk_proxy/ openedx/core/djangolib/ openedx/core/lib/ openedx/core/tests/ openedx/core/djangoapps/course_live/" - module-name: openedx-2 - path: "openedx/core/djangoapps/geoinfo/ openedx/core/djangoapps/header_control/ openedx/core/djangoapps/heartbeat/ openedx/core/djangoapps/lang_pref/ openedx/core/djangoapps/models/ openedx/core/djangoapps/monkey_patch/ openedx/core/djangoapps/oauth_dispatch/ openedx/core/djangoapps/olx_rest_api/ openedx/core/djangoapps/password_policy/ openedx/core/djangoapps/plugin_api/ openedx/core/djangoapps/plugins/ openedx/core/djangoapps/profile_images/ openedx/core/djangoapps/programs/ openedx/core/djangoapps/safe_sessions/ openedx/core/djangoapps/schedules/ openedx/core/djangoapps/self_paced/ openedx/core/djangoapps/service_status/ openedx/core/djangoapps/session_inactivity_timeout/ openedx/core/djangoapps/signals/ openedx/core/djangoapps/site_configuration/ openedx/core/djangoapps/system_wide_roles/ openedx/core/djangoapps/theming/ openedx/core/djangoapps/user_api/ openedx/core/djangoapps/user_authn/ openedx/core/djangoapps/util/ openedx/core/djangoapps/verified_track_content/ openedx/core/djangoapps/video_config/ openedx/core/djangoapps/video_pipeline/ openedx/core/djangoapps/waffle_utils/ openedx/core/djangoapps/xblock/ openedx/core/djangoapps/xmodule_django/ openedx/core/tests/ openedx/features/ openedx/testing/ openedx/tests/" + path: "openedx/core/djangoapps/geoinfo/ openedx/core/djangoapps/header_control/ openedx/core/djangoapps/heartbeat/ openedx/core/djangoapps/lang_pref/ openedx/core/djangoapps/models/ openedx/core/djangoapps/monkey_patch/ openedx/core/djangoapps/oauth_dispatch/ openedx/core/djangoapps/olx_rest_api/ openedx/core/djangoapps/password_policy/ openedx/core/djangoapps/plugin_api/ openedx/core/djangoapps/plugins/ openedx/core/djangoapps/profile_images/ openedx/core/djangoapps/programs/ openedx/core/djangoapps/safe_sessions/ openedx/core/djangoapps/schedules/ openedx/core/djangoapps/self_paced/ openedx/core/djangoapps/service_status/ openedx/core/djangoapps/session_inactivity_timeout/ openedx/core/djangoapps/signals/ openedx/core/djangoapps/site_configuration/ openedx/core/djangoapps/system_wide_roles/ openedx/core/djangoapps/theming/ openedx/core/djangoapps/user_api/ openedx/core/djangoapps/user_authn/ openedx/core/djangoapps/util/ openedx/core/djangoapps/verified_track_content/ openedx/core/djangoapps/video_config/ openedx/core/djangoapps/video_pipeline/ openedx/core/djangoapps/waffle_utils/ openedx/core/djangoapps/xblock/ openedx/core/djangoapps/xmodule_django/ openedx/core/tests/ openedx/features/ openedx/testing/ openedx/tests/ openedx/core/djangoapps/learner_pathway/" - module-name: common path: "common" - module-name: cms From 59e0aa4174a7387df7e3a28f17b78185f80ac566 Mon Sep 17 00:00:00 2001 From: Muneeb Ur Rehman Date: Mon, 9 May 2022 17:19:36 +0500 Subject: [PATCH 3/6] feat: add verbose name and dir for tests --- openedx/core/djangoapps/learner_pathway/apps.py | 2 ++ openedx/core/djangoapps/learner_pathway/tests.py | 3 --- openedx/core/djangoapps/learner_pathway/tests/__init__.py | 0 3 files changed, 2 insertions(+), 3 deletions(-) delete mode 100644 openedx/core/djangoapps/learner_pathway/tests.py create mode 100644 openedx/core/djangoapps/learner_pathway/tests/__init__.py diff --git a/openedx/core/djangoapps/learner_pathway/apps.py b/openedx/core/djangoapps/learner_pathway/apps.py index d70ab6d5912d..ed57d1dc684d 100644 --- a/openedx/core/djangoapps/learner_pathway/apps.py +++ b/openedx/core/djangoapps/learner_pathway/apps.py @@ -1,6 +1,8 @@ from django.apps import AppConfig +from django.utils.translation import gettext_lazy as _ class LearnerPathwayConfig(AppConfig): default_auto_field = 'django.db.models.BigAutoField' name = 'learner_pathway' + verbose_name = _("Learner Pathways") diff --git a/openedx/core/djangoapps/learner_pathway/tests.py b/openedx/core/djangoapps/learner_pathway/tests.py deleted file mode 100644 index 7ce503c2dd97..000000000000 --- a/openedx/core/djangoapps/learner_pathway/tests.py +++ /dev/null @@ -1,3 +0,0 @@ -from django.test import TestCase - -# Create your tests here. diff --git a/openedx/core/djangoapps/learner_pathway/tests/__init__.py b/openedx/core/djangoapps/learner_pathway/tests/__init__.py new file mode 100644 index 000000000000..e69de29bb2d1 From 1b94fca289e902bf5cf60b79a6837ed6e5c3ef5b Mon Sep 17 00:00:00 2001 From: Muneeb Ur Rehman Date: Mon, 9 May 2022 17:37:35 +0500 Subject: [PATCH 4/6] feat: add docstrings for files in app --- openedx/core/djangoapps/learner_pathway/admin.py | 4 ++++ openedx/core/djangoapps/learner_pathway/apps.py | 4 ++++ openedx/core/djangoapps/learner_pathway/models.py | 4 ++++ openedx/core/djangoapps/learner_pathway/views.py | 4 ++++ 4 files changed, 16 insertions(+) diff --git a/openedx/core/djangoapps/learner_pathway/admin.py b/openedx/core/djangoapps/learner_pathway/admin.py index 8c38f3f3dad5..6ee233f6b71d 100644 --- a/openedx/core/djangoapps/learner_pathway/admin.py +++ b/openedx/core/djangoapps/learner_pathway/admin.py @@ -1,3 +1,7 @@ +""" +Admin interface for learner_pathway App. +""" + from django.contrib import admin # Register your models here. diff --git a/openedx/core/djangoapps/learner_pathway/apps.py b/openedx/core/djangoapps/learner_pathway/apps.py index ed57d1dc684d..101ffd557015 100644 --- a/openedx/core/djangoapps/learner_pathway/apps.py +++ b/openedx/core/djangoapps/learner_pathway/apps.py @@ -1,3 +1,7 @@ +""" +Configuration for learner_pathway Django app +""" + from django.apps import AppConfig from django.utils.translation import gettext_lazy as _ diff --git a/openedx/core/djangoapps/learner_pathway/models.py b/openedx/core/djangoapps/learner_pathway/models.py index 71a836239075..de7372be29e7 100644 --- a/openedx/core/djangoapps/learner_pathway/models.py +++ b/openedx/core/djangoapps/learner_pathway/models.py @@ -1,3 +1,7 @@ +""" +Models for learner_pathway App. +""" + from django.db import models # Create your models here. diff --git a/openedx/core/djangoapps/learner_pathway/views.py b/openedx/core/djangoapps/learner_pathway/views.py index 91ea44a218fb..af8e419672e6 100644 --- a/openedx/core/djangoapps/learner_pathway/views.py +++ b/openedx/core/djangoapps/learner_pathway/views.py @@ -1,3 +1,7 @@ +""" +Views for learner_pathway App. +""" + from django.shortcuts import render # Create your views here. From 6a226682df19ee53de74c639fd6e942e41743106 Mon Sep 17 00:00:00 2001 From: Muneeb Ur Rehman Date: Mon, 9 May 2022 19:17:20 +0500 Subject: [PATCH 5/6] fix: remove unused imports --- openedx/core/djangoapps/learner_pathway/admin.py | 3 --- openedx/core/djangoapps/learner_pathway/models.py | 3 --- openedx/core/djangoapps/learner_pathway/views.py | 3 --- 3 files changed, 9 deletions(-) diff --git a/openedx/core/djangoapps/learner_pathway/admin.py b/openedx/core/djangoapps/learner_pathway/admin.py index 6ee233f6b71d..07f5a9fa2bdc 100644 --- a/openedx/core/djangoapps/learner_pathway/admin.py +++ b/openedx/core/djangoapps/learner_pathway/admin.py @@ -2,6 +2,3 @@ Admin interface for learner_pathway App. """ -from django.contrib import admin - -# Register your models here. diff --git a/openedx/core/djangoapps/learner_pathway/models.py b/openedx/core/djangoapps/learner_pathway/models.py index de7372be29e7..567982299862 100644 --- a/openedx/core/djangoapps/learner_pathway/models.py +++ b/openedx/core/djangoapps/learner_pathway/models.py @@ -2,6 +2,3 @@ Models for learner_pathway App. """ -from django.db import models - -# Create your models here. diff --git a/openedx/core/djangoapps/learner_pathway/views.py b/openedx/core/djangoapps/learner_pathway/views.py index af8e419672e6..09e3743be0cb 100644 --- a/openedx/core/djangoapps/learner_pathway/views.py +++ b/openedx/core/djangoapps/learner_pathway/views.py @@ -2,6 +2,3 @@ Views for learner_pathway App. """ -from django.shortcuts import render - -# Create your views here. From dcd05b838b8ecec1007d0e63cf55d3e8af960df1 Mon Sep 17 00:00:00 2001 From: Muneeb Ur Rehman Date: Mon, 9 May 2022 19:31:39 +0500 Subject: [PATCH 6/6] refactor: resolve quality issues --- openedx/core/djangoapps/learner_pathway/admin.py | 1 - openedx/core/djangoapps/learner_pathway/models.py | 1 - openedx/core/djangoapps/learner_pathway/views.py | 1 - 3 files changed, 3 deletions(-) diff --git a/openedx/core/djangoapps/learner_pathway/admin.py b/openedx/core/djangoapps/learner_pathway/admin.py index 07f5a9fa2bdc..f69e12dccdf6 100644 --- a/openedx/core/djangoapps/learner_pathway/admin.py +++ b/openedx/core/djangoapps/learner_pathway/admin.py @@ -1,4 +1,3 @@ """ Admin interface for learner_pathway App. """ - diff --git a/openedx/core/djangoapps/learner_pathway/models.py b/openedx/core/djangoapps/learner_pathway/models.py index 567982299862..a03ee95ad3ae 100644 --- a/openedx/core/djangoapps/learner_pathway/models.py +++ b/openedx/core/djangoapps/learner_pathway/models.py @@ -1,4 +1,3 @@ """ Models for learner_pathway App. """ - diff --git a/openedx/core/djangoapps/learner_pathway/views.py b/openedx/core/djangoapps/learner_pathway/views.py index 09e3743be0cb..8a87b81297d3 100644 --- a/openedx/core/djangoapps/learner_pathway/views.py +++ b/openedx/core/djangoapps/learner_pathway/views.py @@ -1,4 +1,3 @@ """ Views for learner_pathway App. """ -