Skip to content

pipewire: backport fix for spa/plugins/alsa build with glibc-2.43#1033

Closed
junzhuimx wants to merge 1 commit into
openembedded:masterfrom
nxp-upstream:Fix-pipewire-build-break
Closed

pipewire: backport fix for spa/plugins/alsa build with glibc-2.43#1033
junzhuimx wants to merge 1 commit into
openembedded:masterfrom
nxp-upstream:Fix-pipewire-build-break

Conversation

@junzhuimx
Copy link
Copy Markdown

Fix missed -Wdiscarded-qualifiers warning:
../sources/pipewire-1.6.2/spa/plugins/alsa/acp/compat.h: In function 'pa_path_get_filename':
../sources/pipewire-1.6.2/spa/plugins/alsa/acp/compat.h:437:13: error: assignment discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
437 | if ((fn = strrchr(p, PA_PATH_SEP_CHAR)))
| ^

Fix missed -Wdiscarded-qualifiers warning:
    ../sources/pipewire-1.6.2/spa/plugins/alsa/acp/compat.h: In function 'pa_path_get_filename':
    ../sources/pipewire-1.6.2/spa/plugins/alsa/acp/compat.h:437:13: error: assignment discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
      437 |     if ((fn = strrchr(p, PA_PATH_SEP_CHAR)))
          |             ^

Signed-off-by: Jun Zhu <junzhu@nxp.com>
@kraj
Copy link
Copy Markdown
Contributor

kraj commented Mar 20, 2026

there are earlier submission to mailing list here [1] which already takes care of this
It will land in master shortly

[1] https://lore.kernel.org/openembedded-devel/20260319051843.2243601-1-pkj@axis.com/

Gerry546 pushed a commit to Gerry546/meta-openembedded that referenced this pull request Mar 22, 2026
Upgrade to release 1.9.0:

- 1.9.0
  - Remove Python 3.8 support (EOL), add Python 3.13 (5f25030)
  - Remove localhost and 127.0.0.1 from default NO_PROXY list (openembedded#994)
  - Support IPv6 CIDRs in the no_proxy option (openembedded#1033)
  - Fix thread safety condition in `teardown()` to improve `run_forever()` (openembedded#1015)
  - Fix openembedded#1024 by chunking data, recursion in on_error callback, thread leak in `_stop_ping_thread()`, avoid implicit None in `recv()` (openembedded#1036)
  - Avoid bare except clauses for better error handling (openembedded#1036)
  - Fix async (openembedded#983)
  - Resolve mypy type errors (openembedded#996, openembedded#1006, 813d570)
  - Test coverage improvements (openembedded#1035, openembedded#1036)
  - flake8 linting improvements (openembedded#1034)

- 1.8.0
  - Added `on_reconnect` parameter to WebSocketApp to handle callback ambiguity (openembedded#972)
  - Improve handling of SSLEOFError and use reconnect bool (openembedded#961)
  - Minor linting and docs CI build upgrades (981c00e, 75ba91a, bec2608)

License-Update: copyright years refreshed

Signed-off-by: Ryan Eatmon <reatmon@ti.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
@junzhuimx
Copy link
Copy Markdown
Author

Another commit has resolved this issue already.
So close my PR now

@junzhuimx junzhuimx closed this Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants