From 35ad7353f499de04b8baf5709be669aab2e7cbd6 Mon Sep 17 00:00:00 2001 From: Andrew Geissler Date: Thu, 11 Mar 2021 14:50:33 -0600 Subject: [PATCH] rsyslog: fix sbindir variable substitution Noticed that when we pulled the latest commits into OpenBMC that this issue hit: systemd[228]: rsyslog.service: Failed to locate executable /rsyslogd: No such file or directory Looking at the service file you can see the issue with the ExecStart line: cat /lib/systemd/system/rsyslog.service [Unit] Description=System Logging Service Requires=syslog.socket Wants=network.target network-online.target After=network.target network-online.target Documentation=man:rsyslogd(8) Documentation=http://www.rsyslog.com/doc/ [Service] Type=notify ExecStart=/rsyslogd -n -iNONE The issue appears to be with the sed statement in situations where the systemd feature is enabled. A {} is required around the sbindir vs. the (). Signed-off-by: Andrew Geissler --- meta-oe/recipes-extended/rsyslog/rsyslog_8.2102.0.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta-oe/recipes-extended/rsyslog/rsyslog_8.2102.0.bb b/meta-oe/recipes-extended/rsyslog/rsyslog_8.2102.0.bb index 15e31cec821..22059d1407b 100644 --- a/meta-oe/recipes-extended/rsyslog/rsyslog_8.2102.0.bb +++ b/meta-oe/recipes-extended/rsyslog/rsyslog_8.2102.0.bb @@ -151,7 +151,7 @@ do_install_append() { if ${@bb.utils.contains('DISTRO_FEATURES','systemd','true','false',d)}; then install -d ${D}${systemd_system_unitdir} install -m 644 ${WORKDIR}/rsyslog.service ${D}${systemd_system_unitdir} - sed -i -e "s,@sbindir\@,$(sbindir),g" ${D}${systemd_system_unitdir}/rsyslog.service + sed -i -e "s,@sbindir@,${sbindir},g" ${D}${systemd_system_unitdir}/rsyslog.service fi }