7904167: Enable -03 optimization in NativeCompilation.gmk#302
7904167: Enable -03 optimization in NativeCompilation.gmk#302varada1110 wants to merge 1 commit into
Conversation
|
👋 Welcome back varadam! A progress list of the required criteria for merging this PR into |
|
@varada1110 This change is no longer ready for integration - check the PR body for details. |
|
Hi @JornVernee , could I please get a review on this. |
|
Hi @JornVernee , @mcimadamore |
nizarbenalla
left a comment
There was a problem hiding this comment.
Looks good to me, the change is straightforward.
But let's wait for Jorn to have a good.
|
Hey, I was on vacation the last couple of weeks, and didn't have time to look at this before that. There's a couple things I'd like to understand:
|
|
@varada1110 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
Enable -03 in make/NativeCompilation.gmk to align with Gradle CMake Release optimization.
JBS : CODETOOLS-7904167
Progress
Error
- [x] I confirm that I make this contribution in accordance with the [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jextract.git pull/302/head:pull/302$ git checkout pull/302Update a local copy of the PR:
$ git checkout pull/302$ git pull https://git.openjdk.org/jextract.git pull/302/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 302View PR using the GUI difftool:
$ git pr show -t 302Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jextract/pull/302.diff
Using Webrev
Link to Webrev Comment