-
Notifications
You must be signed in to change notification settings - Fork 91
feat: add FBC catalog Dockerfile for CI without operator-sdk #2204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
openshift-merge-bot
merged 8 commits into
openshift:oadp-dev
from
kaovilai:fbc-catalog-dockerfile
May 20, 2026
+109
−1
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
275962c
feat: add FBC catalog Dockerfile for CI operator installation
kaovilai ba95d8e
chore: bump OPM_VERSION from v1.23.0 to v1.68.0
kaovilai be69539
fix: address PR review feedback on Dockerfile.catalog
kaovilai 5537d0a
fix: add cross-references and Makefile target for OPM_VERSION sync
kaovilai 49b9f2f
docs: add usage example for catalog-fbc-build target
kaovilai 5997aa0
docs: add on-cluster install instructions for catalog-fbc-build
kaovilai b41a7df
docs: clarify OLMv0 vs OLMv1 usage in Dockerfile.catalog
kaovilai 29bcf34
fix: move OPM_VERSION comment to separate line
kaovilai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| # FBC (File-Based Catalog) image for OLM operator installation. | ||
| # Renders a bundle image into an FBC catalog with gRPC serving for OLMv0. | ||
| # OLMv1 only needs the /configs content (no serving required). | ||
| # | ||
| # Usage: | ||
| # make catalog-fbc-build BUNDLE_IMG=<bundle-image-ref> | ||
| # | ||
| # Or directly: | ||
| # podman build -f build/Dockerfile.catalog \ | ||
| # --build-arg BUNDLE_IMG=<bundle-image-ref> \ | ||
| # -t <catalog-image-tag> . | ||
| # | ||
| # After building, push and install on-cluster: | ||
| # make catalog-push | ||
| # OLMv0: make deploy-olm CATALOG_IMG=<catalog-image-tag> | ||
| # OLMv1: create a ClusterExtension referencing the oadp-operator package | ||
| # (see Makefile catalog-fbc-build comments for full example) | ||
| # | ||
| # ci-operator: set BUNDLE_IMG via build_args in the ci-operator config. | ||
| # The bundle image must be pushed to a registry accessible during the build. | ||
| # | ||
| # Reference: networking-incubator/coraza-kubernetes-operator catalog/Dockerfile | ||
|
|
||
| # Keep OPM_VERSION in sync with Makefile. Override via --build-arg or `make catalog-fbc-build`. | ||
| ARG OPM_VERSION=v1.68.0 | ||
|
|
||
| FROM quay.io/operator-framework/opm:${OPM_VERSION} AS opm | ||
|
|
||
| FROM registry.access.redhat.com/ubi9/ubi-minimal AS builder | ||
|
|
||
| COPY --from=opm /bin/opm /bin/opm | ||
|
|
||
| # Allow opm to pull bundle images from CI registries without signature verification | ||
| RUN mkdir -p /etc/containers && \ | ||
| echo '{"default":[{"type":"insecureAcceptAnything"}]}' > /etc/containers/policy.json | ||
|
|
||
| ARG BUNDLE_IMG | ||
| ARG VERSION=99.0.0 | ||
| ARG DEFAULT_CHANNEL=dev | ||
|
|
||
| RUN test -n "${BUNDLE_IMG}" || (echo "BUNDLE_IMG build-arg is required" >&2; exit 1) && \ | ||
| mkdir -p /configs/oadp-operator && \ | ||
| /bin/opm render "${BUNDLE_IMG}" -o yaml > /configs/oadp-operator/index.yaml && \ | ||
| cat >> /configs/oadp-operator/index.yaml <<EOF | ||
| --- | ||
| schema: olm.package | ||
| name: oadp-operator | ||
| defaultChannel: ${DEFAULT_CHANNEL} | ||
| --- | ||
| schema: olm.channel | ||
| name: ${DEFAULT_CHANNEL} | ||
| package: oadp-operator | ||
| entries: | ||
| - name: oadp-operator.v${VERSION} | ||
| EOF | ||
|
|
||
| RUN /bin/opm validate /configs/ | ||
|
|
||
| FROM opm | ||
|
|
||
| COPY --from=builder /configs /configs | ||
|
|
||
| # OLMv0: pre-warm the serve cache and configure gRPC serving. | ||
| # OLMv1 reads /configs directly from the image and does not use the serve entrypoint. | ||
| RUN ["/bin/opm", "serve", "/configs", "--cache-dir=/tmp/cache", "--cache-only"] | ||
|
|
||
| LABEL operators.operatorframework.io.index.configs.v1=/configs | ||
|
|
||
| EXPOSE 50051 | ||
| ENTRYPOINT ["/bin/opm"] | ||
| CMD ["serve", "/configs", "--cache-dir=/tmp/cache"] | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the variable that
deploy-olmactually reads.deploy-olmignoresCATALOG_IMG; the target-specific variable isTHIS_CATALOG_IMAGE, so this example won't install the tag the reader just built. Please update this snippet, and the matching example inbuild/Dockerfile.catalog, to use the right variable.Suggested doc fix
📝 Committable suggestion
🤖 Prompt for AI Agents