Skip to content

ci: enable dco for terraform red hat repositories#78068

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
amandahla:enable-dco-terraform
Apr 20, 2026
Merged

ci: enable dco for terraform red hat repositories#78068
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
amandahla:enable-dco-terraform

Conversation

@amandahla
Copy link
Copy Markdown
Contributor

@amandahla amandahla commented Apr 20, 2026

We want to require explicit sign-off on each commit for the terraform Red Hat repositores. This PR enables the dco plugin to guarantee that for each PR.

Reference: https://source.redhat.com/departments/products_and_global_engineering/portfolio_and_delivery/pd_wiki/step_by_step_github_setup_for_red_hat_projects#understand-dco-vs-cla

Summary by CodeRabbit

  • Chores
    • Enabled Developer Certificate of Origin (DCO) verification plugin for terraform-provider-rhcs, terraform-rhcs-rosa-classic, and terraform-rhcs-rosa-hcp repositories.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 20, 2026

Walkthrough

The dco Prow plugin has been added to three terraform-redhat repository configurations, enabling Developer Certificate of Origin checks. Each configuration file receives a single line addition in its plugin list.

Changes

Cohort / File(s) Summary
DCO Plugin Configuration
core-services/prow/02_config/terraform-redhat/terraform-provider-rhcs/_pluginconfig.yaml, core-services/prow/02_config/terraform-redhat/terraform-rhcs-rosa-classic/_pluginconfig.yaml, core-services/prow/02_config/terraform-redhat/terraform-rhcs-rosa-hcp/_pluginconfig.yaml
Added dco plugin entry to the plugins list for each terraform-redhat repository configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 10
✅ Passed checks (10 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: enabling the dco (Developer Certificate of Origin) plugin for three terraform Red Hat repositories through Prow configuration updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed PR modified only YAML configuration files (_pluginconfig.yaml), not Ginkgo test files. No Go test files with Ginkgo test name patterns were changed.
Test Structure And Quality ✅ Passed The PR only modifies Prow plugin configuration YAML files to enable the DCO plugin. No Ginkgo test files or test code are present, making the test quality check not applicable.
Microshift Test Compatibility ✅ Passed This pull request does not add any Ginkgo e2e tests. The changes exclusively modify four Prow plugin configuration YAML files to add the dco plugin to the plugins list for Terraform Red Hat repositories. These are CI/CD configuration files, not test files, and contain no Ginkgo test patterns. Since the MicroShift Test Compatibility check is specifically for new Ginkgo e2e tests, it is not applicable to this PR.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR modifies only Prow CI plugin configuration files (_pluginconfig.yaml) for DCO plugin enablement. No Ginkgo e2e test code additions present.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only Prow CI/CD tool configuration files to enable DCO plugin for terraform repositories, not Kubernetes deployment manifests or controller code.
Ote Binary Stdout Contract ✅ Passed This PR modifies only Prow plugin configuration YAML files with no executable code, making the OTE Binary Stdout Contract check inapplicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR only modifies Prow plugin configuration YAML files to enable the dco plugin for three terraform Red Hat repositories. No new Ginkgo e2e tests are present.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@amandahla: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 20, 2026
@olucasfreitas
Copy link
Copy Markdown
Contributor

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 20, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amandahla, olucasfreitas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 20, 2026

@amandahla: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit be1758d into openshift:main Apr 20, 2026
12 checks passed
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 20, 2026

@amandahla: Updated the plugins configmap in namespace ci at cluster app.ci using the following files:

  • key core-services-prow-02_config-terraform-redhat-terraform-provider-rhcs-_pluginconfig.yaml using file core-services/prow/02_config/terraform-redhat/terraform-provider-rhcs/_pluginconfig.yaml
  • key core-services-prow-02_config-terraform-redhat-terraform-rhcs-rosa-classic-_pluginconfig.yaml using file core-services/prow/02_config/terraform-redhat/terraform-rhcs-rosa-classic/_pluginconfig.yaml
  • key core-services-prow-02_config-terraform-redhat-terraform-rhcs-rosa-hcp-_pluginconfig.yaml using file core-services/prow/02_config/terraform-redhat/terraform-rhcs-rosa-hcp/_pluginconfig.yaml
Details

In response to this:

We want to require explicit sign-off on each commit for the terraform Red Hat repositores. This PR enables the dco plugin to guarantee that for each PR.

Reference: https://source.redhat.com/departments/products_and_global_engineering/portfolio_and_delivery/pd_wiki/step_by_step_github_setup_for_red_hat_projects#understand-dco-vs-cla

Summary by CodeRabbit

  • Chores
  • Enabled Developer Certificate of Origin (DCO) verification plugin for terraform-provider-rhcs, terraform-rhcs-rosa-classic, and terraform-rhcs-rosa-hcp repositories.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants