Skip to content

AGENT-1429: Add ha5 dualstack job for ISO No Registry#78986

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
pawanpinjarkar:additional-jobs-for-no-registry-cluster-install
May 20, 2026
Merged

AGENT-1429: Add ha5 dualstack job for ISO No Registry#78986
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
pawanpinjarkar:additional-jobs-for-no-registry-cluster-install

Conversation

@pawanpinjarkar
Copy link
Copy Markdown
Contributor

@pawanpinjarkar pawanpinjarkar commented May 7, 2026

  • Adds e2e-agent-ha5-dualstack-iso-no-registry-techpreview

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 7, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 7, 2026

@pawanpinjarkar: This pull request references AGENT-1429 which is a valid jira issue.

Details

In response to this:

Adds e2e-agent-ha5-dualstack-iso-no-registry-techpreview, and e2e-agent-single-node-ipv6-none-iso-no-registry-techpreview jobs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

/cc @andfasano @sadasu

@openshift-ci openshift-ci Bot requested review from andfasano and sadasu May 7, 2026 15:18
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 7, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

Update CI: change an existing agent job cron from 12-hourly to 8-hourly, add two new agent conformance jobs to the 5.0 nightly config, and insert an additional compact-ipv4 validation step into the agent conformance ISO-no-registry workflow.

Changes

Agent CI: workflow + nightly job updates

Layer / File(s) Summary
Workflow test step
ci-operator/step-registry/agent/e2e/generic/conformance/iso-no-registry/agent-e2e-generic-conformance-iso-no-registry-workflow.yaml
Inserted agent-e2e-compact-ipv4-iso-no-registry-validation into the workflow test phase before the existing conformance test chain.
Existing job schedule change (4.22)
ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml
e2e-agent-compact-iso-no-registry-techpreview cron changed from 0 */12 * * *0 */8 * * *.
Existing job schedule change (5.0)
ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml
e2e-agent-compact-iso-no-registry-techpreview cron changed from 0 */12 * * *0 */8 * * *.
New job: HA5 dualstack
ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml
Added e2e-agent-ha5-dualstack-iso-no-registry-techpreview with cluster_profile: equinix-ocp-metal, capabilities: [intranet], cron: 0 */8 * * *, and DEVSCRIPTS_CONFIG setting AGENT_E2E_TEST_SCENARIO=5CONTROL_IPV4V6, plus ISO_NO_REGISTRY and FEATURE_SET=TechPreviewNoUpgrade.
New job: SNO IPv6
ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml
Added e2e-agent-single-node-ipv6-none-iso-no-registry-techpreview with cluster_profile: equinix-ocp-metal, capabilities: [intranet], cron: 0 */8 * * *, and DEVSCRIPTS_CONFIG setting AGENT_E2E_TEST_SCENARIO=SNO_IPV6, AGENT_PLATFORM_TYPE=none, ISO_NO_REGISTRY, and FEATURE_SET=TechPreviewNoUpgrade.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested labels

rehearsals-ack

Suggested reviewers

  • sosiouxme
  • stbenjam

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (2 warnings, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ⚠️ Warning The title mentions adding an 'ha5 dualstack job', but the PR actually adds two new jobs and also updates cron schedules across two config files. Update the title to reflect all main changes, such as: 'AGENT-1429: Add ha5 dualstack and IPv6 jobs for ISO No Registry' or 'AGENT-1429: Add conformance jobs and increase test frequency for ISO No Registry'.
Stable And Deterministic Test Names ❓ Inconclusive No result was produced after verification. Marking as INCONCLUSIVE. Re-run the check or adjust instructions to produce a final result.
✅ Passed checks (9 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Test Structure And Quality ✅ Passed PR modifies only YAML CI/CD configuration and workflow files, not Ginkgo test code. Custom check is for Ginkgo test code review, which is not applicable.
Microshift Test Compatibility ✅ Passed PR contains only CI configuration files (YAML workflows, job definitions) in the openshift/release repo, not new Ginkgo test code (It/Describe/Context/When patterns).
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR does not add new Ginkgo test source code. It only adds CI job configuration for existing OpenShift conformance tests. Custom check for new e2e tests is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR contains only CI test job configuration and workflow changes, not deployment manifests, operator code, or controllers. The check targets production scheduling constraints, not CI infrastructure.
Ote Binary Stdout Contract ✅ Passed PR contains only YAML configuration changes (CI job configs and workflows). OTE Binary Stdout Contract check applies only to Go code violations. No Go source files are modified.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo e2e tests are added. PR only modifies CI infrastructure to configure existing tests with different scenarios.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from sosiouxme and stbenjam May 7, 2026 15:19
@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

/depends on openshift-metal3/dev-scripts#1884

@pawanpinjarkar pawanpinjarkar force-pushed the additional-jobs-for-no-registry-cluster-install branch from 7ca34ac to 2844004 Compare May 7, 2026 17:08
@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

/hold cancel

@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-single-node-ipv6-none-iso-no-registry-techpreview

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-ha5-dualstack-iso-no-registry-techpreview
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-ha5-dualstack-iso-no-registry-techpreview

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@pawanpinjarkar: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command.

@pawanpinjarkar pawanpinjarkar force-pushed the additional-jobs-for-no-registry-cluster-install branch from 2844004 to bd7eb7b Compare May 8, 2026 18:42
@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-ha5-dualstack-iso-no-registry-techpreview
/pj-rehearse periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-single-node-ipv6-none-iso-no-registry-techpreview
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-ha5-dualstack-iso-no-registry-techpreview
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-single-node-ipv6-none-iso-no-registry-techpreview

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@ci-operator/step-registry/agent/e2e/generic/conformance/iso-no-registry/agent-e2e-generic-conformance-iso-no-registry-workflow.yaml`:
- Line 11: The generic workflow includes a topology/network-specific step ref
"agent-e2e-compact-ipv4-iso-no-registry-validation" which causes non-compact or
non-IPv4 jobs to fail; remove this hard-coded ref from the shared workflow
(agent-e2e-generic-conformance-iso-no-registry-workflow.yaml) and either (a)
move the "agent-e2e-compact-ipv4-iso-no-registry-validation" step into
compact-IPv4-specific jobs/workflows, or (b) replace it with a topology-agnostic
validation step or a conditional/parameterized reference so only compact IPv4
jobs invoke that validation.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 95ae43f9-e016-49ee-a7e1-2f0334a99b30

📥 Commits

Reviewing files that changed from the base of the PR and between 2844004 and bd7eb7b.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/release/openshift-release-main-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (4)
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml
  • ci-operator/step-registry/agent/e2e/generic/conformance/iso-no-registry/agent-e2e-generic-conformance-iso-no-registry-workflow.yaml
  • ci-operator/step-registry/baremetalds/e2e/test/baremetalds-e2e-test-commands.sh
✅ Files skipped from review due to trivial changes (1)
  • ci-operator/step-registry/baremetalds/e2e/test/baremetalds-e2e-test-commands.sh
🚧 Files skipped from review as they are similar to previous changes (2)
  • ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@pawanpinjarkar: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command.

2 similar comments
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@pawanpinjarkar: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@pawanpinjarkar: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command.

@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-ha5-dualstack-iso-no-registry-techpreview

@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-ha5-dualstack-iso-no-registry-techpreview

Comment thread ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml Outdated
Comment thread ci-operator/step-registry/baremetalds/e2e/test/baremetalds-e2e-test-commands.sh Outdated
@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-single-node-ipv6-none-iso-no-registry-techpreview

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

/hold 5 control plane and SNO are failing. Need to fix it before merging this PR.

@openshift-ci openshift-ci Bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 11, 2026
- Added a new tech preview job, e2e-agent-ha5-dualstack-iso-no-registry-techpreview
@pawanpinjarkar pawanpinjarkar force-pushed the additional-jobs-for-no-registry-cluster-install branch from 9e639cc to c2a2665 Compare May 20, 2026 16:18
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2026
@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2026
@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@pawanpinjarkar: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-ovn-two-node-arbiter N/A periodic Periodic changed
periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-ha5-dualstack-iso-no-registry-techpreview N/A periodic Periodic changed
periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@pawanpinjarkar pawanpinjarkar changed the title AGENT-1429: Add new jobs for ISO No Registry AGENT-1429: Add ha5 dualstack job for ISO No Registry May 20, 2026
@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

The compact and HA5 clusters were successfully installed. The current 2 tests failure are known and soon will be fixed with newer runs once openshift/origin#31179 is merged

@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 20, 2026
@bfournie
Copy link
Copy Markdown
Contributor

/approve

@bfournie
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2026
@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

/assign @neisw

@smg247
Copy link
Copy Markdown
Member

smg247 commented May 20, 2026

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 20, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie, pawanpinjarkar, smg247

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 20, 2026

@pawanpinjarkar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-ha5-dualstack-iso-no-registry-techpreview bd7eb7b link unknown /pj-rehearse periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-ha5-dualstack-iso-no-registry-techpreview
ci/rehearse/periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-single-node-ipv6-none-iso-no-registry-techpreview 2844004 link unknown /pj-rehearse periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-single-node-ipv6-none-iso-no-registry-techpreview
ci/rehearse/openshift/image-registry/main/e2e-metal-ipi-ovn-ipv6 2844004 link unknown /pj-rehearse pull-ci-openshift-image-registry-main-e2e-metal-ipi-ovn-ipv6
ci/rehearse/periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-compact-iso-no-registry-techpreview bd7eb7b link unknown /pj-rehearse periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-compact-iso-no-registry-techpreview
ci/rehearse/openshift/ironic-hardware-inventory-recorder-image/release-4.7/e2e-metal-ipi bd7eb7b link unknown /pj-rehearse pull-ci-openshift-ironic-hardware-inventory-recorder-image-release-4.7-e2e-metal-ipi
ci/rehearse/periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-single-node-ipv6-none-iso-no-registry-techpreview 9e639cc link unknown /pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-single-node-ipv6-none-iso-no-registry-techpreview
ci/rehearse/periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-ha5-dualstack-iso-no-registry-techpreview c2a2665 link unknown /pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-ha5-dualstack-iso-no-registry-techpreview
ci/rehearse/periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview c2a2665 link unknown /pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit e12a44b into openshift:main May 20, 2026
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants