CNTRLPLANE-3375: Add ExternalOIDCWithUpstreamParity Default jobs#79310
CNTRLPLANE-3375: Add ExternalOIDCWithUpstreamParity Default jobs#79310ShazaAldawamneh wants to merge 1 commit into
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
jira/valid-reference
|
@ShazaAldawamneh: This pull request references CNTRLPLANE-3375 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughUpdated the vSphere external OIDC test schedule to run on all days instead of Wednesdays only, and added new 24-hour periodic test suites for external OIDC upstream parity across cloud platforms (AWS, Azure, GCP, vSphere, Metal) and AWS single-node, each with platform-specific test skip settings and configurations. ChangesExternal OIDC Upstream Parity Testing Configuration
🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/cluster-authentication-operator/openshift-cluster-authentication-operator-release-5.0__periodics.yaml`:
- Line 457: The cron schedule for the vSphere periodic is set to weekly ("cron:
30 21 * * 3") but should run daily; update the YAML entry for the cron key (the
line containing "cron") to a daily schedule such as "30 21 * * *" so the job
runs every day at 21:30 UTC.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 3e437c22-7c02-42c3-aca1-91c0d7849466
⛔ Files ignored due to path filters (2)
ci-operator/jobs/openshift/cluster-authentication-operator/openshift-cluster-authentication-operator-release-4.23-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/cluster-authentication-operator/openshift-cluster-authentication-operator-release-5.0-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (2)
ci-operator/config/openshift/cluster-authentication-operator/openshift-cluster-authentication-operator-release-4.23__periodics.yamlci-operator/config/openshift/cluster-authentication-operator/openshift-cluster-authentication-operator-release-5.0__periodics.yaml
There was a problem hiding this comment.
As @everettraven pointed out in a conversation, we should probably have only 5.0 periodics.
Since openshift/hypershift#8287 adds new tests for this feature gate, we should probably hold off on merging until this one is merged.
openshift-ci
Bot
added
the
needs-rebase
ShazaAldawamneh
force-pushed
the
CNTRLPLANE-3375
branch
from
8ebf3f5 to
a600ed7
Compare
openshift-ci
Bot
removed
the
needs-rebase
Signed-off-by: Shaza Aldawamneh <shaza.aldawamneh@hotmail.com>
ShazaAldawamneh
force-pushed
the
CNTRLPLANE-3375
branch
from
a600ed7 to
de37fde
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@ShazaAldawamneh: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
ShazaAldawamneh
changed the title
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
/hold Holding as this PR is dependent on tests in openshift/hypershift#8287 . Once this is merged we can lift the hold. |
openshift-ci
Bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ehearne-redhat, ShazaAldawamneh The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
This PR adds periodic Prow jobs for the
ExternalOIDCWithUpstreamParityfeature gate running on the Default feature set, enabling automated regression testing once the feature is promoted from TechPreview to GA.This PR should be merged alongside the feature gate promotion PR in openshift/api.
Changes
Periodic Jobs Added
Creates daily periodic test jobs for the Default feature set across all supported platforms and releases:
Platforms (all 8 required for promotion):
Releases:
Summary by CodeRabbit