WIP: rhobs/observability-operator: add upi-installer base image for 4.20-azure variant

[DavidRajnoha]

Summary

• Adds upi-installer base image (ocp/4.20:upi-installer) to the amd64-ocp-4.20-azure variant config
• Fixes ImagePullBackOff on stable:upi-installer during the cucushift-installer-check-azure-destroy-dns post step in periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.20-azure-coo-stage
• Matches the pattern used by other variants (4.17-gcp, 4.18-gcp, 4.19-gcp) that already declare this base image

Root Cause

The cucushift-installer-check-azure-destroy-dns step specifies from: upi-installer, which resolves to stable:upi-installer (from the imported OCP release). OCP 4.20 nightlies no longer ship upi-installer in the release payload, so the image pull fails.

Test plan

• Rehearse the coo-stage job via /pj-rehearse to verify the upi-installer image resolves correctly

Made with Cursor

Summary by CodeRabbit

• Chores
  • Updated testing infrastructure configuration to expand OpenShift version and platform support.

[coderabbitai]

Walkthrough

A single CI operator configuration file is updated to add a new upi-installer base image entry. The entry references the 4.20 image with the ocp namespace and upi-installer tag.

Changes

CI Operator Configuration

Layer / File(s)	Summary
upi-installer base image configuration ci-operator/config/rhobs/observability-operator/rhobs-observability-operator-main__amd64-ocp-4.20-azure.yaml	Added upi-installer base image entry with image name 4.20, namespace ocp, and tag upi-installer to support image resolution in the observability-operator build pipeline.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

lgtm, rehearsals-ack

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: adding a upi-installer base image to the observability-operator configuration for the 4.20-azure variant.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR modifies only a YAML CI configuration file; no Ginkgo test files with test name definitions (It(), Describe(), Context(), etc.) are present or modified. The check is not applicable.
Test Structure And Quality	✅ Passed	This PR modifies only YAML CI configuration files, not Ginkgo test code. The check for test structure and quality is not applicable to configuration-only changes.
Microshift Test Compatibility	✅ Passed	PR only modifies CI configuration YAML file adding a base image, not code with new Ginkgo e2e tests. Check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR modifies only a CI configuration YAML file (adding a upi-installer base image), not Ginkgo test code. No e2e tests are added or modified, so the SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	This PR modifies only a CI operator config file to add a base image reference, not deployment manifests, operator code, or controllers. No scheduling constraints are introduced.
Ote Binary Stdout Contract	✅ Passed	PR only modifies YAML CI configuration file (upi-installer base image addition), not Go source code or OTE binary logic, so OTE stdout contract check is not applicable.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR modifies only a YAML CI operator config file, not Ginkgo e2e tests. The IPv6/disconnected network check applies only to new e2e test additions, making it inapplicable here.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[DavidRajnoha]

/pj-rehearse

[openshift-merge-bot]

@DavidRajnoha: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DavidRajnoha
Once this PR has been reviewed and has the lgtm label, please assign marioferh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/rhobs/observability-operator/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@ci-operator/config/rhobs/observability-operator/rhobs-observability-operator-main__amd64-ocp-4.20-azure.yaml`:
- Around line 10-13: You changed the ci-operator config entry (upi-installer
with name: "4.20" tag: upi-installer) under ci-operator/config; run `make
update` in the repo root to regenerate downstream artifacts, add any resulting
file diffs to this PR, or explicitly confirm in the PR description that `make
update` was a no-op and no artifacts changed so reviewers can verify compliance
with the CI-config regeneration rule.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0dc62a9a-af29-4d92-8a40-17e12c484590

📥 Commits

Reviewing files that changed from the base of the PR and between b1aa338 and d374754.

📒 Files selected for processing (1)

• ci-operator/config/rhobs/observability-operator/rhobs-observability-operator-main__amd64-ocp-4.20-azure.yaml

[coderabbitai]

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Run make update (or confirm no-op) for this ci-operator config change.

Since this PR modifies ci-operator/config (Lines 10-13), please run make update and include any generated artifact diff, or explicitly note that it was a no-op.

As per coding guidelines: "After modifying CI configuration files in ci-operator/config/, regenerate downstream artifacts by running make update".

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/rhobs/observability-operator/rhobs-observability-operator-main__amd64-ocp-4.20-azure.yaml`
around lines 10 - 13, You changed the ci-operator config entry (upi-installer
with name: "4.20" tag: upi-installer) under ci-operator/config; run `make
update` in the repo root to regenerate downstream artifacts, add any resulting
file diffs to this PR, or explicitly confirm in the PR description that `make
update` was a no-op and no artifacts changed so reviewers can verify compliance
with the CI-config regeneration rule.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@DavidRajnoha: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.20-azure-coo-stage	N/A	periodic	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@DavidRajnoha: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.20-azure-coo-stage	d374754	link	unknown	/pj-rehearse periodic-ci-rhobs-observability-operator-main-amd64-ocp-4.20-azure-coo-stage

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.