OCM-24532 | ci: enable DCO for openshift/rosa#79637
Conversation
Signed-off-by: lufreita <lufreita@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: olucasfreitas The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
WalkthroughProw plugin configuration for openshift/rosa is updated to enable the DCO plugin with red-hat-konflux configured as a trusted application. Changes span global plugin configuration and repository-specific plugin declarations. ChangesEnable DCO Plugin for openshift/rosa
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( |
|
@olucasfreitas: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR enables the Prow DCO (Developer Certificate of Origin) plugin for the
openshift/rosarepository and whitelistsred-hat-konfluxas a trusted app so Konflux/Renovate bot PRs are not blocked.Changes
core-services/prow/02_config/openshift/rosa/_pluginconfig.yaml-- adds- dcoto the plugins listcore-services/prow/02_config/_plugins.yaml-- addsopenshift/rosawithred-hat-konfluxas atrusted_appsentry under thedco:sectionContext
terraform-redhat/terraform-provider-rhcs,terraform-redhat/terraform-rhcs-rosa-classic, andterraform-redhat/terraform-rhcs-rosa-hcpNotes
dco-signoff: yes/dco-signoff: no) is intentionally not added to_prowconfig.yamlto avoid blockingopenshift-cherrypick-robotPRs, which is a regular GitHub user and cannot be exempted viatrusted_apps.git commit -sto add theSigned-off-bytrailer to their commits.