style(test): fix ruff violations in 4 files(identity_tools,test_compute/identity/image_tools) (#35)

Author: jja6312

src/openstack_mcp_server/tools/identity_tools.py

@@ -1,6 +1,7 @@
+from fastmcp import FastMCP
+
 from .base import get_openstack_conn
 from .response.keystone import Region
-from fastmcp import FastMCP
 
 
 class IdentityTools:
@@ -92,9 +93,9 @@ def update_region(self, id: str, description: str = "") -> Region:
         conn = get_openstack_conn()
 
         updated_region = conn.identity.update_region(
-            region=id, description=description
+            region=id, description=description,
         )
 
         return Region(
-            id=updated_region.id, description=updated_region.description
+            id=updated_region.id, description=updated_region.description,
         )

tests/tools/test_compute_tools.py

@@ -1,6 +1,8 @@
 from unittest.mock import Mock, call
-from openstack_mcp_server.tools.response.compute import Server
+
 from openstack_mcp_server.tools.compute_tools import ComputeTools
+from openstack_mcp_server.tools.response.compute import Server
+
 
 class TestComputeTools:
     """Test cases for ComputeTools class."""
@@ -76,7 +78,7 @@ def test_get_compute_servers_single_server(self, mock_get_openstack_conn):
         result = compute_tools.get_compute_servers()
 
         expected_output = [
-            Server(name="test-server", id="single-123", status="BUILDING")
+            Server(name="test-server", id="single-123", status="BUILDING"),
         ]
         assert result == expected_output
 
@@ -142,7 +144,7 @@ def test_get_compute_servers_with_special_characters(self, mock_get_openstack_co
 
         assert (
             Server(
-                name="web-server_test-01", id="id-with-dashes", status="ACTIVE"
+                name="web-server_test-01", id="id-with-dashes", status="ACTIVE",
             )
             in result
         )
@@ -165,7 +167,7 @@ def test_register_tools(self):
 
         mock_tool_decorator.assert_has_calls([
             call(compute_tools.get_compute_servers),
-            call(compute_tools.get_compute_server)
+            call(compute_tools.get_compute_server),
         ])
         assert mock_tool_decorator.call_count == 2
 

tests/tools/test_identity_tools.py

@@ -1,7 +1,10 @@
+from unittest.mock import Mock
+
 import pytest
+
 from openstack import exceptions
+
 from openstack_mcp_server.tools.identity_tools import IdentityTools, Region
-from unittest.mock import Mock
 
 
 class TestIdentityTools:
@@ -77,7 +80,7 @@ def test_create_region_success(self, mock_get_openstack_conn_identity):
 
         # Verify results
         assert result == Region(
-            id="RegionOne", description="Region One description"
+            id="RegionOne", description="Region One description",
         )
 
         # Verify mock calls
@@ -109,7 +112,7 @@ def test_create_region_invalid_id_format(self, mock_get_openstack_conn_identity)
         # Configure mock region.create_region() to raise an exception
         mock_conn.identity.create_region.side_effect = (
             exceptions.BadRequestException(
-                "Invalid input for field 'id': Expected string, got integer"
+                "Invalid input for field 'id': Expected string, got integer",
             )
         )
 
@@ -132,7 +135,7 @@ def test_delete_region_success(self, mock_get_openstack_conn_identity):
         result = identity_tools.delete_region(id="RegionOne")
 
         # Verify results
-        assert result == None
+        assert result is None
 
         # Verify mock calls
         mock_conn.identity.delete_region.assert_called_once_with(region="RegionOne", ignore_missing=False)
@@ -143,7 +146,7 @@ def test_delete_region_not_found(self, mock_get_openstack_conn_identity):
 
         # Configure mock to raise NotFoundException
         mock_conn.identity.delete_region.side_effect = exceptions.NotFoundException(
-            "Region 'RegionOne' not found"
+            "Region 'RegionOne' not found",
         )
 
         # Test delete_region()
@@ -206,7 +209,7 @@ def test_update_region_invalid_id_format(self, mock_get_openstack_conn_identity)
 
         # Configure mock region.update_region() to raise an exception
         mock_conn.identity.update_region.side_effect = exceptions.BadRequestException(
-            "Invalid input for field 'id': Expected string, got integer"
+            "Invalid input for field 'id': Expected string, got integer",
         )
 
         # Test update_region()
@@ -247,7 +250,7 @@ def test_get_region_not_found(self, mock_get_openstack_conn_identity):
 
         # Configure mock to raise NotFoundException
         mock_conn.identity.get_region.side_effect = exceptions.NotFoundException(
-            "Region 'RegionOne' not found"
+            "Region 'RegionOne' not found",
         )
 
         # Test get_region()

tests/tools/test_image_tools.py

@@ -1,7 +1,8 @@
-import pytest
 from unittest.mock import Mock
+
 from openstack_mcp_server.tools.image_tools import ImageTools
 
+
 class TestImageTools:
     """Test cases for ImageTools class."""