From 5a65fee8f1fc3150beac43f6f4f9690e27d84b0e Mon Sep 17 00:00:00 2001 From: John Reed <87283488+JohnReedV@users.noreply.github.com> Date: Tue, 5 May 2026 07:11:30 -0700 Subject: [PATCH 1/3] fix comment --- pallets/subtensor/src/coinbase/run_coinbase.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pallets/subtensor/src/coinbase/run_coinbase.rs b/pallets/subtensor/src/coinbase/run_coinbase.rs index 60abfd1145..ebb009937b 100644 --- a/pallets/subtensor/src/coinbase/run_coinbase.rs +++ b/pallets/subtensor/src/coinbase/run_coinbase.rs @@ -30,8 +30,8 @@ impl Pallet { ); // Reset per-block root sell counters from the previous block. - // Root sells (step 8 in block_step) happen after coinbase, so their - // accumulated values are consumed here at the start of the next block. + // Root sells happen after coinbase, so their accumulated values + // are consumed here at the start of the next block. let _ = SubnetRootSellTao::::clear(u32::MAX, None); // --- 1. Get all subnets (excluding root). From ba5942e75e14cc92a45e72e8aea5031f400a2fc5 Mon Sep 17 00:00:00 2001 From: John Reed <87283488+JohnReedV@users.noreply.github.com> Date: Tue, 5 May 2026 07:11:47 -0700 Subject: [PATCH 2/3] fix unnecessary read --- pallets/subtensor/src/coinbase/subnet_emissions.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pallets/subtensor/src/coinbase/subnet_emissions.rs b/pallets/subtensor/src/coinbase/subnet_emissions.rs index 44f7cdb163..57a03362c6 100644 --- a/pallets/subtensor/src/coinbase/subnet_emissions.rs +++ b/pallets/subtensor/src/coinbase/subnet_emissions.rs @@ -223,8 +223,8 @@ impl Pallet { .iter() .map(|netuid| { let user_ema = Self::get_ema_flow(*netuid); - let protocol_ema = Self::get_ema_protocol_flow(*netuid); let net = if net_flow_enabled { + let protocol_ema = Self::get_ema_protocol_flow(*netuid); user_ema.saturating_sub(protocol_ema) } else { user_ema From 6e43d52c0fc3dcd3dd9e59af6809e82137f3b550 Mon Sep 17 00:00:00 2001 From: John Reed <87283488+JohnReedV@users.noreply.github.com> Date: Tue, 5 May 2026 07:36:18 -0700 Subject: [PATCH 3/3] get => update ema_protocol_flow --- pallets/subtensor/src/coinbase/subnet_emissions.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pallets/subtensor/src/coinbase/subnet_emissions.rs b/pallets/subtensor/src/coinbase/subnet_emissions.rs index 57a03362c6..485e2cf662 100644 --- a/pallets/subtensor/src/coinbase/subnet_emissions.rs +++ b/pallets/subtensor/src/coinbase/subnet_emissions.rs @@ -67,7 +67,7 @@ impl Pallet { SubnetProtocolFlow::::remove(netuid); } - fn get_ema_protocol_flow(netuid: NetUid) -> I64F64 { + fn update_ema_protocol_flow(netuid: NetUid) -> I64F64 { let current_block: u64 = Self::get_current_block_as_u64(); let block_flow = I64F64::saturating_from_num(SubnetProtocolFlow::::get(netuid)); @@ -224,7 +224,7 @@ impl Pallet { .map(|netuid| { let user_ema = Self::get_ema_flow(*netuid); let net = if net_flow_enabled { - let protocol_ema = Self::get_ema_protocol_flow(*netuid); + let protocol_ema = Self::update_ema_protocol_flow(*netuid); user_ema.saturating_sub(protocol_ema) } else { user_ema