Merge pull request #58 from header-bidder/IR-4792

OpenX adapter: Make mediaType default to banner when none is specified

Author: leon-ho

modules/openxBidAdapter.js

@@ -30,8 +30,15 @@ export const spec = {
     let requests = [];
     let bannerRequests = [];
     let videoRequests = [];
-    let bannerBids = bids.filter(function(bid) { return bid.mediaType === BANNER; });
-    let videoBids = bids.filter(function(bid) { return bid.mediaType === VIDEO; });
+    let bannerBids = [];
+    let videoBids = [];
+    bids.forEach(function (bid) {
+      if (bid.mediaType === VIDEO) {
+        videoBids.push(bid);
+      } else {
+        bannerBids.push(bid);
+      }
+    });
 
     // build banner requests
     if (bannerBids.length !== 0) {

test/spec/modules/openxBidAdapter_spec.js

@@ -72,7 +72,19 @@ describe('OpenxAdapter', () => {
     });
   });
 
-  describe('buildRequests for banner ads', () => {
+  describe.only('buildRequests for banner ads', () => {
+    let bidRequestsWithNoMediaType = [{
+      'bidder': 'openx',
+      'params': {
+        'unit': '12345678',
+        'delDomain': 'test-del-domain'
+      },
+      'adUnitCode': 'adunit-code',
+      'sizes': [[300, 250], [300, 600]],
+      'bidId': '30b31c1838de1e',
+      'bidderRequestId': '22edbae2733bf6',
+      'auctionId': '1d1a030790a475',
+    }];
     let bidRequests = [{
       'bidder': 'openx',
       'params': {
@@ -87,6 +99,12 @@ describe('OpenxAdapter', () => {
       'auctionId': '1d1a030790a475',
     }];
 
+    it('should send bid request to openx url via GET, even without mediaType specified', () => {
+      const request = spec.buildRequests(bidRequestsWithNoMediaType);
+      expect(request[0].url).to.equal('//' + bidRequests[0].params.delDomain + URLBASE);
+      expect(request[0].method).to.equal('GET');
+    });
+
     it('should send bid request to openx url via GET', () => {
       const request = spec.buildRequests(bidRequests);
       expect(request[0].url).to.equal('//' + bidRequests[0].params.delDomain + URLBASE);