Skip to content

Commit 00d0d6e

Browse files
authored
removed deprecated pkg_resources.get_distributution().version (#288)
- included importlib.metadata.version for python package version identification
1 parent a180993 commit 00d0d6e

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

modelstore/__init__.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@
1111
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
14-
from pkg_resources import DistributionNotFound, get_distribution
14+
from importlib.metadata import version
1515

1616
# pylint: disable=unused-import
1717
from modelstore.model_store import ModelStore
1818

1919
try:
20-
__version__ = get_distribution("modelstore").version
21-
except DistributionNotFound:
20+
__version__ = version("modelstore")
21+
except PackageNotFoundError:
2222
__version__ = "unavailable"

modelstore/metadata/code/dependencies.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
import importlib
1515
import sys
1616

17-
import pkg_resources
17+
from importlib.metadata import version
1818

1919
from modelstore.utils.log import logger
2020

@@ -37,7 +37,7 @@ def _get_version(modname: str) -> str:
3737
except AttributeError:
3838
try:
3939
#  Annoy does not have a __version__
40-
return pkg_resources.get_distribution(modname).version
40+
return version(modname)
4141
except Exception:
4242
logger.debug("Unable to get %s's version", modname)
4343
return None

modelstore/models/model_manager.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ def upload(
225225

226226
def _format_numpy(model_params: dict) -> dict:
227227
for key, value in model_params.items():
228-
if isinstance(value, (np.float_, np.float16, np.float32, np.float64)):
228+
if isinstance(value, (np.float16, np.float32, np.float64, np.float96)):
229229
model_params[key] = float(value)
230230
if isinstance(value, np.ndarray):
231231
model_params[key] = value.tolist()

0 commit comments

Comments
 (0)