Skip to content

Commit c46fe95

Browse files
blm768mlmoravek
blm768
and
mlmoravek
authored
fix: add type="button" where the default tag is a button element to prevent form submission (#1324)
* fix(tabs): avoid performance warning in OSlotComponent When the default slot for a VNode is a raw VNode instead of a function, Vue complains about it in development mode. * fix(tabs): specify button type (#1323) * refactor: update imports * refactor: add `attrs` binding to PlainButton --------- Co-authored-by: mmoravek <marcel.moravek@yahoo.de>
1 parent de74d59 commit c46fe95

File tree

11 files changed

+77
-48
lines changed

11 files changed

+77
-48
lines changed

‎packages/docs/components/Menu.md‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -73,22 +73,22 @@ The component implements the W3C ARIA APG [Tree View Pattern](https://www.w3.org
7373

7474
### Props
7575

76-
| Prop name | Description | Type | Values | Default |
77-
| --------- | --------------------------------------------------------------------------------- | -------------------------- | ------------------------------------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------- |
78-
| active | The active state of the menu item, use v-model:active to make it two-way binding | boolean | - | <code style='white-space: nowrap; padding: 0;'>false</code> |
79-
| animation | Transition name to apply on menu list | string | - | <div><small>From <b>config</b>:</small></div><code style='white-space: nowrap; padding: 0;'>menu: {<br>&nbsp;&nbsp;animation: "slide"<br>}</code> |
80-
| disabled | Menu item will be disabled | boolean | - | <code style='white-space: nowrap; padding: 0;'>false</code> |
81-
| expanded | Menu item will be expanded | boolean | - | <code style='white-space: nowrap; padding: 0;'>false</code> |
82-
| hidden | Define whether the item is visible or not | boolean | - | <code style='white-space: nowrap; padding: 0;'>false</code> |
83-
| icon | Icon to be shown | string | - | |
84-
| iconPack | Icon pack to use | string | `mdi`, `fa`, `fas and any other custom icon pack` | <div><small>From <b>config</b>:</small></div><code style='white-space: nowrap; padding: 0;'>menu: {<br>&nbsp;&nbsp;iconPack: undefined<br>}</code> |
85-
| iconSize | Icon size | string | `small`, `medium`, `large` | <div><small>From <b>config</b>:</small></div><code style='white-space: nowrap; padding: 0;'>menu: {<br>&nbsp;&nbsp;iconSize: undefined<br>}</code> |
86-
| label | Menu item label | string | - | |
87-
| options | Submenu items, unnecessary when default slot is used | OptionsProp&lt;unknown&gt; | - | |
88-
| override | Override existing theme classes completely | boolean | - | |
89-
| submenuId | HTML element Id of the sub menu ol list element | string | - | <code style='white-space: nowrap; padding: 0;'>useId()</code> |
90-
| tag | Menu item tag name | DynamicComponent | - | <div><small>From <b>config</b>:</small></div><code style='white-space: nowrap; padding: 0;'>menu: {<br>&nbsp;&nbsp;itemTag: "button"<br>}</code> |
91-
| value | Item value (it will be used as v-model of wrapper component) - default is an uuid | unknown | - | <code style='white-space: nowrap; padding: 0;'></code> |
76+
| Prop name | Description | Type | Values | Default |
77+
| --------- | --------------------------------------------------------------------------------- | -------------------------- | ------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------- |
78+
| active | The active state of the menu item, use v-model:active to make it two-way binding | boolean | - | <code style='white-space: nowrap; padding: 0;'>false</code> |
79+
| animation | Transition name to apply on menu list | string | - | <div><small>From <b>config</b>:</small></div><code style='white-space: nowrap; padding: 0;'>menu: {<br>&nbsp;&nbsp;animation: "slide"<br>}</code> |
80+
| disabled | Menu item will be disabled | boolean | - | <code style='white-space: nowrap; padding: 0;'>false</code> |
81+
| expanded | Menu item will be expanded | boolean | - | <code style='white-space: nowrap; padding: 0;'>false</code> |
82+
| hidden | Define whether the item is visible or not | boolean | - | <code style='white-space: nowrap; padding: 0;'>false</code> |
83+
| icon | Icon to be shown | string | - | |
84+
| iconPack | Icon pack to use | string | `mdi`, `fa`, `fas and any other custom icon pack` | <div><small>From <b>config</b>:</small></div><code style='white-space: nowrap; padding: 0;'>menu: {<br>&nbsp;&nbsp;iconPack: undefined<br>}</code> |
85+
| iconSize | Icon size | string | `small`, `medium`, `large` | <div><small>From <b>config</b>:</small></div><code style='white-space: nowrap; padding: 0;'>menu: {<br>&nbsp;&nbsp;iconSize: undefined<br>}</code> |
86+
| label | Menu item label | string | - | |
87+
| options | Submenu items, unnecessary when default slot is used | OptionsProp&lt;unknown&gt; | - | |
88+
| override | Override existing theme classes completely | boolean | - | |
89+
| submenuId | HTML element Id of the sub menu ol list element | string | - | <code style='white-space: nowrap; padding: 0;'>useId()</code> |
90+
| tag | Menu item tag name | DynamicComponent | - | <div><small>From <b>config</b>:</small></div><code style='white-space: nowrap; padding: 0;'>menu: {<br>&nbsp;&nbsp;itemTag: PlainButton<br>}</code> |
91+
| value | Item value (it will be used as v-model of wrapper component) - default is an uuid | unknown | - | <code style='white-space: nowrap; padding: 0;'></code> |
9292

9393
### Events
9494

‎packages/docs/components/Pagination.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ The **Pagination** component is responsive and flexible way to indicate a series
3232
| ariaNextLabel | Accessibility label for the next page button. | string | - | <div><small>From <b>config</b>:</small></div><code style='white-space: nowrap; padding: 0;'>pagination: {<br>&nbsp;&nbsp;ariaNextLabel: "Next page"<br>}</code> |
3333
| ariaPageLabel | Accessibility label for the page button. | string | - | <div><small>From <b>config</b>:</small></div><code style='white-space: nowrap; padding: 0;'>pagination: {<br>&nbsp;&nbsp;ariaPageLabel: "Page"<br>}</code> |
3434
| ariaPreviousLabel | Accessibility label for the previous page button. | string | - | <div><small>From <b>config</b>:</small></div><code style='white-space: nowrap; padding: 0;'>pagination: {<br>&nbsp;&nbsp;ariaPreviousLabel: "Previous page"<br>}</code> |
35-
| buttonTag | Pagination button tag name | DynamicComponent | - | <div><small>From <b>config</b>:</small></div><code style='white-space: nowrap; padding: 0;'>pagination: {<br>&nbsp;&nbsp;buttonTag: "button"<br>}</code> |
35+
| buttonTag | Pagination button tag name | DynamicComponent | - | <div><small>From <b>config</b>:</small></div><code style='white-space: nowrap; padding: 0;'>pagination: {<br>&nbsp;&nbsp;buttonTag: PlainButton<br>}</code> |
3636
| current | Current page number, use v-model:current to make it two-way binding | number | - | <code style='white-space: nowrap; padding: 0;'>1</code> |
3737
| iconNext | Icon to use for next button | string | - | <div><small>From <b>config</b>:</small></div><code style='white-space: nowrap; padding: 0;'>pagination: {<br>&nbsp;&nbsp;iconNext: "chevron-right"<br>}</code> |
3838
| iconPack | Icon pack to use | string | `mdi`, `fa`, `fas and any other custom icon pack` | <div><small>From <b>config</b>:</small></div><code style='white-space: nowrap; padding: 0;'>pagination: {<br>&nbsp;&nbsp;iconPack: undefined<br>}</code> |

0 commit comments

Comments
 (0)