From ec278efdd197cdc30bccf0a78cff1f2b7b0971b8 Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Thu, 1 Sep 2022 13:23:58 +0200
Subject: [PATCH 01/25] Add forbidden ids

---
 .../components/FilesList/KeyboardActions.vue  | 22 ++++++++++++++++---
 1 file changed, 19 insertions(+), 3 deletions(-)

diff --git a/packages/web-app-files/src/components/FilesList/KeyboardActions.vue b/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
index dfd26ff44fc..69f320c3d94 100644
--- a/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
+++ b/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
@@ -20,6 +20,11 @@ export default defineComponent({
       type: Array,
       required: false,
       default: () => ['files-view', 'web-nav-sidebar']
+    },
+    forbiddenIds: {
+      type: Array,
+      required: false,
+      default: () => ['context-menu-drop', 'files-share-invite-input']
     }
   },
   setup() {
@@ -98,16 +103,27 @@ export default defineComponent({
 
     handleClipboardShortcuts(event) {
       const key = event.keyCode || event.which
+      const shift = event.shiftKey
       const ctrl = window.navigator.platform.match('Mac') ? event.metaKey : event.ctrlKey
       const isCopyAction = key === 67
       const isPasteAction = key === 86
       const isCutAction = key === 88
+      const isUpPressed = key === 38
+      const isDownPressed = key === 40
       const isTextSelected = window.getSelection().type === 'Range'
 
+      for(const id of this.forbiddenIds) {
+        const result = document.querySelector(`[id*="${id}"]`)
+        if(result) return
+      }
+
       if (isTextSelected) return
       if (isCopyAction && ctrl) return this.copySelectedFiles()
       if (isPasteAction && ctrl) return this.handlePasteAction()
       if (isCutAction && ctrl) return this.cutSelectedFiles()
+
+      if (isDownPressed && !shift) return this.handleNavigateAction(event)
+      if (isUpPressed && !shift) return this.handleNavigateAction(event, true)
     },
 
     handleFileSelectionShortcuts(key, shift, ctrl, event) {
@@ -117,8 +133,8 @@ export default defineComponent({
       const isSpacePressed = key === 32
       const isAPressed = key === 65
 
-      if (isDownPressed && !shift) return this.handleNavigateAction(event)
-      if (isUpPressed && !shift) return this.handleNavigateAction(event, true)
+      //if (isDownPressed && !shift) return this.handleNavigateAction(event)
+      //if (isUpPressed && !shift) return this.handleNavigateAction(event, true)
       if (isSpacePressed) return this.handleSpaceAction(event)
       if (isEscapePressed) return this.handleEscapeAction()
       if (isDownPressed && shift) return this.handleShiftDownAction(event)
@@ -139,7 +155,7 @@ export default defineComponent({
       this.resetFileSelection()
       this.addFileSelection({ id: nextId })
       this.scrollToResource({ id: nextId })
-      document.getElementById(this.keybindOnElementId).focus()
+      document.getElementById(this.keybindOnElementIds[0]).focus()
     },
 
     handleShiftClickAction(resource) {

From 13231ac72a42c72294f184ef95698feb02064237 Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Thu, 1 Sep 2022 13:24:28 +0200
Subject: [PATCH 02/25] Remove old code

---
 .../src/components/FilesList/KeyboardActions.vue              | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/packages/web-app-files/src/components/FilesList/KeyboardActions.vue b/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
index 69f320c3d94..0415d6e426d 100644
--- a/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
+++ b/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
@@ -132,9 +132,7 @@ export default defineComponent({
       const isEscapePressed = key === 27
       const isSpacePressed = key === 32
       const isAPressed = key === 65
-
-      //if (isDownPressed && !shift) return this.handleNavigateAction(event)
-      //if (isUpPressed && !shift) return this.handleNavigateAction(event, true)
+      
       if (isSpacePressed) return this.handleSpaceAction(event)
       if (isEscapePressed) return this.handleEscapeAction()
       if (isDownPressed && shift) return this.handleShiftDownAction(event)

From 8866ba7d2a40193ec58640bc7b44b5695025fafe Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Thu, 1 Sep 2022 13:30:54 +0200
Subject: [PATCH 03/25] Linting, Unittests

---
 .../src/components/FilesList/KeyboardActions.vue            | 6 +++---
 .../unit/views/spaces/__snapshots__/Project.spec.js.snap    | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/packages/web-app-files/src/components/FilesList/KeyboardActions.vue b/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
index 0415d6e426d..573e1f9dd63 100644
--- a/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
+++ b/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
@@ -112,9 +112,9 @@ export default defineComponent({
       const isDownPressed = key === 40
       const isTextSelected = window.getSelection().type === 'Range'
 
-      for(const id of this.forbiddenIds) {
+      for (const id of this.forbiddenIds) {
         const result = document.querySelector(`[id*="${id}"]`)
-        if(result) return
+        if (result) return
       }
 
       if (isTextSelected) return
@@ -132,7 +132,7 @@ export default defineComponent({
       const isEscapePressed = key === 27
       const isSpacePressed = key === 32
       const isAPressed = key === 65
-      
+
       if (isSpacePressed) return this.handleSpaceAction(event)
       if (isEscapePressed) return this.handleEscapeAction()
       if (isDownPressed && shift) return this.handleShiftDownAction(event)
diff --git a/packages/web-app-files/tests/unit/views/spaces/__snapshots__/Project.spec.js.snap b/packages/web-app-files/tests/unit/views/spaces/__snapshots__/Project.spec.js.snap
index e5af682d58b..7ca05c7efa8 100644
--- a/packages/web-app-files/tests/unit/views/spaces/__snapshots__/Project.spec.js.snap
+++ b/packages/web-app-files/tests/unit/views/spaces/__snapshots__/Project.spec.js.snap
@@ -2,7 +2,7 @@
 
 exports[`Spaces project view space image should show if given 1`] = `
 <div class="space-overview oc-flex">
-  <keyboard-actions-stub paginatedresources="" keybindonelementids="files-view,web-nav-sidebar"></keyboard-actions-stub>
+  <keyboard-actions-stub paginatedresources="" keybindonelementids="files-view,web-nav-sidebar" forbiddenids="context-menu-drop,files-share-invite-input"></keyboard-actions-stub>
   <files-view-wrapper-stub>
     <app-bar-stub breadcrumbs="" breadcrumbscontextactionsitems="[object Object]" hasbulkactions="true" hassidebartoggle="true" hasviewoptions="true" showactionsonselection="true"></app-bar-stub>
     <div>
@@ -41,7 +41,7 @@ exports[`Spaces project view space image should show if given 1`] = `
 
 exports[`Spaces project view space readme should show if given 1`] = `
 <div class="space-overview oc-flex">
-  <keyboard-actions-stub paginatedresources="" keybindonelementids="files-view,web-nav-sidebar"></keyboard-actions-stub>
+  <keyboard-actions-stub paginatedresources="" keybindonelementids="files-view,web-nav-sidebar" forbiddenids="context-menu-drop,files-share-invite-input"></keyboard-actions-stub>
   <files-view-wrapper-stub>
     <app-bar-stub breadcrumbs="" breadcrumbscontextactionsitems="[object Object]" hasbulkactions="true" hassidebartoggle="true" hasviewoptions="true" showactionsonselection="true"></app-bar-stub>
     <div>

From f907bcd6e4acaf832d74717353ba019541eb1245 Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Fri, 2 Sep 2022 13:22:40 +0200
Subject: [PATCH 04/25] Add CustomKeyBindings directive

---
 .../components/FilesList/KeyboardActions.vue   | 15 ++++++++++-----
 packages/web-app-files/src/views/Personal.vue  |  3 +--
 .../src/directives/customKeyBindings.js        | 18 ++++++++++++++++++
 3 files changed, 29 insertions(+), 7 deletions(-)
 create mode 100644 packages/web-runtime/src/directives/customKeyBindings.js

diff --git a/packages/web-app-files/src/components/FilesList/KeyboardActions.vue b/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
index 573e1f9dd63..1a7101eb144 100644
--- a/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
+++ b/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
@@ -24,7 +24,7 @@ export default defineComponent({
     forbiddenIds: {
       type: Array,
       required: false,
-      default: () => ['context-menu-drop', 'files-share-invite-input']
+      default: () => ['context-menu-drop']
     }
   },
   setup() {
@@ -112,16 +112,14 @@ export default defineComponent({
       const isDownPressed = key === 40
       const isTextSelected = window.getSelection().type === 'Range'
 
-      for (const id of this.forbiddenIds) {
-        const result = document.querySelector(`[id*="${id}"]`)
-        if (result) return
-      }
 
       if (isTextSelected) return
       if (isCopyAction && ctrl) return this.copySelectedFiles()
       if (isPasteAction && ctrl) return this.handlePasteAction()
       if (isCutAction && ctrl) return this.cutSelectedFiles()
 
+      const selection = window.getSelection()
+      if(selection.type === "None")
       if (isDownPressed && !shift) return this.handleNavigateAction(event)
       if (isUpPressed && !shift) return this.handleNavigateAction(event, true)
     },
@@ -133,6 +131,13 @@ export default defineComponent({
       const isSpacePressed = key === 32
       const isAPressed = key === 65
 
+      for (const id of this.forbiddenIds) {
+        const result = document.querySelector(`[id*="${id}"]`)
+        if (result) return
+      }
+
+      if (isDownPressed && !shift) return this.handleNavigateAction(event)
+      if (isUpPressed && !shift) return this.handleNavigateAction(event, true)
       if (isSpacePressed) return this.handleSpaceAction(event)
       if (isEscapePressed) return this.handleEscapeAction()
       if (isDownPressed && shift) return this.handleShiftDownAction(event)
diff --git a/packages/web-app-files/src/views/Personal.vue b/packages/web-app-files/src/views/Personal.vue
index 16a9cb3fa0c..f8c1dffdfd3 100644
--- a/packages/web-app-files/src/views/Personal.vue
+++ b/packages/web-app-files/src/views/Personal.vue
@@ -1,5 +1,5 @@
 <template>
-  <div class="oc-flex">
+  <div class="oc-flex" v-custom-key-bindings>
     <keyboard-actions :paginated-resources="paginatedResources" />
     <files-view-wrapper>
       <app-bar
@@ -266,7 +266,6 @@ export default defineComponent({
       'REMOVE_FILES_FROM_SEARCHED',
       'REMOVE_FILE_SELECTION'
     ]),
-
     async fileDropped(fileIdTarget) {
       const selected = [...this.selectedResources]
       const targetInfo = this.paginatedResources.find((e) => e.id === fileIdTarget)
diff --git a/packages/web-runtime/src/directives/customKeyBindings.js b/packages/web-runtime/src/directives/customKeyBindings.js
new file mode 100644
index 00000000000..0b12610ac45
--- /dev/null
+++ b/packages/web-runtime/src/directives/customKeyBindings.js
@@ -0,0 +1,18 @@
+import { bus } from 'web-pkg/src/instance'
+
+function onFocus() {
+  bus.publish('app.keybind.disable')
+}
+function onBlur() {
+  bus.publish('app.keybind.enable')
+}
+export default {
+  inserted: (el) => {
+    el.addEventListener("focus", onFocus)
+    el.addEventListener("blur", onBlur)
+  },
+  unbind: (el) => {
+    el.removeEventListener("focus", onFocus)
+    el.removeEventListener("blur", onBlur)
+  }
+}
\ No newline at end of file

From cfa37dc8f2cfbc6aca7477cd59905d26de4b31fc Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Fri, 2 Sep 2022 14:18:08 +0200
Subject: [PATCH 05/25] Use data-attribute instead of directive

---
 .../components/FilesList/KeyboardActions.vue  | 21 ++++++-------------
 .../InviteCollaboratorForm.vue                |  4 ++--
 packages/web-app-files/src/views/Personal.vue |  2 +-
 .../src/directives/customKeyBindings.js       | 18 ----------------
 4 files changed, 9 insertions(+), 36 deletions(-)
 delete mode 100644 packages/web-runtime/src/directives/customKeyBindings.js

diff --git a/packages/web-app-files/src/components/FilesList/KeyboardActions.vue b/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
index 1a7101eb144..1c60485b27b 100644
--- a/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
+++ b/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
@@ -20,11 +20,6 @@ export default defineComponent({
       type: Array,
       required: false,
       default: () => ['files-view', 'web-nav-sidebar']
-    },
-    forbiddenIds: {
-      type: Array,
-      required: false,
-      default: () => ['context-menu-drop']
     }
   },
   setup() {
@@ -111,15 +106,14 @@ export default defineComponent({
       const isUpPressed = key === 38
       const isDownPressed = key === 40
       const isTextSelected = window.getSelection().type === 'Range'
-
+ 
+      const customKeyBindings = (window.getSelection().focusNode as HTMLElement)?.closest("[data-custom-key-bindings='true']")
+      if(customKeyBindings) return
 
       if (isTextSelected) return
       if (isCopyAction && ctrl) return this.copySelectedFiles()
       if (isPasteAction && ctrl) return this.handlePasteAction()
       if (isCutAction && ctrl) return this.cutSelectedFiles()
-
-      const selection = window.getSelection()
-      if(selection.type === "None")
       if (isDownPressed && !shift) return this.handleNavigateAction(event)
       if (isUpPressed && !shift) return this.handleNavigateAction(event, true)
     },
@@ -131,13 +125,10 @@ export default defineComponent({
       const isSpacePressed = key === 32
       const isAPressed = key === 65
 
-      for (const id of this.forbiddenIds) {
-        const result = document.querySelector(`[id*="${id}"]`)
-        if (result) return
-      }
+      
 
-      if (isDownPressed && !shift) return this.handleNavigateAction(event)
-      if (isUpPressed && !shift) return this.handleNavigateAction(event, true)
+      /*if (isDownPressed && !shift) return this.handleNavigateAction(event)
+      if (isUpPressed && !shift) return this.handleNavigateAction(event, true)*/
       if (isSpacePressed) return this.handleSpaceAction(event)
       if (isEscapePressed) return this.handleEscapeAction()
       if (isDownPressed && shift) return this.handleShiftDownAction(event)
diff --git a/packages/web-app-files/src/components/SideBar/Shares/Collaborators/InviteCollaborator/InviteCollaboratorForm.vue b/packages/web-app-files/src/components/SideBar/Shares/Collaborators/InviteCollaborator/InviteCollaboratorForm.vue
index f749615e1c5..2b8991a9cd7 100644
--- a/packages/web-app-files/src/components/SideBar/Shares/Collaborators/InviteCollaborator/InviteCollaboratorForm.vue
+++ b/packages/web-app-files/src/components/SideBar/Shares/Collaborators/InviteCollaborator/InviteCollaboratorForm.vue
@@ -1,5 +1,5 @@
 <template>
-  <div id="new-collaborators-form" data-testid="new-collaborators-form">
+  <div id="new-collaborators-form" data-testid="new-collaborators-form" data-custom-key-bindings=true>
     <oc-select
       id="files-share-invite-input"
       ref="ocSharingAutocomplete"
@@ -17,7 +17,7 @@
       @input="resetFocusOnInvite"
     >
       <template #option="option">
-        <autocomplete-item :item="option" />
+        <autocomplete-item :item="option"/>
       </template>
       <template #no-options>
         <translate v-if="resourceIsSpace"> No users found. </translate>
diff --git a/packages/web-app-files/src/views/Personal.vue b/packages/web-app-files/src/views/Personal.vue
index f8c1dffdfd3..5bdbb836d46 100644
--- a/packages/web-app-files/src/views/Personal.vue
+++ b/packages/web-app-files/src/views/Personal.vue
@@ -1,5 +1,5 @@
 <template>
-  <div class="oc-flex" v-custom-key-bindings>
+  <div class="oc-flex">
     <keyboard-actions :paginated-resources="paginatedResources" />
     <files-view-wrapper>
       <app-bar
diff --git a/packages/web-runtime/src/directives/customKeyBindings.js b/packages/web-runtime/src/directives/customKeyBindings.js
deleted file mode 100644
index 0b12610ac45..00000000000
--- a/packages/web-runtime/src/directives/customKeyBindings.js
+++ /dev/null
@@ -1,18 +0,0 @@
-import { bus } from 'web-pkg/src/instance'
-
-function onFocus() {
-  bus.publish('app.keybind.disable')
-}
-function onBlur() {
-  bus.publish('app.keybind.enable')
-}
-export default {
-  inserted: (el) => {
-    el.addEventListener("focus", onFocus)
-    el.addEventListener("blur", onBlur)
-  },
-  unbind: (el) => {
-    el.removeEventListener("focus", onFocus)
-    el.removeEventListener("blur", onBlur)
-  }
-}
\ No newline at end of file

From 5962c3aebff7e1898798bb92232e8b0e86e451ae Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Fri, 2 Sep 2022 14:24:30 +0200
Subject: [PATCH 06/25] Custom keyboard actions searchbar

---
 .../src/components/FilesList/KeyboardActions.vue              | 4 ----
 packages/web-app-search/src/portals/SearchBar.vue             | 1 +
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/packages/web-app-files/src/components/FilesList/KeyboardActions.vue b/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
index 1c60485b27b..97fd6752e2f 100644
--- a/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
+++ b/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
@@ -125,10 +125,6 @@ export default defineComponent({
       const isSpacePressed = key === 32
       const isAPressed = key === 65
 
-      
-
-      /*if (isDownPressed && !shift) return this.handleNavigateAction(event)
-      if (isUpPressed && !shift) return this.handleNavigateAction(event, true)*/
       if (isSpacePressed) return this.handleSpaceAction(event)
       if (isEscapePressed) return this.handleEscapeAction()
       if (isDownPressed && shift) return this.handleShiftDownAction(event)
diff --git a/packages/web-app-search/src/portals/SearchBar.vue b/packages/web-app-search/src/portals/SearchBar.vue
index 858d7a2d46b..7dd81fe9789 100644
--- a/packages/web-app-search/src/portals/SearchBar.vue
+++ b/packages/web-app-search/src/portals/SearchBar.vue
@@ -3,6 +3,7 @@
     v-if="availableProviders.length"
     id="files-global-search"
     :class="{ 'options-visible': optionsVisible && term }"
+    data-custom-key-bindings=true
   >
     <oc-search-bar
       id="files-global-search-bar"

From 7d35134f17707908019ff8697d07d74b22d7f712 Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Fri, 2 Sep 2022 14:29:54 +0200
Subject: [PATCH 07/25] Add custom keybindings to FileLinks, FileShares,
 SpaceMembers

---
 .../web-app-files/src/components/SideBar/Shares/FileLinks.vue   | 2 +-
 .../web-app-files/src/components/SideBar/Shares/FileShares.vue  | 2 +-
 .../src/components/SideBar/Shares/SpaceMembers.vue              | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue b/packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue
index e527a9967c7..f38c07c3e7e 100644
--- a/packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue
+++ b/packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue
@@ -1,5 +1,5 @@
 <template>
-  <div id="oc-files-file-link" class="oc-position-relative">
+  <div id="oc-files-file-link" class="oc-position-relative" data-custom-key-bindings=true>
     <div class="oc-flex">
       <h3 class="oc-text-bold oc-text-medium oc-m-rm" v-text="linksHeading" />
       <oc-contextual-helper v-if="helpersEnabled" class="oc-pl-xs" v-bind="viaLinkHelp" />
diff --git a/packages/web-app-files/src/components/SideBar/Shares/FileShares.vue b/packages/web-app-files/src/components/SideBar/Shares/FileShares.vue
index 7efa9e41a50..c893188465e 100644
--- a/packages/web-app-files/src/components/SideBar/Shares/FileShares.vue
+++ b/packages/web-app-files/src/components/SideBar/Shares/FileShares.vue
@@ -1,5 +1,5 @@
 <template>
-  <div id="oc-files-sharing-sidebar" class="oc-position-relative">
+  <div id="oc-files-sharing-sidebar" class="oc-position-relative" data-custom-key-bindings=true>
     <div class="oc-flex">
       <h3 v-translate class="oc-text-bold oc-text-medium oc-m-rm">Share with people</h3>
       <oc-contextual-helper
diff --git a/packages/web-app-files/src/components/SideBar/Shares/SpaceMembers.vue b/packages/web-app-files/src/components/SideBar/Shares/SpaceMembers.vue
index 18283e20db8..e5aad773075 100644
--- a/packages/web-app-files/src/components/SideBar/Shares/SpaceMembers.vue
+++ b/packages/web-app-files/src/components/SideBar/Shares/SpaceMembers.vue
@@ -1,5 +1,5 @@
 <template>
-  <div id="oc-files-sharing-sidebar" class="oc-position-relative">
+  <div id="oc-files-sharing-sidebar" class="oc-position-relative" data-custom-key-bindings=true>
     <div class="oc-flex">
       <h3 v-translate class="oc-text-bold oc-text-medium oc-m-rm">Members</h3>
       <oc-contextual-helper v-if="helpersEnabled" class="oc-pl-xs" v-bind="spaceAddMemberHelp" />

From 713e812ec2f59da5fa2ad4b73afcd5fda63136b8 Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Fri, 2 Sep 2022 14:55:03 +0200
Subject: [PATCH 08/25] Add changelog

---
 changelog/unreleased/enhancement-make-keybinds-global | 5 +++++
 1 file changed, 5 insertions(+)
 create mode 100644 changelog/unreleased/enhancement-make-keybinds-global

diff --git a/changelog/unreleased/enhancement-make-keybinds-global b/changelog/unreleased/enhancement-make-keybinds-global
new file mode 100644
index 00000000000..39b16ad3da0
--- /dev/null
+++ b/changelog/unreleased/enhancement-make-keybinds-global
@@ -0,0 +1,5 @@
+Enhancement: Make keybinds global
+
+We've set keybinds globally and introduced a data-attribute to mark elements that need custom keybinds
+
+https://github.com/owncloud/web/pull/7569

From 1afe44b538b55857a44dc515058c70356e59b45c Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Fri, 2 Sep 2022 14:59:42 +0200
Subject: [PATCH 09/25] Update snapshots

---
 .../Shares/__snapshots__/FileShares.spec.js.snap     | 12 ++++++------
 .../Shares/__snapshots__/SpaceMembers.spec.js.snap   | 10 +++++-----
 .../views/spaces/__snapshots__/Project.spec.js.snap  |  4 ++--
 3 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/packages/web-app-files/tests/unit/components/SideBar/Shares/__snapshots__/FileShares.spec.js.snap b/packages/web-app-files/tests/unit/components/SideBar/Shares/__snapshots__/FileShares.spec.js.snap
index 35cd40d8c43..98105be73a9 100644
--- a/packages/web-app-files/tests/unit/components/SideBar/Shares/__snapshots__/FileShares.spec.js.snap
+++ b/packages/web-app-files/tests/unit/components/SideBar/Shares/__snapshots__/FileShares.spec.js.snap
@@ -1,7 +1,7 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
 exports[`FileShares if currentUser can not share initially renders no share permission message 1`] = `
-<div id="oc-files-sharing-sidebar" class="oc-position-relative">
+<div id="oc-files-sharing-sidebar" data-custom-key-bindings="true" class="oc-position-relative">
   <div class="oc-flex">
     <h3 class="oc-text-bold oc-text-medium oc-m-rm" data-msgid="Share with people" data-current-language="en_US">Share with people</h3>
     <!---->
@@ -14,7 +14,7 @@ exports[`FileShares if currentUser can not share initially renders no share perm
 `;
 
 exports[`FileShares if currentUser can share initially renders add people dialog 1`] = `
-<div id="oc-files-sharing-sidebar" class="oc-position-relative">
+<div id="oc-files-sharing-sidebar" data-custom-key-bindings="true" class="oc-position-relative">
   <div class="oc-flex">
     <h3 class="oc-text-bold oc-text-medium oc-m-rm" data-msgid="Share with people" data-current-language="en_US">Share with people</h3>
     <!---->
@@ -27,7 +27,7 @@ exports[`FileShares if currentUser can share initially renders add people dialog
 `;
 
 exports[`FileShares if there are collaborators present correctly passes the shared parent route to the collaborator list item 1`] = `
-<div id="oc-files-sharing-sidebar" class="oc-position-relative">
+<div id="oc-files-sharing-sidebar" data-custom-key-bindings="true" class="oc-position-relative">
   <div class="oc-flex">
     <h3 class="oc-text-bold oc-text-medium oc-m-rm" data-msgid="Share with people" data-current-language="en_US">Share with people</h3>
     <!---->
@@ -47,7 +47,7 @@ exports[`FileShares if there are collaborators present correctly passes the shar
 `;
 
 exports[`FileShares if there are collaborators present renders sharedWithLabel and sharee list 1`] = `
-<div id="oc-files-sharing-sidebar" class="oc-position-relative">
+<div id="oc-files-sharing-sidebar" data-custom-key-bindings="true" class="oc-position-relative">
   <div class="oc-flex">
     <h3 class="oc-text-bold oc-text-medium oc-m-rm" data-msgid="Share with people" data-current-language="en_US">Share with people</h3>
     <!---->
@@ -70,7 +70,7 @@ exports[`FileShares if there are collaborators present renders sharedWithLabel a
 `;
 
 exports[`FileShares if there are no collaborators does not render avatar wrapper or collaborator list 1`] = `
-<div id="oc-files-sharing-sidebar" class="oc-position-relative">
+<div id="oc-files-sharing-sidebar" data-custom-key-bindings="true" class="oc-position-relative">
   <div class="oc-flex">
     <h3 class="oc-text-bold oc-text-medium oc-m-rm" data-msgid="Share with people" data-current-language="en_US">Share with people</h3>
     <!---->
@@ -83,7 +83,7 @@ exports[`FileShares if there are no collaborators does not render avatar wrapper
 `;
 
 exports[`FileShares renders loading spinner while loading 1`] = `
-<div id="oc-files-sharing-sidebar" class="oc-position-relative">
+<div id="oc-files-sharing-sidebar" data-custom-key-bindings="true" class="oc-position-relative">
   <div class="oc-flex">
     <h3 class="oc-text-bold oc-text-medium oc-m-rm" data-msgid="Share with people" data-current-language="en_US">Share with people</h3>
     <!---->
diff --git a/packages/web-app-files/tests/unit/components/SideBar/Shares/__snapshots__/SpaceMembers.spec.js.snap b/packages/web-app-files/tests/unit/components/SideBar/Shares/__snapshots__/SpaceMembers.spec.js.snap
index e9be29c76a8..bb04e21e1c3 100644
--- a/packages/web-app-files/tests/unit/components/SideBar/Shares/__snapshots__/SpaceMembers.spec.js.snap
+++ b/packages/web-app-files/tests/unit/components/SideBar/Shares/__snapshots__/SpaceMembers.spec.js.snap
@@ -1,7 +1,7 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
 exports[`SpaceMembers if currentUser can not share other shares are listed, but creating/editing shares is not possible 1`] = `
-<div id="oc-files-sharing-sidebar" class="oc-position-relative">
+<div id="oc-files-sharing-sidebar" data-custom-key-bindings="true" class="oc-position-relative">
   <div class="oc-flex">
     <h3 class="oc-text-bold oc-text-medium oc-m-rm" data-msgid="Members" data-current-language="en_US">Members</h3>
     <!---->
@@ -16,7 +16,7 @@ exports[`SpaceMembers if currentUser can not share other shares are listed, but
 `;
 
 exports[`SpaceMembers if currentUser can share initially renders add people dialog 1`] = `
-<div id="oc-files-sharing-sidebar" class="oc-position-relative">
+<div id="oc-files-sharing-sidebar" data-custom-key-bindings="true" class="oc-position-relative">
   <div class="oc-flex">
     <h3 class="oc-text-bold oc-text-medium oc-m-rm" data-msgid="Members" data-current-language="en_US">Members</h3>
     <!---->
@@ -31,7 +31,7 @@ exports[`SpaceMembers if currentUser can share initially renders add people dial
 `;
 
 exports[`SpaceMembers if currentUser is manager allows role edit of the current user if another user is manager 1`] = `
-<div id="oc-files-sharing-sidebar" class="oc-position-relative">
+<div id="oc-files-sharing-sidebar" data-custom-key-bindings="true" class="oc-position-relative">
   <div class="oc-flex">
     <h3 class="oc-text-bold oc-text-medium oc-m-rm" data-msgid="Members" data-current-language="en_US">Members</h3>
     <!---->
@@ -52,7 +52,7 @@ exports[`SpaceMembers if currentUser is manager allows role edit of the current
 `;
 
 exports[`SpaceMembers if currentUser is manager does not allow role edit of the current user if they are the only manager 1`] = `
-<div id="oc-files-sharing-sidebar" class="oc-position-relative">
+<div id="oc-files-sharing-sidebar" data-custom-key-bindings="true" class="oc-position-relative">
   <div class="oc-flex">
     <h3 class="oc-text-bold oc-text-medium oc-m-rm" data-msgid="Members" data-current-language="en_US">Members</h3>
     <!---->
@@ -70,7 +70,7 @@ exports[`SpaceMembers if currentUser is manager does not allow role edit of the
 `;
 
 exports[`SpaceMembers renders loading spinner while loading 1`] = `
-<div id="oc-files-sharing-sidebar" class="oc-position-relative">
+<div id="oc-files-sharing-sidebar" data-custom-key-bindings="true" class="oc-position-relative">
   <div class="oc-flex">
     <h3 class="oc-text-bold oc-text-medium oc-m-rm" data-msgid="Members" data-current-language="en_US">Members</h3>
     <!---->
diff --git a/packages/web-app-files/tests/unit/views/spaces/__snapshots__/Project.spec.js.snap b/packages/web-app-files/tests/unit/views/spaces/__snapshots__/Project.spec.js.snap
index 7ca05c7efa8..e5af682d58b 100644
--- a/packages/web-app-files/tests/unit/views/spaces/__snapshots__/Project.spec.js.snap
+++ b/packages/web-app-files/tests/unit/views/spaces/__snapshots__/Project.spec.js.snap
@@ -2,7 +2,7 @@
 
 exports[`Spaces project view space image should show if given 1`] = `
 <div class="space-overview oc-flex">
-  <keyboard-actions-stub paginatedresources="" keybindonelementids="files-view,web-nav-sidebar" forbiddenids="context-menu-drop,files-share-invite-input"></keyboard-actions-stub>
+  <keyboard-actions-stub paginatedresources="" keybindonelementids="files-view,web-nav-sidebar"></keyboard-actions-stub>
   <files-view-wrapper-stub>
     <app-bar-stub breadcrumbs="" breadcrumbscontextactionsitems="[object Object]" hasbulkactions="true" hassidebartoggle="true" hasviewoptions="true" showactionsonselection="true"></app-bar-stub>
     <div>
@@ -41,7 +41,7 @@ exports[`Spaces project view space image should show if given 1`] = `
 
 exports[`Spaces project view space readme should show if given 1`] = `
 <div class="space-overview oc-flex">
-  <keyboard-actions-stub paginatedresources="" keybindonelementids="files-view,web-nav-sidebar" forbiddenids="context-menu-drop,files-share-invite-input"></keyboard-actions-stub>
+  <keyboard-actions-stub paginatedresources="" keybindonelementids="files-view,web-nav-sidebar"></keyboard-actions-stub>
   <files-view-wrapper-stub>
     <app-bar-stub breadcrumbs="" breadcrumbscontextactionsitems="[object Object]" hasbulkactions="true" hassidebartoggle="true" hasviewoptions="true" showactionsonselection="true"></app-bar-stub>
     <div>

From f8b1287d9acd27b76b71df5bff121df16c54bb99 Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Fri, 2 Sep 2022 15:39:35 +0200
Subject: [PATCH 10/25] Make all keybinds global

---
 .../components/FilesList/KeyboardActions.vue  | 25 +++----------------
 1 file changed, 3 insertions(+), 22 deletions(-)

diff --git a/packages/web-app-files/src/components/FilesList/KeyboardActions.vue b/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
index 97fd6752e2f..49f0243b40c 100644
--- a/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
+++ b/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
@@ -40,12 +40,6 @@ export default defineComponent({
   },
 
   mounted() {
-    for (const elementId of this.keybindOnElementIds) {
-      const element = document.getElementById(elementId)
-      if (element) {
-        element.addEventListener('keydown', this.handleSelectionShortcuts, false)
-      }
-    }
     document.addEventListener('keydown', this.handleClipboardShortcuts)
 
     const fileListClickedEvent = bus.subscribe('app.files.list.clicked', this.resetSelectionCursor)
@@ -88,14 +82,6 @@ export default defineComponent({
       addFileSelection: 'ADD_FILE_SELECTION'
     }),
 
-    handleSelectionShortcuts(event) {
-      const key = event.keyCode || event.which
-      const ctrl = window.navigator.platform.match('Mac') ? event.metaKey : event.ctrlKey
-      const shift = event.shiftKey
-
-      this.handleFileSelectionShortcuts(key, shift, ctrl, event)
-    },
-
     handleClipboardShortcuts(event) {
       const key = event.keyCode || event.which
       const shift = event.shiftKey
@@ -105,6 +91,9 @@ export default defineComponent({
       const isCutAction = key === 88
       const isUpPressed = key === 38
       const isDownPressed = key === 40
+      const isEscapePressed = key === 27
+      const isSpacePressed = key === 32
+      const isAPressed = key === 65
       const isTextSelected = window.getSelection().type === 'Range'
  
       const customKeyBindings = (window.getSelection().focusNode as HTMLElement)?.closest("[data-custom-key-bindings='true']")
@@ -116,14 +105,6 @@ export default defineComponent({
       if (isCutAction && ctrl) return this.cutSelectedFiles()
       if (isDownPressed && !shift) return this.handleNavigateAction(event)
       if (isUpPressed && !shift) return this.handleNavigateAction(event, true)
-    },
-
-    handleFileSelectionShortcuts(key, shift, ctrl, event) {
-      const isUpPressed = key === 38
-      const isDownPressed = key === 40
-      const isEscapePressed = key === 27
-      const isSpacePressed = key === 32
-      const isAPressed = key === 65
 
       if (isSpacePressed) return this.handleSpaceAction(event)
       if (isEscapePressed) return this.handleEscapeAction()

From c98b7ec8737ec79e5ab9f8acafa2b1a1a28ce5b6 Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Mon, 5 Sep 2022 10:13:51 +0200
Subject: [PATCH 11/25] Update changelog

---
 changelog/unreleased/enhancement-make-keybindings-global | 5 +++++
 changelog/unreleased/enhancement-make-keybinds-global    | 5 -----
 2 files changed, 5 insertions(+), 5 deletions(-)
 create mode 100644 changelog/unreleased/enhancement-make-keybindings-global
 delete mode 100644 changelog/unreleased/enhancement-make-keybinds-global

diff --git a/changelog/unreleased/enhancement-make-keybindings-global b/changelog/unreleased/enhancement-make-keybindings-global
new file mode 100644
index 00000000000..3c1db22935c
--- /dev/null
+++ b/changelog/unreleased/enhancement-make-keybindings-global
@@ -0,0 +1,5 @@
+Enhancement: Make keybindings global
+
+We've made keybindings global and introduced a data-attribute to mark elements that need custom keybindings
+
+https://github.com/owncloud/web/pull/7569
diff --git a/changelog/unreleased/enhancement-make-keybinds-global b/changelog/unreleased/enhancement-make-keybinds-global
deleted file mode 100644
index 39b16ad3da0..00000000000
--- a/changelog/unreleased/enhancement-make-keybinds-global
+++ /dev/null
@@ -1,5 +0,0 @@
-Enhancement: Make keybinds global
-
-We've set keybinds globally and introduced a data-attribute to mark elements that need custom keybinds
-
-https://github.com/owncloud/web/pull/7569

From ef63a0c2683ea62fbaa7fc330a43d5e78058db9b Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Mon, 5 Sep 2022 10:34:59 +0200
Subject: [PATCH 12/25] Linting, Cleanup KeyboardActions

---
 .../components/FilesList/KeyboardActions.vue  | 20 ++++++++-----------
 .../InviteCollaboratorForm.vue                |  8 ++++++--
 .../components/SideBar/Shares/FileLinks.vue   |  2 +-
 .../components/SideBar/Shares/FileShares.vue  |  2 +-
 .../SideBar/Shares/SpaceMembers.vue           |  2 +-
 .../web-app-search/src/portals/SearchBar.vue  |  2 +-
 6 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/packages/web-app-files/src/components/FilesList/KeyboardActions.vue b/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
index 49f0243b40c..0e32df123a8 100644
--- a/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
+++ b/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
@@ -40,7 +40,7 @@ export default defineComponent({
   },
 
   mounted() {
-    document.addEventListener('keydown', this.handleClipboardShortcuts)
+    document.addEventListener('keydown', this.handleShortcuts)
 
     const fileListClickedEvent = bus.subscribe('app.files.list.clicked', this.resetSelectionCursor)
     const fileListClickedMetaEvent = bus.subscribe(
@@ -56,13 +56,7 @@ export default defineComponent({
       bus.unsubscribe('app.files.list.clicked', fileListClickedEvent)
       bus.unsubscribe('app.files.list.clicked.meta', fileListClickedMetaEvent)
       bus.unsubscribe('app.files.list.clicked.shift', fileListClickedShiftEvent)
-      for (const elementId of this.keybindOnElementIds) {
-        const element = document.getElementById(elementId)
-        if (element) {
-          element.removeEventListener('keydown', this.handleSelectionShortcuts)
-        }
-      }
-      document.removeEventListener('keydown', this.handleClipboardShortcuts)
+      document.removeEventListener('keydown', this.handleShortcuts)
     })
   },
 
@@ -82,7 +76,7 @@ export default defineComponent({
       addFileSelection: 'ADD_FILE_SELECTION'
     }),
 
-    handleClipboardShortcuts(event) {
+    handleShortcuts(event) {
       const key = event.keyCode || event.which
       const shift = event.shiftKey
       const ctrl = window.navigator.platform.match('Mac') ? event.metaKey : event.ctrlKey
@@ -95,9 +89,11 @@ export default defineComponent({
       const isSpacePressed = key === 32
       const isAPressed = key === 65
       const isTextSelected = window.getSelection().type === 'Range'
- 
-      const customKeyBindings = (window.getSelection().focusNode as HTMLElement)?.closest("[data-custom-key-bindings='true']")
-      if(customKeyBindings) return
+
+      const customKeyBindings = (window.getSelection().focusNode as HTMLElement)?.closest(
+        "[data-custom-key-bindings='true']"
+      )
+      if (customKeyBindings) return
 
       if (isTextSelected) return
       if (isCopyAction && ctrl) return this.copySelectedFiles()
diff --git a/packages/web-app-files/src/components/SideBar/Shares/Collaborators/InviteCollaborator/InviteCollaboratorForm.vue b/packages/web-app-files/src/components/SideBar/Shares/Collaborators/InviteCollaborator/InviteCollaboratorForm.vue
index 2b8991a9cd7..24953a39f0d 100644
--- a/packages/web-app-files/src/components/SideBar/Shares/Collaborators/InviteCollaborator/InviteCollaboratorForm.vue
+++ b/packages/web-app-files/src/components/SideBar/Shares/Collaborators/InviteCollaborator/InviteCollaboratorForm.vue
@@ -1,5 +1,9 @@
 <template>
-  <div id="new-collaborators-form" data-testid="new-collaborators-form" data-custom-key-bindings=true>
+  <div
+    id="new-collaborators-form"
+    data-testid="new-collaborators-form"
+    data-custom-key-bindings="true"
+  >
     <oc-select
       id="files-share-invite-input"
       ref="ocSharingAutocomplete"
@@ -17,7 +21,7 @@
       @input="resetFocusOnInvite"
     >
       <template #option="option">
-        <autocomplete-item :item="option"/>
+        <autocomplete-item :item="option" />
       </template>
       <template #no-options>
         <translate v-if="resourceIsSpace"> No users found. </translate>
diff --git a/packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue b/packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue
index f38c07c3e7e..1459394d17e 100644
--- a/packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue
+++ b/packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue
@@ -1,5 +1,5 @@
 <template>
-  <div id="oc-files-file-link" class="oc-position-relative" data-custom-key-bindings=true>
+  <div id="oc-files-file-link" class="oc-position-relative" data-custom-key-bindings="true">
     <div class="oc-flex">
       <h3 class="oc-text-bold oc-text-medium oc-m-rm" v-text="linksHeading" />
       <oc-contextual-helper v-if="helpersEnabled" class="oc-pl-xs" v-bind="viaLinkHelp" />
diff --git a/packages/web-app-files/src/components/SideBar/Shares/FileShares.vue b/packages/web-app-files/src/components/SideBar/Shares/FileShares.vue
index c893188465e..3e4c63470be 100644
--- a/packages/web-app-files/src/components/SideBar/Shares/FileShares.vue
+++ b/packages/web-app-files/src/components/SideBar/Shares/FileShares.vue
@@ -1,5 +1,5 @@
 <template>
-  <div id="oc-files-sharing-sidebar" class="oc-position-relative" data-custom-key-bindings=true>
+  <div id="oc-files-sharing-sidebar" class="oc-position-relative" data-custom-key-bindings="true">
     <div class="oc-flex">
       <h3 v-translate class="oc-text-bold oc-text-medium oc-m-rm">Share with people</h3>
       <oc-contextual-helper
diff --git a/packages/web-app-files/src/components/SideBar/Shares/SpaceMembers.vue b/packages/web-app-files/src/components/SideBar/Shares/SpaceMembers.vue
index e5aad773075..f42f6f705e1 100644
--- a/packages/web-app-files/src/components/SideBar/Shares/SpaceMembers.vue
+++ b/packages/web-app-files/src/components/SideBar/Shares/SpaceMembers.vue
@@ -1,5 +1,5 @@
 <template>
-  <div id="oc-files-sharing-sidebar" class="oc-position-relative" data-custom-key-bindings=true>
+  <div id="oc-files-sharing-sidebar" class="oc-position-relative" data-custom-key-bindings="true">
     <div class="oc-flex">
       <h3 v-translate class="oc-text-bold oc-text-medium oc-m-rm">Members</h3>
       <oc-contextual-helper v-if="helpersEnabled" class="oc-pl-xs" v-bind="spaceAddMemberHelp" />
diff --git a/packages/web-app-search/src/portals/SearchBar.vue b/packages/web-app-search/src/portals/SearchBar.vue
index 7dd81fe9789..d972cd47735 100644
--- a/packages/web-app-search/src/portals/SearchBar.vue
+++ b/packages/web-app-search/src/portals/SearchBar.vue
@@ -3,7 +3,7 @@
     v-if="availableProviders.length"
     id="files-global-search"
     :class="{ 'options-visible': optionsVisible && term }"
-    data-custom-key-bindings=true
+    data-custom-key-bindings="true"
   >
     <oc-search-bar
       id="files-global-search-bar"

From fc0e284187d05c7097b5262580d9d1e8fc19e7a0 Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Mon, 5 Sep 2022 15:14:49 +0200
Subject: [PATCH 13/25] Add keycode lib

---
 package.json                                  |  1 +
 .../components/FilesList/KeyboardActions.vue  | 34 +++++++------------
 yarn.lock                                     |  8 +++++
 3 files changed, 22 insertions(+), 21 deletions(-)

diff --git a/package.json b/package.json
index 00e55e3d4ae..25506095bc2 100644
--- a/package.json
+++ b/package.json
@@ -40,6 +40,7 @@
     "not OperaMobile > 0"
   ],
   "dependencies": {
+    "keycode": "^2.2.1",
     "vue": "^2.6.10"
   },
   "devDependencies": {
diff --git a/packages/web-app-files/src/components/FilesList/KeyboardActions.vue b/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
index 0e32df123a8..247ba1e99c1 100644
--- a/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
+++ b/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
@@ -3,6 +3,7 @@
 </template>
 
 <script lang="ts">
+import keycode from "keycode"
 import { bus } from 'web-pkg/src/instance'
 import { mapActions, mapState, mapMutations } from 'vuex'
 import { defineComponent } from '@vue/composition-api'
@@ -80,33 +81,24 @@ export default defineComponent({
       const key = event.keyCode || event.which
       const shift = event.shiftKey
       const ctrl = window.navigator.platform.match('Mac') ? event.metaKey : event.ctrlKey
-      const isCopyAction = key === 67
-      const isPasteAction = key === 86
-      const isCutAction = key === 88
-      const isUpPressed = key === 38
-      const isDownPressed = key === 40
-      const isEscapePressed = key === 27
-      const isSpacePressed = key === 32
-      const isAPressed = key === 65
       const isTextSelected = window.getSelection().type === 'Range'
-
       const customKeyBindings = (window.getSelection().focusNode as HTMLElement)?.closest(
         "[data-custom-key-bindings='true']"
       )
       if (customKeyBindings) return
-
       if (isTextSelected) return
-      if (isCopyAction && ctrl) return this.copySelectedFiles()
-      if (isPasteAction && ctrl) return this.handlePasteAction()
-      if (isCutAction && ctrl) return this.cutSelectedFiles()
-      if (isDownPressed && !shift) return this.handleNavigateAction(event)
-      if (isUpPressed && !shift) return this.handleNavigateAction(event, true)
-
-      if (isSpacePressed) return this.handleSpaceAction(event)
-      if (isEscapePressed) return this.handleEscapeAction()
-      if (isDownPressed && shift) return this.handleShiftDownAction(event)
-      if (isUpPressed && shift) return this.handleShiftUpAction(event)
-      if (isAPressed && ctrl) return this.handleSelectAllAction(event)
+
+      if (key === keycode('c') && ctrl) return this.copySelectedFiles()
+      if (key === keycode('v') && ctrl) return this.handlePasteAction()
+      if (key === keycode('x') && ctrl) return this.cutSelectedFiles()
+      if (key === keycode('down') && !shift) return this.handleNavigateAction(event)
+      if (key === keycode('up') && !shift) return this.handleNavigateAction(event, true)
+
+      if (key === keycode('space')) return this.handleSpaceAction(event)
+      if (key === keycode('esc')) return this.handleEscapeAction()
+      if (key === keycode('down') && shift) return this.handleShiftDownAction(event)
+      if (key === keycode('up') && shift) return this.handleShiftUpAction(event)
+      if (key === keycode('a') && ctrl) return this.handleSelectAllAction(event)
     },
 
     handleNavigateAction(event, up = false) {
diff --git a/yarn.lock b/yarn.lock
index 64dde876398..1abc57d5f83 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -8482,6 +8482,13 @@ __metadata:
   languageName: node
   linkType: hard
 
+"keycode@npm:^2.2.1":
+  version: 2.2.1
+  resolution: "keycode@npm:2.2.1"
+  checksum: 7a5c775b2410a3b6d9c07a415ecb70639187a965be239d2c11c71079cb1ca2f9dede94b86426f3ece475dc8ae3debf2367531bbcafc0af8c82f157d9a4f7e6cb
+  languageName: node
+  linkType: hard
+
 "kind-of@npm:^3.0.2":
   version: 3.2.2
   resolution: "kind-of@npm:3.2.2"
@@ -11844,6 +11851,7 @@ __metadata:
     jest-mock-axios: ^4.5.0
     jest-serializer-vue: ^2.0.2
     join-path: ^1.1.1
+    keycode: ^2.2.1
     license-checker-rseidelsohn: ^3.1.0
     lodash: ^4.17.21
     node-fetch: ^2.6.7

From 3fc288a5ce7266717fe5fb7204a414de064a4353 Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Mon, 5 Sep 2022 16:30:46 +0200
Subject: [PATCH 14/25] Fix custom key bindings errors

---
 .../components/FilesList/KeyboardActions.vue  | 41 +++++++++++++------
 1 file changed, 28 insertions(+), 13 deletions(-)

diff --git a/packages/web-app-files/src/components/FilesList/KeyboardActions.vue b/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
index 247ba1e99c1..cc34b1ecd24 100644
--- a/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
+++ b/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
@@ -17,11 +17,6 @@ export default defineComponent({
       type: Array,
       required: true
     },
-    keybindOnElementIds: {
-      type: Array,
-      required: false,
-      default: () => ['files-view', 'web-nav-sidebar']
-    }
   },
   setup() {
     const store = useStore()
@@ -77,15 +72,30 @@ export default defineComponent({
       addFileSelection: 'ADD_FILE_SELECTION'
     }),
 
+    areCustomKeyBindingsEnabled() {
+      const closestSelectionEl = (window.getSelection().focusNode as HTMLElement)
+      if(!closestSelectionEl) return true
+      let customKeyBindings
+      try {
+        customKeyBindings = closestSelectionEl?.closest(
+          "[data-custom-key-bindings='true']"
+        )
+      }catch {
+        customKeyBindings = closestSelectionEl?.parentElement.closest(
+          "[data-custom-key-bindings='true']"
+        )
+      }
+      if (customKeyBindings) return true
+      return false
+    },
+
     handleShortcuts(event) {
       const key = event.keyCode || event.which
       const shift = event.shiftKey
       const ctrl = window.navigator.platform.match('Mac') ? event.metaKey : event.ctrlKey
       const isTextSelected = window.getSelection().type === 'Range'
-      const customKeyBindings = (window.getSelection().focusNode as HTMLElement)?.closest(
-        "[data-custom-key-bindings='true']"
-      )
-      if (customKeyBindings) return
+      
+      if (this.areCustomKeyBindingsEnabled()) return
       if (isTextSelected) return
 
       if (key === keycode('c') && ctrl) return this.copySelectedFiles()
@@ -114,7 +124,6 @@ export default defineComponent({
       this.resetFileSelection()
       this.addFileSelection({ id: nextId })
       this.scrollToResource({ id: nextId })
-      document.getElementById(this.keybindOnElementIds[0]).focus()
     },
 
     handleShiftClickAction(resource) {
@@ -212,15 +221,21 @@ export default defineComponent({
       const latestSelectedRow = document.querySelectorAll(
         `[data-item-id='${this.latestSelectedId}']`
       )[0]
-      const nextRow = (
-        previous ? latestSelectedRow.previousSibling : latestSelectedRow.nextSibling
-      ) as HTMLElement
+      let nextRow
+      try {
+        nextRow = (
+          previous ? latestSelectedRow.previousSibling : latestSelectedRow.nextSibling
+        ) as HTMLElement
+      }catch {
+        return -1
+      }
       if (nextRow === null) return -1
       return nextRow.getAttribute('data-item-id')
     },
 
     getFirstResourceId() {
       const firstRow = document.getElementsByClassName('oc-tbody-tr')[0]
+      if(!firstRow) return -1
       return firstRow.getAttribute('data-item-id')
     }
   }

From fc144e829430b7ce5c14e4bb78bf928513b376bc Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Mon, 5 Sep 2022 17:36:24 +0200
Subject: [PATCH 15/25] Linting, Snapshots

---
 .../components/FilesList/KeyboardActions.vue  | 20 +++++++++----------
 .../spaces/__snapshots__/Project.spec.js.snap |  4 ++--
 2 files changed, 11 insertions(+), 13 deletions(-)

diff --git a/packages/web-app-files/src/components/FilesList/KeyboardActions.vue b/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
index cc34b1ecd24..804932591e1 100644
--- a/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
+++ b/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
@@ -3,7 +3,7 @@
 </template>
 
 <script lang="ts">
-import keycode from "keycode"
+import keycode from 'keycode'
 import { bus } from 'web-pkg/src/instance'
 import { mapActions, mapState, mapMutations } from 'vuex'
 import { defineComponent } from '@vue/composition-api'
@@ -16,7 +16,7 @@ export default defineComponent({
     paginatedResources: {
       type: Array,
       required: true
-    },
+    }
   },
   setup() {
     const store = useStore()
@@ -73,14 +73,12 @@ export default defineComponent({
     }),
 
     areCustomKeyBindingsEnabled() {
-      const closestSelectionEl = (window.getSelection().focusNode as HTMLElement)
-      if(!closestSelectionEl) return true
+      const closestSelectionEl = window.getSelection().focusNode as HTMLElement
+      if (!closestSelectionEl) return true
       let customKeyBindings
       try {
-        customKeyBindings = closestSelectionEl?.closest(
-          "[data-custom-key-bindings='true']"
-        )
-      }catch {
+        customKeyBindings = closestSelectionEl?.closest("[data-custom-key-bindings='true']")
+      } catch {
         customKeyBindings = closestSelectionEl?.parentElement.closest(
           "[data-custom-key-bindings='true']"
         )
@@ -94,7 +92,7 @@ export default defineComponent({
       const shift = event.shiftKey
       const ctrl = window.navigator.platform.match('Mac') ? event.metaKey : event.ctrlKey
       const isTextSelected = window.getSelection().type === 'Range'
-      
+
       if (this.areCustomKeyBindingsEnabled()) return
       if (isTextSelected) return
 
@@ -226,7 +224,7 @@ export default defineComponent({
         nextRow = (
           previous ? latestSelectedRow.previousSibling : latestSelectedRow.nextSibling
         ) as HTMLElement
-      }catch {
+      } catch {
         return -1
       }
       if (nextRow === null) return -1
@@ -235,7 +233,7 @@ export default defineComponent({
 
     getFirstResourceId() {
       const firstRow = document.getElementsByClassName('oc-tbody-tr')[0]
-      if(!firstRow) return -1
+      if (!firstRow) return -1
       return firstRow.getAttribute('data-item-id')
     }
   }
diff --git a/packages/web-app-files/tests/unit/views/spaces/__snapshots__/Project.spec.js.snap b/packages/web-app-files/tests/unit/views/spaces/__snapshots__/Project.spec.js.snap
index e5af682d58b..458e97da183 100644
--- a/packages/web-app-files/tests/unit/views/spaces/__snapshots__/Project.spec.js.snap
+++ b/packages/web-app-files/tests/unit/views/spaces/__snapshots__/Project.spec.js.snap
@@ -2,7 +2,7 @@
 
 exports[`Spaces project view space image should show if given 1`] = `
 <div class="space-overview oc-flex">
-  <keyboard-actions-stub paginatedresources="" keybindonelementids="files-view,web-nav-sidebar"></keyboard-actions-stub>
+  <keyboard-actions-stub paginatedresources=""></keyboard-actions-stub>
   <files-view-wrapper-stub>
     <app-bar-stub breadcrumbs="" breadcrumbscontextactionsitems="[object Object]" hasbulkactions="true" hassidebartoggle="true" hasviewoptions="true" showactionsonselection="true"></app-bar-stub>
     <div>
@@ -41,7 +41,7 @@ exports[`Spaces project view space image should show if given 1`] = `
 
 exports[`Spaces project view space readme should show if given 1`] = `
 <div class="space-overview oc-flex">
-  <keyboard-actions-stub paginatedresources="" keybindonelementids="files-view,web-nav-sidebar"></keyboard-actions-stub>
+  <keyboard-actions-stub paginatedresources=""></keyboard-actions-stub>
   <files-view-wrapper-stub>
     <app-bar-stub breadcrumbs="" breadcrumbscontextactionsitems="[object Object]" hasbulkactions="true" hassidebartoggle="true" hasviewoptions="true" showactionsonselection="true"></app-bar-stub>
     <div>

From 47b3dcdad47ec6ed33b6d94934959e6f98ec6d3c Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Tue, 6 Sep 2022 13:04:22 +0200
Subject: [PATCH 16/25] DEV

---
 .../pageObjects/FilesPageElement/filesList.js    | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/tests/acceptance/pageObjects/FilesPageElement/filesList.js b/tests/acceptance/pageObjects/FilesPageElement/filesList.js
index 1084e9382da..6f7890c8fd8 100644
--- a/tests/acceptance/pageObjects/FilesPageElement/filesList.js
+++ b/tests/acceptance/pageObjects/FilesPageElement/filesList.js
@@ -245,7 +245,7 @@ module.exports = {
      *
      * @returns {*}
      */
-    openFileActionsMenu: async function (resource, elementType = 'any') {
+    openFileActionsMenu: async function (resource, elementType = 'any') { //here2
       await this.openSideBar(resource, elementType)
       await appSideBar.activatePanel('actions')
       return fileActionsMenu
@@ -258,7 +258,7 @@ module.exports = {
      * @param {string} elementType The resource type (file|folder|any)
      * @returns {*}
      */
-    openSideBar: async function (resource, elementType = 'any') {
+    openSideBar: async function (resource, elementType = 'any') { //here3
       // nothing to do if already open for correct resource
       if (await appSideBar.isSideBarOpenForResource(resource, elementType, false)) {
         return appSideBar
@@ -269,7 +269,9 @@ module.exports = {
       await appSideBar.closeSidebarIfOpen()
 
       // open the sidebar for the resource
+      await new Promise(r => setTimeout(r, 2000));
       await this.clickRow(resource, elementType)
+      await new Promise(r => setTimeout(r, 2000));
       await this.click('@btnToggleSideBar')
       await this.waitForAnimationToFinish() // wait for the sidebar animation to finish
       return appSideBar
@@ -278,7 +280,7 @@ module.exports = {
      * @param {string} resource the file/folder to click
      * @param {string} elementType The resource type (file|folder|any)
      */
-    clickRow: async function (resource, elementType = 'any') {
+    clickRow: async function (resource, elementType = 'any') { //here4
       await this.waitForFileVisible(resource, elementType)
       await this.initAjaxCounters()
         .useXpath()
@@ -305,7 +307,7 @@ module.exports = {
      * @param {string} enableOrDisable
      * @param {string} path
      */
-    toggleFileOrFolderCheckbox: async function (enableOrDisable, path) {
+    toggleFileOrFolderCheckbox: async function (enableOrDisable, path) { 
       await this.waitForFileVisible(path)
 
       const fileCheckbox =
@@ -362,6 +364,8 @@ module.exports = {
       let resourceName = null
       let status = null
       let error = null
+      console.log("!!!!!")
+      console.log(fileSelector)
       await this.getText('xpath', fileSelector, (res) => {
         status = res.status
         const result = res.value
@@ -386,7 +390,7 @@ module.exports = {
      *
      * @returns {string}
      */
-    getFileRowSelectorByFileName: function (fileName, elementType = 'any') {
+    getFileRowSelectorByFileName: function (fileName, elementType = 'any') { //here5
       const name = xpathHelper.buildXpathLiteral(fileName)
       const path = xpathHelper.buildXpathLiteral('/' + fileName)
       if (elementType === 'any') {
@@ -623,7 +627,7 @@ module.exports = {
       return await this.selectFolderAndPasteFiles(target)
     },
 
-    copyResource: async function (resource, target) {
+    copyResource: async function (resource, target) { // here1
       // Trigger copy
       await this.openFileActionsMenu(resource)
       await fileActionsMenu.copy()

From 25d70f189191ca94c69ce8bd0645dbee4c5c946b Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Thu, 8 Sep 2022 13:39:29 +0200
Subject: [PATCH 17/25] Linting

---
 .../pageObjects/FilesPageElement/filesList.js | 23 +++++++++++--------
 1 file changed, 14 insertions(+), 9 deletions(-)

diff --git a/tests/acceptance/pageObjects/FilesPageElement/filesList.js b/tests/acceptance/pageObjects/FilesPageElement/filesList.js
index 6f7890c8fd8..49cf24de7f0 100644
--- a/tests/acceptance/pageObjects/FilesPageElement/filesList.js
+++ b/tests/acceptance/pageObjects/FilesPageElement/filesList.js
@@ -245,7 +245,8 @@ module.exports = {
      *
      * @returns {*}
      */
-    openFileActionsMenu: async function (resource, elementType = 'any') { //here2
+    openFileActionsMenu: async function (resource, elementType = 'any') {
+      // here2
       await this.openSideBar(resource, elementType)
       await appSideBar.activatePanel('actions')
       return fileActionsMenu
@@ -258,7 +259,8 @@ module.exports = {
      * @param {string} elementType The resource type (file|folder|any)
      * @returns {*}
      */
-    openSideBar: async function (resource, elementType = 'any') { //here3
+    openSideBar: async function (resource, elementType = 'any') {
+      // here3
       // nothing to do if already open for correct resource
       if (await appSideBar.isSideBarOpenForResource(resource, elementType, false)) {
         return appSideBar
@@ -269,9 +271,9 @@ module.exports = {
       await appSideBar.closeSidebarIfOpen()
 
       // open the sidebar for the resource
-      await new Promise(r => setTimeout(r, 2000));
+      await new Promise((resolve) => setTimeout(resolve, 2000))
       await this.clickRow(resource, elementType)
-      await new Promise(r => setTimeout(r, 2000));
+      await new Promise((resolve) => setTimeout(resolve, 2000))
       await this.click('@btnToggleSideBar')
       await this.waitForAnimationToFinish() // wait for the sidebar animation to finish
       return appSideBar
@@ -280,7 +282,8 @@ module.exports = {
      * @param {string} resource the file/folder to click
      * @param {string} elementType The resource type (file|folder|any)
      */
-    clickRow: async function (resource, elementType = 'any') { //here4
+    clickRow: async function (resource, elementType = 'any') {
+      // here4
       await this.waitForFileVisible(resource, elementType)
       await this.initAjaxCounters()
         .useXpath()
@@ -307,7 +310,7 @@ module.exports = {
      * @param {string} enableOrDisable
      * @param {string} path
      */
-    toggleFileOrFolderCheckbox: async function (enableOrDisable, path) { 
+    toggleFileOrFolderCheckbox: async function (enableOrDisable, path) {
       await this.waitForFileVisible(path)
 
       const fileCheckbox =
@@ -364,7 +367,7 @@ module.exports = {
       let resourceName = null
       let status = null
       let error = null
-      console.log("!!!!!")
+      console.log('!!!!!')
       console.log(fileSelector)
       await this.getText('xpath', fileSelector, (res) => {
         status = res.status
@@ -390,7 +393,8 @@ module.exports = {
      *
      * @returns {string}
      */
-    getFileRowSelectorByFileName: function (fileName, elementType = 'any') { //here5
+    getFileRowSelectorByFileName: function (fileName, elementType = 'any') {
+      // here5
       const name = xpathHelper.buildXpathLiteral(fileName)
       const path = xpathHelper.buildXpathLiteral('/' + fileName)
       if (elementType === 'any') {
@@ -627,7 +631,8 @@ module.exports = {
       return await this.selectFolderAndPasteFiles(target)
     },
 
-    copyResource: async function (resource, target) { // here1
+    copyResource: async function (resource, target) {
+      // here1
       // Trigger copy
       await this.openFileActionsMenu(resource)
       await fileActionsMenu.copy()

From 914dbe2fec252030116324658e9a9623450a466e Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Thu, 8 Sep 2022 16:17:48 +0200
Subject: [PATCH 18/25] Sanity test

---
 .../src/components/FilesList/KeyboardActions.vue             | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/packages/web-app-files/src/components/FilesList/KeyboardActions.vue b/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
index 804932591e1..257052664fa 100644
--- a/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
+++ b/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
@@ -3,7 +3,6 @@
 </template>
 
 <script lang="ts">
-import keycode from 'keycode'
 import { bus } from 'web-pkg/src/instance'
 import { mapActions, mapState, mapMutations } from 'vuex'
 import { defineComponent } from '@vue/composition-api'
@@ -88,7 +87,7 @@ export default defineComponent({
     },
 
     handleShortcuts(event) {
-      const key = event.keyCode || event.which
+      /* const key = event.keyCode || event.which
       const shift = event.shiftKey
       const ctrl = window.navigator.platform.match('Mac') ? event.metaKey : event.ctrlKey
       const isTextSelected = window.getSelection().type === 'Range'
@@ -106,7 +105,7 @@ export default defineComponent({
       if (key === keycode('esc')) return this.handleEscapeAction()
       if (key === keycode('down') && shift) return this.handleShiftDownAction(event)
       if (key === keycode('up') && shift) return this.handleShiftUpAction(event)
-      if (key === keycode('a') && ctrl) return this.handleSelectAllAction(event)
+      if (key === keycode('a') && ctrl) return this.handleSelectAllAction(event) */
     },
 
     handleNavigateAction(event, up = false) {

From b5395cef639cbf5d01f2d38498c8d7c9110d9be9 Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Thu, 8 Sep 2022 17:48:56 +0200
Subject: [PATCH 19/25] Sanity test 2

---
 .../src/components/FilesList/KeyboardActions.vue      | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/packages/web-app-files/src/components/FilesList/KeyboardActions.vue b/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
index 257052664fa..88ee6f47fc8 100644
--- a/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
+++ b/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
@@ -3,6 +3,7 @@
 </template>
 
 <script lang="ts">
+import keycode from 'keycode'
 import { bus } from 'web-pkg/src/instance'
 import { mapActions, mapState, mapMutations } from 'vuex'
 import { defineComponent } from '@vue/composition-api'
@@ -87,7 +88,7 @@ export default defineComponent({
     },
 
     handleShortcuts(event) {
-      /* const key = event.keyCode || event.which
+      const key = event.keyCode || event.which
       const shift = event.shiftKey
       const ctrl = window.navigator.platform.match('Mac') ? event.metaKey : event.ctrlKey
       const isTextSelected = window.getSelection().type === 'Range'
@@ -105,11 +106,11 @@ export default defineComponent({
       if (key === keycode('esc')) return this.handleEscapeAction()
       if (key === keycode('down') && shift) return this.handleShiftDownAction(event)
       if (key === keycode('up') && shift) return this.handleShiftUpAction(event)
-      if (key === keycode('a') && ctrl) return this.handleSelectAllAction(event) */
+      if (key === keycode('a') && ctrl) return this.handleSelectAllAction(event)
     },
 
     handleNavigateAction(event, up = false) {
-      event.preventDefault()
+      // event.preventDefault()
       let nextId
       if (!this.latestSelectedId) {
         nextId = this.getFirstResourceId()
@@ -155,13 +156,13 @@ export default defineComponent({
     },
 
     handleSelectAllAction(event) {
-      event.preventDefault()
+      // event.preventDefault()
       this.resetSelectionCursor()
       this.setFileSelection(this.paginatedResources)
     },
 
     handleSpaceAction(event) {
-      event.preventDefault()
+      // event.preventDefault()
       this.toggleFileSelection({ id: this.latestSelectedId })
     },
 

From 3e1d333a1d72f2eff1f28845c5d672baccabf1c3 Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Thu, 8 Sep 2022 18:52:49 +0200
Subject: [PATCH 20/25] Sanity test 3

---
 .../src/components/FilesList/KeyboardActions.vue              | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/web-app-files/src/components/FilesList/KeyboardActions.vue b/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
index 88ee6f47fc8..68593e1c7a1 100644
--- a/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
+++ b/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
@@ -110,7 +110,7 @@ export default defineComponent({
     },
 
     handleNavigateAction(event, up = false) {
-      // event.preventDefault()
+      event.preventDefault()
       let nextId
       if (!this.latestSelectedId) {
         nextId = this.getFirstResourceId()
@@ -156,7 +156,7 @@ export default defineComponent({
     },
 
     handleSelectAllAction(event) {
-      // event.preventDefault()
+      event.preventDefault()
       this.resetSelectionCursor()
       this.setFileSelection(this.paginatedResources)
     },

From 0690064822864e737e35c963fb73d025884f90a9 Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Fri, 9 Sep 2022 10:09:16 +0200
Subject: [PATCH 21/25] Make spacebar shortcut local

---
 .../components/FilesList/KeyboardActions.vue  | 27 +++++++++++++++----
 1 file changed, 22 insertions(+), 5 deletions(-)

diff --git a/packages/web-app-files/src/components/FilesList/KeyboardActions.vue b/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
index 68593e1c7a1..cc5b63d918d 100644
--- a/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
+++ b/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
@@ -16,6 +16,11 @@ export default defineComponent({
     paginatedResources: {
       type: Array,
       required: true
+    },
+    keybindOnElementId: {
+      type: String,
+      required: false,
+      default: 'files-view'
     }
   },
   setup() {
@@ -36,7 +41,11 @@ export default defineComponent({
   },
 
   mounted() {
-    document.addEventListener('keydown', this.handleShortcuts)
+    const element = document.getElementById(this.keybindOnElementId)
+    if (element) {
+      element.addEventListener('keydown', this.handelLocalShortcuts, false)
+    }
+    document.addEventListener('keydown', this.handleGlobalShortcuts)
 
     const fileListClickedEvent = bus.subscribe('app.files.list.clicked', this.resetSelectionCursor)
     const fileListClickedMetaEvent = bus.subscribe(
@@ -52,7 +61,11 @@ export default defineComponent({
       bus.unsubscribe('app.files.list.clicked', fileListClickedEvent)
       bus.unsubscribe('app.files.list.clicked.meta', fileListClickedMetaEvent)
       bus.unsubscribe('app.files.list.clicked.shift', fileListClickedShiftEvent)
-      document.removeEventListener('keydown', this.handleShortcuts)
+      const element = document.getElementById(this.keybindOnElementId)
+      if (element) {
+        element.removeEventListener('keydown', this.handelLocalShortcuts)
+      }
+      document.removeEventListener('keydown', this.handleGlobalShortcuts)
     })
   },
 
@@ -87,7 +100,12 @@ export default defineComponent({
       return false
     },
 
-    handleShortcuts(event) {
+    handelLocalShortcuts(event) {
+      const key = event.keyCode || event.which
+      if (key === keycode('space')) return this.handleSpaceAction(event)
+    },
+
+    handleGlobalShortcuts(event) {
       const key = event.keyCode || event.which
       const shift = event.shiftKey
       const ctrl = window.navigator.platform.match('Mac') ? event.metaKey : event.ctrlKey
@@ -102,7 +120,6 @@ export default defineComponent({
       if (key === keycode('down') && !shift) return this.handleNavigateAction(event)
       if (key === keycode('up') && !shift) return this.handleNavigateAction(event, true)
 
-      if (key === keycode('space')) return this.handleSpaceAction(event)
       if (key === keycode('esc')) return this.handleEscapeAction()
       if (key === keycode('down') && shift) return this.handleShiftDownAction(event)
       if (key === keycode('up') && shift) return this.handleShiftUpAction(event)
@@ -162,7 +179,7 @@ export default defineComponent({
     },
 
     handleSpaceAction(event) {
-      // event.preventDefault()
+      event.preventDefault()
       this.toggleFileSelection({ id: this.latestSelectedId })
     },
 

From c443ef13a7cb32174c1742a2ec091b037215e5f0 Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Fri, 9 Sep 2022 13:46:56 +0200
Subject: [PATCH 22/25] Update snapshots

---
 .../unit/views/spaces/__snapshots__/Project.spec.js.snap      | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/web-app-files/tests/unit/views/spaces/__snapshots__/Project.spec.js.snap b/packages/web-app-files/tests/unit/views/spaces/__snapshots__/Project.spec.js.snap
index 458e97da183..526a1830ef8 100644
--- a/packages/web-app-files/tests/unit/views/spaces/__snapshots__/Project.spec.js.snap
+++ b/packages/web-app-files/tests/unit/views/spaces/__snapshots__/Project.spec.js.snap
@@ -2,7 +2,7 @@
 
 exports[`Spaces project view space image should show if given 1`] = `
 <div class="space-overview oc-flex">
-  <keyboard-actions-stub paginatedresources=""></keyboard-actions-stub>
+  <keyboard-actions-stub paginatedresources="" keybindonelementid="files-view"></keyboard-actions-stub>
   <files-view-wrapper-stub>
     <app-bar-stub breadcrumbs="" breadcrumbscontextactionsitems="[object Object]" hasbulkactions="true" hassidebartoggle="true" hasviewoptions="true" showactionsonselection="true"></app-bar-stub>
     <div>
@@ -41,7 +41,7 @@ exports[`Spaces project view space image should show if given 1`] = `
 
 exports[`Spaces project view space readme should show if given 1`] = `
 <div class="space-overview oc-flex">
-  <keyboard-actions-stub paginatedresources=""></keyboard-actions-stub>
+  <keyboard-actions-stub paginatedresources="" keybindonelementid="files-view"></keyboard-actions-stub>
   <files-view-wrapper-stub>
     <app-bar-stub breadcrumbs="" breadcrumbscontextactionsitems="[object Object]" hasbulkactions="true" hassidebartoggle="true" hasviewoptions="true" showactionsonselection="true"></app-bar-stub>
     <div>

From a59cd5377a253612d06041624ec6ff991da7c10f Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Tue, 13 Sep 2022 17:52:24 +0200
Subject: [PATCH 23/25] Address PR issues, remove dev leftover

---
 .../src/components/FilesList/KeyboardActions.vue         | 2 +-
 .../InviteCollaborator/InviteCollaboratorForm.vue        | 1 -
 .../web-app-files/src/components/SideBar/SideBar.vue     | 1 +
 .../acceptance/pageObjects/FilesPageElement/filesList.js | 9 ---------
 4 files changed, 2 insertions(+), 11 deletions(-)

diff --git a/packages/web-app-files/src/components/FilesList/KeyboardActions.vue b/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
index cc5b63d918d..4dbcba64c16 100644
--- a/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
+++ b/packages/web-app-files/src/components/FilesList/KeyboardActions.vue
@@ -87,7 +87,7 @@ export default defineComponent({
 
     areCustomKeyBindingsEnabled() {
       const closestSelectionEl = window.getSelection().focusNode as HTMLElement
-      if (!closestSelectionEl) return true
+      if (!closestSelectionEl) return false
       let customKeyBindings
       try {
         customKeyBindings = closestSelectionEl?.closest("[data-custom-key-bindings='true']")
diff --git a/packages/web-app-files/src/components/SideBar/Shares/Collaborators/InviteCollaborator/InviteCollaboratorForm.vue b/packages/web-app-files/src/components/SideBar/Shares/Collaborators/InviteCollaborator/InviteCollaboratorForm.vue
index 24953a39f0d..da1a79c9e31 100644
--- a/packages/web-app-files/src/components/SideBar/Shares/Collaborators/InviteCollaborator/InviteCollaboratorForm.vue
+++ b/packages/web-app-files/src/components/SideBar/Shares/Collaborators/InviteCollaborator/InviteCollaboratorForm.vue
@@ -2,7 +2,6 @@
   <div
     id="new-collaborators-form"
     data-testid="new-collaborators-form"
-    data-custom-key-bindings="true"
   >
     <oc-select
       id="files-share-invite-input"
diff --git a/packages/web-app-files/src/components/SideBar/SideBar.vue b/packages/web-app-files/src/components/SideBar/SideBar.vue
index ee907720037..636f7d53ab6 100644
--- a/packages/web-app-files/src/components/SideBar/SideBar.vue
+++ b/packages/web-app-files/src/components/SideBar/SideBar.vue
@@ -18,6 +18,7 @@
     @selectPanel="setActiveSideBarPanel"
     @close="closeSideBar"
     v-on="$listeners"
+    data-custom-key-bindings="true"
   >
     <template #header>
       <file-info
diff --git a/tests/acceptance/pageObjects/FilesPageElement/filesList.js b/tests/acceptance/pageObjects/FilesPageElement/filesList.js
index 49cf24de7f0..1084e9382da 100644
--- a/tests/acceptance/pageObjects/FilesPageElement/filesList.js
+++ b/tests/acceptance/pageObjects/FilesPageElement/filesList.js
@@ -246,7 +246,6 @@ module.exports = {
      * @returns {*}
      */
     openFileActionsMenu: async function (resource, elementType = 'any') {
-      // here2
       await this.openSideBar(resource, elementType)
       await appSideBar.activatePanel('actions')
       return fileActionsMenu
@@ -260,7 +259,6 @@ module.exports = {
      * @returns {*}
      */
     openSideBar: async function (resource, elementType = 'any') {
-      // here3
       // nothing to do if already open for correct resource
       if (await appSideBar.isSideBarOpenForResource(resource, elementType, false)) {
         return appSideBar
@@ -271,9 +269,7 @@ module.exports = {
       await appSideBar.closeSidebarIfOpen()
 
       // open the sidebar for the resource
-      await new Promise((resolve) => setTimeout(resolve, 2000))
       await this.clickRow(resource, elementType)
-      await new Promise((resolve) => setTimeout(resolve, 2000))
       await this.click('@btnToggleSideBar')
       await this.waitForAnimationToFinish() // wait for the sidebar animation to finish
       return appSideBar
@@ -283,7 +279,6 @@ module.exports = {
      * @param {string} elementType The resource type (file|folder|any)
      */
     clickRow: async function (resource, elementType = 'any') {
-      // here4
       await this.waitForFileVisible(resource, elementType)
       await this.initAjaxCounters()
         .useXpath()
@@ -367,8 +362,6 @@ module.exports = {
       let resourceName = null
       let status = null
       let error = null
-      console.log('!!!!!')
-      console.log(fileSelector)
       await this.getText('xpath', fileSelector, (res) => {
         status = res.status
         const result = res.value
@@ -394,7 +387,6 @@ module.exports = {
      * @returns {string}
      */
     getFileRowSelectorByFileName: function (fileName, elementType = 'any') {
-      // here5
       const name = xpathHelper.buildXpathLiteral(fileName)
       const path = xpathHelper.buildXpathLiteral('/' + fileName)
       if (elementType === 'any') {
@@ -632,7 +624,6 @@ module.exports = {
     },
 
     copyResource: async function (resource, target) {
-      // here1
       // Trigger copy
       await this.openFileActionsMenu(resource)
       await fileActionsMenu.copy()

From 0c70d5d74989b9f734e91eaf18cf55f5d5dec90a Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Tue, 13 Sep 2022 19:01:07 +0200
Subject: [PATCH 24/25] Fix Linting

---
 .../InviteCollaborator/InviteCollaboratorForm.vue            | 5 +----
 packages/web-app-files/src/components/SideBar/SideBar.vue    | 2 +-
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/packages/web-app-files/src/components/SideBar/Shares/Collaborators/InviteCollaborator/InviteCollaboratorForm.vue b/packages/web-app-files/src/components/SideBar/Shares/Collaborators/InviteCollaborator/InviteCollaboratorForm.vue
index da1a79c9e31..f749615e1c5 100644
--- a/packages/web-app-files/src/components/SideBar/Shares/Collaborators/InviteCollaborator/InviteCollaboratorForm.vue
+++ b/packages/web-app-files/src/components/SideBar/Shares/Collaborators/InviteCollaborator/InviteCollaboratorForm.vue
@@ -1,8 +1,5 @@
 <template>
-  <div
-    id="new-collaborators-form"
-    data-testid="new-collaborators-form"
-  >
+  <div id="new-collaborators-form" data-testid="new-collaborators-form">
     <oc-select
       id="files-share-invite-input"
       ref="ocSharingAutocomplete"
diff --git a/packages/web-app-files/src/components/SideBar/SideBar.vue b/packages/web-app-files/src/components/SideBar/SideBar.vue
index 636f7d53ab6..6b82d63f253 100644
--- a/packages/web-app-files/src/components/SideBar/SideBar.vue
+++ b/packages/web-app-files/src/components/SideBar/SideBar.vue
@@ -12,13 +12,13 @@
     :loading="loading"
     :is-header-compact="isSingleResource"
     v-bind="$attrs"
+    data-custom-key-bindings="true"
     @beforeDestroy="destroySideBar"
     @mounted="focusSideBar"
     @fileChanged="focusSideBar"
     @selectPanel="setActiveSideBarPanel"
     @close="closeSideBar"
     v-on="$listeners"
-    data-custom-key-bindings="true"
   >
     <template #header>
       <file-info

From 1be74f1be1a5d92f4d0d84bc40f684cb19b43a16 Mon Sep 17 00:00:00 2001
From: Paul Neubauer <paulneubauer@live.de>
Date: Wed, 14 Sep 2022 14:13:54 +0200
Subject: [PATCH 25/25] Address PR issues

---
 .../src/components/SideBar/Shares/FileLinks.vue      |  2 +-
 .../src/components/SideBar/Shares/FileShares.vue     |  2 +-
 .../src/components/SideBar/Shares/SpaceMembers.vue   |  2 +-
 .../Shares/__snapshots__/FileShares.spec.js.snap     | 12 ++++++------
 .../Shares/__snapshots__/SpaceMembers.spec.js.snap   | 10 +++++-----
 5 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue b/packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue
index 1459394d17e..e527a9967c7 100644
--- a/packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue
+++ b/packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue
@@ -1,5 +1,5 @@
 <template>
-  <div id="oc-files-file-link" class="oc-position-relative" data-custom-key-bindings="true">
+  <div id="oc-files-file-link" class="oc-position-relative">
     <div class="oc-flex">
       <h3 class="oc-text-bold oc-text-medium oc-m-rm" v-text="linksHeading" />
       <oc-contextual-helper v-if="helpersEnabled" class="oc-pl-xs" v-bind="viaLinkHelp" />
diff --git a/packages/web-app-files/src/components/SideBar/Shares/FileShares.vue b/packages/web-app-files/src/components/SideBar/Shares/FileShares.vue
index 3e4c63470be..7efa9e41a50 100644
--- a/packages/web-app-files/src/components/SideBar/Shares/FileShares.vue
+++ b/packages/web-app-files/src/components/SideBar/Shares/FileShares.vue
@@ -1,5 +1,5 @@
 <template>
-  <div id="oc-files-sharing-sidebar" class="oc-position-relative" data-custom-key-bindings="true">
+  <div id="oc-files-sharing-sidebar" class="oc-position-relative">
     <div class="oc-flex">
       <h3 v-translate class="oc-text-bold oc-text-medium oc-m-rm">Share with people</h3>
       <oc-contextual-helper
diff --git a/packages/web-app-files/src/components/SideBar/Shares/SpaceMembers.vue b/packages/web-app-files/src/components/SideBar/Shares/SpaceMembers.vue
index f42f6f705e1..18283e20db8 100644
--- a/packages/web-app-files/src/components/SideBar/Shares/SpaceMembers.vue
+++ b/packages/web-app-files/src/components/SideBar/Shares/SpaceMembers.vue
@@ -1,5 +1,5 @@
 <template>
-  <div id="oc-files-sharing-sidebar" class="oc-position-relative" data-custom-key-bindings="true">
+  <div id="oc-files-sharing-sidebar" class="oc-position-relative">
     <div class="oc-flex">
       <h3 v-translate class="oc-text-bold oc-text-medium oc-m-rm">Members</h3>
       <oc-contextual-helper v-if="helpersEnabled" class="oc-pl-xs" v-bind="spaceAddMemberHelp" />
diff --git a/packages/web-app-files/tests/unit/components/SideBar/Shares/__snapshots__/FileShares.spec.js.snap b/packages/web-app-files/tests/unit/components/SideBar/Shares/__snapshots__/FileShares.spec.js.snap
index 98105be73a9..35cd40d8c43 100644
--- a/packages/web-app-files/tests/unit/components/SideBar/Shares/__snapshots__/FileShares.spec.js.snap
+++ b/packages/web-app-files/tests/unit/components/SideBar/Shares/__snapshots__/FileShares.spec.js.snap
@@ -1,7 +1,7 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
 exports[`FileShares if currentUser can not share initially renders no share permission message 1`] = `
-<div id="oc-files-sharing-sidebar" data-custom-key-bindings="true" class="oc-position-relative">
+<div id="oc-files-sharing-sidebar" class="oc-position-relative">
   <div class="oc-flex">
     <h3 class="oc-text-bold oc-text-medium oc-m-rm" data-msgid="Share with people" data-current-language="en_US">Share with people</h3>
     <!---->
@@ -14,7 +14,7 @@ exports[`FileShares if currentUser can not share initially renders no share perm
 `;
 
 exports[`FileShares if currentUser can share initially renders add people dialog 1`] = `
-<div id="oc-files-sharing-sidebar" data-custom-key-bindings="true" class="oc-position-relative">
+<div id="oc-files-sharing-sidebar" class="oc-position-relative">
   <div class="oc-flex">
     <h3 class="oc-text-bold oc-text-medium oc-m-rm" data-msgid="Share with people" data-current-language="en_US">Share with people</h3>
     <!---->
@@ -27,7 +27,7 @@ exports[`FileShares if currentUser can share initially renders add people dialog
 `;
 
 exports[`FileShares if there are collaborators present correctly passes the shared parent route to the collaborator list item 1`] = `
-<div id="oc-files-sharing-sidebar" data-custom-key-bindings="true" class="oc-position-relative">
+<div id="oc-files-sharing-sidebar" class="oc-position-relative">
   <div class="oc-flex">
     <h3 class="oc-text-bold oc-text-medium oc-m-rm" data-msgid="Share with people" data-current-language="en_US">Share with people</h3>
     <!---->
@@ -47,7 +47,7 @@ exports[`FileShares if there are collaborators present correctly passes the shar
 `;
 
 exports[`FileShares if there are collaborators present renders sharedWithLabel and sharee list 1`] = `
-<div id="oc-files-sharing-sidebar" data-custom-key-bindings="true" class="oc-position-relative">
+<div id="oc-files-sharing-sidebar" class="oc-position-relative">
   <div class="oc-flex">
     <h3 class="oc-text-bold oc-text-medium oc-m-rm" data-msgid="Share with people" data-current-language="en_US">Share with people</h3>
     <!---->
@@ -70,7 +70,7 @@ exports[`FileShares if there are collaborators present renders sharedWithLabel a
 `;
 
 exports[`FileShares if there are no collaborators does not render avatar wrapper or collaborator list 1`] = `
-<div id="oc-files-sharing-sidebar" data-custom-key-bindings="true" class="oc-position-relative">
+<div id="oc-files-sharing-sidebar" class="oc-position-relative">
   <div class="oc-flex">
     <h3 class="oc-text-bold oc-text-medium oc-m-rm" data-msgid="Share with people" data-current-language="en_US">Share with people</h3>
     <!---->
@@ -83,7 +83,7 @@ exports[`FileShares if there are no collaborators does not render avatar wrapper
 `;
 
 exports[`FileShares renders loading spinner while loading 1`] = `
-<div id="oc-files-sharing-sidebar" data-custom-key-bindings="true" class="oc-position-relative">
+<div id="oc-files-sharing-sidebar" class="oc-position-relative">
   <div class="oc-flex">
     <h3 class="oc-text-bold oc-text-medium oc-m-rm" data-msgid="Share with people" data-current-language="en_US">Share with people</h3>
     <!---->
diff --git a/packages/web-app-files/tests/unit/components/SideBar/Shares/__snapshots__/SpaceMembers.spec.js.snap b/packages/web-app-files/tests/unit/components/SideBar/Shares/__snapshots__/SpaceMembers.spec.js.snap
index bb04e21e1c3..e9be29c76a8 100644
--- a/packages/web-app-files/tests/unit/components/SideBar/Shares/__snapshots__/SpaceMembers.spec.js.snap
+++ b/packages/web-app-files/tests/unit/components/SideBar/Shares/__snapshots__/SpaceMembers.spec.js.snap
@@ -1,7 +1,7 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
 exports[`SpaceMembers if currentUser can not share other shares are listed, but creating/editing shares is not possible 1`] = `
-<div id="oc-files-sharing-sidebar" data-custom-key-bindings="true" class="oc-position-relative">
+<div id="oc-files-sharing-sidebar" class="oc-position-relative">
   <div class="oc-flex">
     <h3 class="oc-text-bold oc-text-medium oc-m-rm" data-msgid="Members" data-current-language="en_US">Members</h3>
     <!---->
@@ -16,7 +16,7 @@ exports[`SpaceMembers if currentUser can not share other shares are listed, but
 `;
 
 exports[`SpaceMembers if currentUser can share initially renders add people dialog 1`] = `
-<div id="oc-files-sharing-sidebar" data-custom-key-bindings="true" class="oc-position-relative">
+<div id="oc-files-sharing-sidebar" class="oc-position-relative">
   <div class="oc-flex">
     <h3 class="oc-text-bold oc-text-medium oc-m-rm" data-msgid="Members" data-current-language="en_US">Members</h3>
     <!---->
@@ -31,7 +31,7 @@ exports[`SpaceMembers if currentUser can share initially renders add people dial
 `;
 
 exports[`SpaceMembers if currentUser is manager allows role edit of the current user if another user is manager 1`] = `
-<div id="oc-files-sharing-sidebar" data-custom-key-bindings="true" class="oc-position-relative">
+<div id="oc-files-sharing-sidebar" class="oc-position-relative">
   <div class="oc-flex">
     <h3 class="oc-text-bold oc-text-medium oc-m-rm" data-msgid="Members" data-current-language="en_US">Members</h3>
     <!---->
@@ -52,7 +52,7 @@ exports[`SpaceMembers if currentUser is manager allows role edit of the current
 `;
 
 exports[`SpaceMembers if currentUser is manager does not allow role edit of the current user if they are the only manager 1`] = `
-<div id="oc-files-sharing-sidebar" data-custom-key-bindings="true" class="oc-position-relative">
+<div id="oc-files-sharing-sidebar" class="oc-position-relative">
   <div class="oc-flex">
     <h3 class="oc-text-bold oc-text-medium oc-m-rm" data-msgid="Members" data-current-language="en_US">Members</h3>
     <!---->
@@ -70,7 +70,7 @@ exports[`SpaceMembers if currentUser is manager does not allow role edit of the
 `;
 
 exports[`SpaceMembers renders loading spinner while loading 1`] = `
-<div id="oc-files-sharing-sidebar" data-custom-key-bindings="true" class="oc-position-relative">
+<div id="oc-files-sharing-sidebar" class="oc-position-relative">
   <div class="oc-flex">
     <h3 class="oc-text-bold oc-text-medium oc-m-rm" data-msgid="Members" data-current-language="en_US">Members</h3>
     <!---->