feat(ast): add node_id field to all AST struct nodes (#18138)

## Summary

- Add `pub node_id: NodeId` as the first field in all AST structs (~190 structs across js.rs, ts.rs, jsx.rs, literal.rs)
- Update codegen to special-case `node_id`:
  - `Dummy`: Use `NodeId::DUMMY` instead of `Dummy::dummy(allocator)`
  - `CloneIn`: Use `NodeId::DUMMY` for regular clone, preserve ID for semantic clone
  - `ContentEq`: Skip `node_id` from equality comparisons
  - `ESTree`: Skip `node_id` from serialization
  - `AstBuilder`: Exclude `node_id` from builder parameters, use `NodeId::DUMMY`
- Update pattern matching in minifier and transformer to use `..` for new field
- Update traverse script to include `NodeId` import

This is the foundational step for assigning unique IDs to AST nodes. The `node_id` defaults to `NodeId::DUMMY` (value 0) for uninitialized nodes.

## Test plan

- [x] `cargo build` succeeds
- [x] `cargo test` passes
- [x] `just ast` regenerates code correctly

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Author: Boshen

apps/oxlint/src-js/generated/deserialize.js

@@ -4,10 +4,13 @@
 // They are purely markers for codegen used in `tasks/ast_tools`. See docs in that crate.
 // Read [`macro@oxc_ast_macros::ast`] for more information.
 
+use std::cell::Cell;
+
 use oxc_allocator::{Box, CloneIn, Dummy, GetAddress, TakeIn, UnstableAddress, Vec};
 use oxc_ast_macros::ast;
 use oxc_estree::ESTree;
 use oxc_span::{Atom, ContentEq, GetSpan, GetSpanMut, Span};
+use oxc_syntax::node::NodeId;
 
 use super::{inherit_variants, js::*, literal::*, ts::*};
 
@@ -34,7 +37,9 @@ use super::{inherit_variants, js::*, literal::*, ts::*};
 #[derive(Debug)]
 #[generate_derive(CloneIn, Dummy, TakeIn, GetSpan, GetSpanMut, ContentEq, ESTree, UnstableAddress)]
 pub struct JSXElement<'a> {
-    /// Node location in source code
+    /// Unique identifier for this AST node.
+    pub node_id: Cell<NodeId>,
+    /// Node location in source code.
     pub span: Span,
     /// Opening tag of the element.
     #[estree(via = JSXElementOpeningElement)]
@@ -67,7 +72,9 @@ pub struct JSXElement<'a> {
 #[generate_derive(CloneIn, Dummy, TakeIn, GetSpan, GetSpanMut, ContentEq, ESTree, UnstableAddress)]
 #[estree(add_fields(selfClosing = JSXOpeningElementSelfClosing))]
 pub struct JSXOpeningElement<'a> {
-    /// Node location in source code
+    /// Unique identifier for this AST node.
+    pub node_id: Cell<NodeId>,
+    /// Node location in source code.
     pub span: Span,
     /// The possibly-namespaced tag name, e.g. `Foo` in `<Foo />`.
     pub name: JSXElementName<'a>,
@@ -93,7 +100,9 @@ pub struct JSXOpeningElement<'a> {
 #[derive(Debug)]
 #[generate_derive(CloneIn, Dummy, TakeIn, GetSpan, GetSpanMut, ContentEq, ESTree, UnstableAddress)]
 pub struct JSXClosingElement<'a> {
-    /// Node location in source code
+    /// Unique identifier for this AST node.
+    pub node_id: Cell<NodeId>,
+    /// Node location in source code.
     pub span: Span,
     /// The tag name, e.g. `Foo` in `</Foo>`.
     pub name: JSXElementName<'a>,
@@ -111,7 +120,9 @@ pub struct JSXClosingElement<'a> {
 #[derive(Debug)]
 #[generate_derive(CloneIn, Dummy, TakeIn, GetSpan, GetSpanMut, ContentEq, ESTree, UnstableAddress)]
 pub struct JSXFragment<'a> {
-    /// Node location in source code
+    /// Unique identifier for this AST node.
+    pub node_id: Cell<NodeId>,
+    /// Node location in source code.
     pub span: Span,
     /// `<>`
     pub opening_fragment: JSXOpeningFragment,
@@ -127,7 +138,9 @@ pub struct JSXFragment<'a> {
 #[generate_derive(CloneIn, Dummy, TakeIn, GetSpan, GetSpanMut, ContentEq, ESTree, UnstableAddress)]
 #[estree(add_fields(attributes = JsEmptyArray, selfClosing = JsFalse))]
 pub struct JSXOpeningFragment {
-    /// Node location in source code
+    /// Unique identifier for this AST node.
+    pub node_id: Cell<NodeId>,
+    /// Node location in source code.
     pub span: Span,
 }
 
@@ -136,7 +149,9 @@ pub struct JSXOpeningFragment {
 #[derive(Debug)]
 #[generate_derive(CloneIn, Dummy, TakeIn, GetSpan, GetSpanMut, ContentEq, ESTree, UnstableAddress)]
 pub struct JSXClosingFragment {
-    /// Node location in source code
+    /// Unique identifier for this AST node.
+    pub node_id: Cell<NodeId>,
+    /// Node location in source code.
     pub span: Span,
 }
 
@@ -170,7 +185,9 @@ pub enum JSXElementName<'a> {
 #[derive(Debug)]
 #[generate_derive(CloneIn, Dummy, TakeIn, GetSpan, GetSpanMut, ContentEq, ESTree, UnstableAddress)]
 pub struct JSXNamespacedName<'a> {
-    /// Node location in source code
+    /// Unique identifier for this AST node.
+    pub node_id: Cell<NodeId>,
+    /// Node location in source code.
     pub span: Span,
     /// Namespace portion of the name, e.g. `Apple` in `<Apple:Orange />`
     pub namespace: JSXIdentifier<'a>,
@@ -197,7 +214,9 @@ pub struct JSXNamespacedName<'a> {
 #[derive(Debug)]
 #[generate_derive(CloneIn, Dummy, TakeIn, GetSpan, GetSpanMut, ContentEq, ESTree, UnstableAddress)]
 pub struct JSXMemberExpression<'a> {
-    /// Node location in source code
+    /// Unique identifier for this AST node.
+    pub node_id: Cell<NodeId>,
+    /// Node location in source code.
     pub span: Span,
     /// The object being accessed. This is everything before the last `.`.
     pub object: JSXMemberExpressionObject<'a>,
@@ -252,7 +271,9 @@ pub enum JSXMemberExpressionObject<'a> {
 #[derive(Debug)]
 #[generate_derive(CloneIn, Dummy, TakeIn, GetSpan, GetSpanMut, ContentEq, ESTree, UnstableAddress)]
 pub struct JSXExpressionContainer<'a> {
-    /// Node location in source code
+    /// Unique identifier for this AST node.
+    pub node_id: Cell<NodeId>,
+    /// Node location in source code.
     pub span: Span,
     /// The expression inside the container.
     pub expression: JSXExpression<'a>,
@@ -287,7 +308,9 @@ pub enum JSXExpression<'a> {
 #[derive(Debug)]
 #[generate_derive(CloneIn, Dummy, TakeIn, GetSpan, GetSpanMut, ContentEq, ESTree, UnstableAddress)]
 pub struct JSXEmptyExpression {
-    /// Node location in source code
+    /// Unique identifier for this AST node.
+    pub node_id: Cell<NodeId>,
+    /// Node location in source code.
     pub span: Span,
 }
 
@@ -327,7 +350,9 @@ pub enum JSXAttributeItem<'a> {
 #[derive(Debug)]
 #[generate_derive(CloneIn, Dummy, TakeIn, GetSpan, GetSpanMut, ContentEq, ESTree, UnstableAddress)]
 pub struct JSXAttribute<'a> {
-    /// Node location in source code
+    /// Unique identifier for this AST node.
+    pub node_id: Cell<NodeId>,
+    /// Node location in source code.
     pub span: Span,
     /// The name of the attribute. This is a prop in React-like applications.
     pub name: JSXAttributeName<'a>,
@@ -348,7 +373,9 @@ pub struct JSXAttribute<'a> {
 #[derive(Debug)]
 #[generate_derive(CloneIn, Dummy, TakeIn, GetSpan, GetSpanMut, ContentEq, ESTree, UnstableAddress)]
 pub struct JSXSpreadAttribute<'a> {
-    /// Node location in source code
+    /// Unique identifier for this AST node.
+    pub node_id: Cell<NodeId>,
+    /// Node location in source code.
     pub span: Span,
     /// The expression being spread.
     pub argument: Expression<'a>,
@@ -420,7 +447,9 @@ pub enum JSXAttributeValue<'a> {
 #[derive(Debug)]
 #[generate_derive(CloneIn, Dummy, TakeIn, GetSpan, GetSpanMut, ContentEq, ESTree, UnstableAddress)]
 pub struct JSXIdentifier<'a> {
-    /// Node location in source code
+    /// Unique identifier for this AST node.
+    pub node_id: Cell<NodeId>,
+    /// Node location in source code.
     pub span: Span,
     /// The name of the identifier.
     #[estree(json_safe)]
@@ -455,7 +484,9 @@ pub enum JSXChild<'a> {
 #[derive(Debug)]
 #[generate_derive(CloneIn, Dummy, TakeIn, GetSpan, GetSpanMut, ContentEq, ESTree, UnstableAddress)]
 pub struct JSXSpreadChild<'a> {
-    /// Node location in source code
+    /// Unique identifier for this AST node.
+    pub node_id: Cell<NodeId>,
+    /// Node location in source code.
     pub span: Span,
     /// The expression being spread.
     pub expression: Expression<'a>,
@@ -475,7 +506,9 @@ pub struct JSXSpreadChild<'a> {
 #[derive(Debug)]
 #[generate_derive(CloneIn, Dummy, TakeIn, GetSpan, GetSpanMut, ContentEq, ESTree, UnstableAddress)]
 pub struct JSXText<'a> {
-    /// Node location in source code
+    /// Unique identifier for this AST node.
+    pub node_id: Cell<NodeId>,
+    /// Node location in source code.
     pub span: Span,
     /// The text content.
     pub value: Atom<'a>,

crates/oxc_ast/src/ast/js.rs

@@ -4,15 +4,18 @@
 // They are purely markers for codegen used in `tasks/ast_tools`. See docs in that crate.
 // Read [`macro@oxc_ast_macros::ast`] for more information.
 
-use std::hash::Hash;
+use std::{cell::Cell, hash::Hash};
 
 use bitflags::bitflags;
 use oxc_allocator::{Box, CloneIn, Dummy, TakeIn, UnstableAddress};
 use oxc_ast_macros::ast;
 use oxc_estree::ESTree;
 use oxc_regular_expression::ast::Pattern;
 use oxc_span::{Atom, ContentEq, GetSpan, GetSpanMut, Span};
-use oxc_syntax::number::{BigintBase, NumberBase};
+use oxc_syntax::{
+    node::NodeId,
+    number::{BigintBase, NumberBase},
+};
 
 /// Boolean literal
 ///
@@ -22,7 +25,9 @@ use oxc_syntax::number::{BigintBase, NumberBase};
 #[generate_derive(CloneIn, Dummy, TakeIn, GetSpan, GetSpanMut, ContentEq, ESTree, UnstableAddress)]
 #[estree(rename = "Literal", add_fields(raw = BooleanLiteralRaw))]
 pub struct BooleanLiteral {
-    /// Node location in source code
+    /// Unique identifier for this AST node.
+    pub node_id: Cell<NodeId>,
+    /// Node location in source code.
     pub span: Span,
     /// The boolean value itself
     pub value: bool,
@@ -36,7 +41,9 @@ pub struct BooleanLiteral {
 #[generate_derive(CloneIn, Dummy, TakeIn, GetSpan, GetSpanMut, ContentEq, ESTree, UnstableAddress)]
 #[estree(rename = "Literal", add_fields(value = Null, raw = NullLiteralRaw))]
 pub struct NullLiteral {
-    /// Node location in source code
+    /// Unique identifier for this AST node.
+    pub node_id: Cell<NodeId>,
+    /// Node location in source code.
     pub span: Span,
 }
 
@@ -48,7 +55,9 @@ pub struct NullLiteral {
 #[generate_derive(CloneIn, Dummy, TakeIn, ContentEq, GetSpan, GetSpanMut, ESTree, UnstableAddress)]
 #[estree(rename = "Literal")]
 pub struct NumericLiteral<'a> {
-    /// Node location in source code
+    /// Unique identifier for this AST node.
+    pub node_id: Cell<NodeId>,
+    /// Node location in source code.
     pub span: Span,
     /// The value of the number, converted into base 10
     pub value: f64,
@@ -72,7 +81,9 @@ pub struct NumericLiteral<'a> {
 #[generate_derive(CloneIn, Dummy, TakeIn, ContentEq, GetSpan, GetSpanMut, ESTree, UnstableAddress)]
 #[estree(rename = "Literal")]
 pub struct StringLiteral<'a> {
-    /// Node location in source code
+    /// Unique identifier for this AST node.
+    pub node_id: Cell<NodeId>,
+    /// Node location in source code.
     pub span: Span,
     /// The value of the string.
     ///
@@ -102,7 +113,9 @@ pub struct StringLiteral<'a> {
 #[generate_derive(CloneIn, Dummy, TakeIn, ContentEq, GetSpan, GetSpanMut, ESTree, UnstableAddress)]
 #[estree(rename = "Literal", add_fields(bigint = BigIntLiteralBigint))]
 pub struct BigIntLiteral<'a> {
-    /// Node location in source code
+    /// Unique identifier for this AST node.
+    pub node_id: Cell<NodeId>,
+    /// Node location in source code.
     pub span: Span,
     /// Bigint value in base 10 with no underscores
     #[estree(via = BigIntLiteralValue)]
@@ -129,7 +142,9 @@ pub struct BigIntLiteral<'a> {
     field_order(value, raw, regex, span),
 )]
 pub struct RegExpLiteral<'a> {
-    /// Node location in source code
+    /// Unique identifier for this AST node.
+    pub node_id: Cell<NodeId>,
+    /// Node location in source code.
     pub span: Span,
     /// The parsed regular expression. See [`oxc_regular_expression`] for more
     /// details.