From bf2a969186112169ac4d2604b9108a19f1583113 Mon Sep 17 00:00:00 2001 From: David Crespo Date: Mon, 3 Mar 2025 12:26:07 -0600 Subject: [PATCH 1/2] double default expect timeout to 10s --- playwright.config.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/playwright.config.ts b/playwright.config.ts index 2fd345a3f2..7b08a20762 100644 --- a/playwright.config.ts +++ b/playwright.config.ts @@ -21,6 +21,9 @@ export default { workers: process.env.CI ? '100%' : undefined, timeout: 60 * 1000, // 1 minute fullyParallel: true, + // default is 5 seconds. somehow playwright really hates async route modules, + // takes a long time to load them. https://playwright.dev/docs/test-timeouts + expect: { timeout: 10_000 }, use: { trace: process.env.CI ? 'on-first-retry' : 'retain-on-failure', baseURL: 'http://localhost:4009', From 9b51a4370e6e4b3436392707b08530eaac5da277 Mon Sep 17 00:00:00 2001 From: David Crespo Date: Mon, 3 Mar 2025 12:40:30 -0600 Subject: [PATCH 2/2] remove 10s overrides now that it's default --- test/e2e/breadcrumbs.e2e.ts | 2 +- test/e2e/image-upload.e2e.ts | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/test/e2e/breadcrumbs.e2e.ts b/test/e2e/breadcrumbs.e2e.ts index bf81ddf38f..5f3393ea2f 100644 --- a/test/e2e/breadcrumbs.e2e.ts +++ b/test/e2e/breadcrumbs.e2e.ts @@ -21,7 +21,7 @@ async function getCrumbs(page: Page) { type Pair = [string, string] async function expectCrumbs(page: Page, crumbs: Pair[]) { - await expect.poll(() => getCrumbs(page), { timeout: 10000 }).toEqual(crumbs) + await expect.poll(() => getCrumbs(page)).toEqual(crumbs) } const projectCrumbs: Pair[] = [ diff --git a/test/e2e/image-upload.e2e.ts b/test/e2e/image-upload.e2e.ts index 4f25191845..36619b8d2b 100644 --- a/test/e2e/image-upload.e2e.ts +++ b/test/e2e/image-upload.e2e.ts @@ -141,7 +141,7 @@ test.describe('Image upload', () => { // wait to be in the middle of the specified step const uploadStep = page.getByTestId(`upload-step: ${state}`) - await expect(uploadStep).toHaveAttribute('data-status', 'running', { timeout: 10000 }) + await expect(uploadStep).toHaveAttribute('data-status', 'running') // form is disabled and semi-hidden // await expectNotVisible(page, ['role=textbox[name="Name"]']) @@ -159,8 +159,7 @@ test.describe('Image upload', () => { await page.getByRole('button', { name: 'Cancel' }).click() await page.getByRole('link', { name: 'Disks' }).click() await expect(page.getByRole('cell', { name: 'disk-1', exact: true })).toBeVisible() - // needs a little extra time for delete to go through - await expect(page.getByRole('cell', { name: 'tmp' })).toBeHidden({ timeout: 10000 }) + await expect(page.getByRole('cell', { name: 'tmp' })).toBeHidden() }) }