Conversation
pgjones
force-pushed
the
workflow
branch
3 times, most recently
from
145f61f to
4044716
Compare
Member
|
It doesn't seem to cut down on much boilerplate, there's still approximately the same amount of workflow code to keep synced across projects. Is there more than can be done? |
Member
Author
|
Yea, I can also change the pre-commit and publish workflows to use shared actions. If we like this pattern? |
Member
Author
|
Added pre-commit and build actions - will clean up and fix if we like this pattern. |
pamelafox
reviewed
Jan 23, 2025
| @@ -0,0 +1,215 @@ | |||
| from __future__ import annotations | |||
Contributor
There was a problem hiding this comment.
This stuff isnt meant to be in the PR, right?
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Member
|
@samuelpondugala This is not a playground. If you are running bots to auto-comment on github, test them on your own repos. |
This should allow for a large reduction in duplicated action code across the pallet's repos.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.