Fix old pkg_resources egg version normalization.#227
Closed
mikekap wants to merge 1 commit intopex-tool:masterfrom
Closed
Fix old pkg_resources egg version normalization.#227mikekap wants to merge 1 commit intopex-tool:masterfrom
mikekap wants to merge 1 commit intopex-tool:masterfrom
Conversation
Before recent releases of setuptools, the version numbers in eggs were mangled. `safe_version` handles this correctly in modern `setuptools` and should work on older setuptools as well. Closes pex-tool#226.
Closed
Member
|
The function at least goes back ~forever So LGTM: |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before recent releases of
setuptools, version numbers in egg filenames were mangled.safe_versionhandles this correctly in modernsetuptoolsand should work on older setuptools as well.Closes #226.