Skip to content

Commit db9c392

Browse files
committed
Demote PT-AT from runtime dependency to dev. dependency
1 parent 0e94b68 commit db9c392

3 files changed

Lines changed: 8 additions & 13 deletions

File tree

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ recommendations of [keepachangelog.com](http://keepachangelog.com/).
88
### Breaking Changes
99

1010
- Remove all methods deprecated in PT 9
11+
- `paper_trail-association_tracking` is no longer a runtime dependency. If you
12+
use it, you must now add it to your own `Gemfile`.
1113
- [#1108](https://github.com/paper-trail-gem/paper_trail/pull/1108) -
1214
In `versions.item_type`, we now store the subclass name instead of
1315
the base_class.

README.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -844,10 +844,11 @@ these issues, PT-AT was extracted (see
844844
https://github.com/paper-trail-gem/paper_trail/issues/1070).
845845

846846
Even though this has always been an experimental feature, we don't want the
847-
extraction of PT-AT to be a breaking change. So, `paper_trail` will have a
848-
runtime dependency on this gem and will keep running the existing tests related
849-
to association tracking. This arrangement will be maintained for a few years, if
850-
practical.
847+
extraction of PT-AT to be a breaking change. In PT 9, PT-AT was kept as a
848+
runtime dependency. In PT 10, it is a development dependency, so if you use it
849+
you must add it to your own `Gemfile`. We will keep PT-AT as a development
850+
dependency and continue running the existing tests related to association
851+
tracking for as long as is practical.
851852

852853
### 4.c. Storing Metadata
853854

paper_trail.gemspec

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -29,22 +29,14 @@ has been destroyed.
2929

3030
# Rails does not follow semver, makes breaking changes in minor versions.
3131
s.add_dependency "activerecord", [">= 4.2", "< 5.3"]
32-
33-
# This `PT_ASSOCIATION_TRACKING` variable is convenient for the test suite of
34-
# `paper_trail-association_tracking`. Normal users of paper_trail should not
35-
# set this variable. This variable may be removed in the future without
36-
# warning.
37-
unless ENV["PT_ASSOCIATION_TRACKING"] == "false"
38-
s.add_dependency "paper_trail-association_tracking", "< 2"
39-
end
40-
4132
s.add_dependency "request_store", "~> 1.1"
4233

4334
s.add_development_dependency "appraisal", "~> 2.2"
4435
s.add_development_dependency "byebug", "~> 10.0"
4536
s.add_development_dependency "ffaker", "~> 2.8"
4637
s.add_development_dependency "generator_spec", "~> 0.9.4"
4738
s.add_development_dependency "mysql2", "~> 0.4.10"
39+
s.add_development_dependency "paper_trail-association_tracking", "< 2"
4840
s.add_development_dependency "pg", "~> 0.21.0"
4941
s.add_development_dependency "rake", "~> 12.3"
5042
s.add_development_dependency "rspec-rails", "~> 3.7.2"

0 commit comments

Comments
 (0)