Skip to content

Fix: check bonus config in crowdloan#1901

Merged
mclyk merged 4 commits into
masterfrom
Fix/distribute-reward
Oct 31, 2022
Merged

Fix: check bonus config in crowdloan#1901
mclyk merged 4 commits into
masterfrom
Fix/distribute-reward

Conversation

@mclyk
Copy link
Copy Markdown
Contributor

@mclyk mclyk commented Oct 28, 2022

Add more checks when updateBonusconfig.

@mclyk mclyk requested a review from 0x8f701 October 28, 2022 03:14
@mclyk
Copy link
Copy Markdown
Contributor Author

mclyk commented Oct 28, 2022

@GopherJ pls check this PR, and do you think if we need to ensure start_time>current_time when updating bonus config? like mentioned in this card: https://parallelfi.atlassian.net/browse/BTE-962

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Base: 58.42% // Head: 58.48% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (86bbb13) compared to base (cf61201).
Patch coverage: 96.96% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1901      +/-   ##
==========================================
+ Coverage   58.42%   58.48%   +0.05%     
==========================================
  Files         194      194              
  Lines       19740    19768      +28     
==========================================
+ Hits        11533    11561      +28     
  Misses       8207     8207              
Impacted Files Coverage Δ
pallets/crowdloans/src/benchmarking.rs 0.00% <ø> (ø)
pallets/streaming/src/lib.rs 83.59% <80.00%> (ø)
pallets/crowdloans/src/lib.rs 68.11% <100.00%> (+0.15%) ⬆️
pallets/crowdloans/src/tests.rs 100.00% <100.00%> (ø)
pallets/crowdloans/src/types.rs 83.33% <100.00%> (+3.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mclyk mclyk merged commit f15d2ca into master Oct 31, 2022
@mclyk mclyk deleted the Fix/distribute-reward branch October 31, 2022 07:12
@mclyk mclyk mentioned this pull request Nov 5, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants