Split subxt#102
Merged
Merged
Conversation
ascjones
added a commit
that referenced
this pull request
May 6, 2020
ascjones
added a commit
that referenced
this pull request
May 6, 2020
* Update to substrate alpha.7 * Remove gas limit from contracts put code * Rename SystemEvent::ReapedAccount to KilledAccount * Log debug event received before attempting to decode * Temporary registration of Balance type before #102 merged * Show contract test errors, increase instantiate gas_limit
Contributor
|
@dvc94ch thanks I'll take a look later today. Can you merge master again? |
dvc94ch
commented
May 7, 2020
ascjones
reviewed
May 8, 2020
ascjones
left a comment
ascjones
left a comment
Contributor
There was a problem hiding this comment.
Halfway through reviewing, some comments
ascjones
reviewed
May 12, 2020
ascjones
left a comment
ascjones
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Just those unwraps to remove
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ascjones all tests pass