Conversation
dvdplm
approved these changes
Sep 14, 2020
Contributor
There was a problem hiding this comment.
LGTM.
I'd like some docs on how to run the integration-tests tests, but it's ok to defer to a separate PR if you prefer.
EDIT:
I had this in the README for a draft PR, maybe you can adapt it:
+## Running tests
+The normal `cargo test` command works for most tests. There are a few client
+related tests that are `#[ignore]`'d by default. To run them manually, follow
+these steps:
+
+1. Build the test node: `cargo build --release -p test-node`
+1. In the `client` directory, run `./gen-chain-spec.sh` to generate a chain spec file called `dev-chain.json`
+1. Run `run.sh` to start the test node
+1. Uncomment the `#[ignore]`'d test(s) you wish to run
+1. Run the test with e.g. `cargo test -p client test_light_client`
Contributor
Author
|
Cool I think we can do that as a separate PR to unify the testing features and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
subxt_testmacro), for better readability and debuggability (is that a word?)integration-testsfeature for tests which require a running substrate node, instead of just#[ignore]ing them