This repository was archived by the owner on Nov 15, 2023. It is now read-only.
core: grandpa: collect garbage for topic#1780
Merged
Merged
Conversation
andresilva
added
A0-please_review
svyatonik
approved these changes
Feb 13, 2019
Contributor
svyatonik
left a comment
svyatonik
left a comment
There was a problem hiding this comment.
Maybe this also should be fixed: https://github.com/paritytech/substrate/pull/1340/files#diff-0196e317d5f403e7ab200e5e5a85be47R154 ?
Contributor
Author
|
@svyatonik Good catch, thanks! |
MTDK1
pushed a commit
to bdevux/substrate
that referenced
this pull request
Apr 12, 2019
* core: grandpa: collect garbage for topic * core: grandpa: use collect_garbage_for_topic in tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This logic was introduced in #1658 and then mistakenly reverted in #1340.