Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Refactor timer in txpool tests#5404

Merged
bkchr merged 1 commit into
masterfrom
nv-revalidation-timer-deterministic
Mar 29, 2020
Merged

Refactor timer in txpool tests#5404
bkchr merged 1 commit into
masterfrom
nv-revalidation-timer-deterministic

Conversation

@NikVolf
Copy link
Copy Markdown
Contributor

@NikVolf NikVolf commented Mar 25, 2020

Closes #5399
Closes #5313
Closes #5144

@NikVolf NikVolf requested a review from tomusdrw as a code owner March 25, 2020 20:41
@NikVolf NikVolf added the A0-please_review Pull request needs code review. label Mar 25, 2020
@NikVolf NikVolf force-pushed the nv-revalidation-timer-deterministic branch 2 times, most recently from 46f10f3 to cd7e801 Compare March 26, 2020 07:08
@NikVolf NikVolf force-pushed the nv-revalidation-timer-deterministic branch from cd7e801 to f8adc92 Compare March 26, 2020 07:11
Copy link
Copy Markdown
Contributor

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems resonable, I just made a patch to intervalier to make sure it has compatible license: NikVolf/intervalier#1

Comment thread client/transaction-pool/Cargo.toml
@bkchr bkchr merged commit 7a96d62 into master Mar 29, 2020
@bkchr bkchr deleted the nv-revalidation-timer-deterministic branch March 29, 2020 08:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky test should_not_retain_invalid_hashes_from_retracted should_revalidate_across_many_blocks is flaky Flaky transaction pool test

3 participants