Skip to content

fix: render MODE highlight when instant query selected#98

Merged
nitisht merged 1 commit into
parseablehq:mainfrom
pratik50:fix/minor-ui-update
May 27, 2026
Merged

fix: render MODE highlight when instant query selected#98
nitisht merged 1 commit into
parseablehq:mainfrom
pratik50:fix/minor-ui-update

Conversation

@pratik50
Copy link
Copy Markdown
Contributor

@pratik50 pratik50 commented May 26, 2026

Small fix in the promql dataset and step-mode box -

  • The MODE row wasn't highlighting when instant query was selected because its style was tied to !instant.
  • Added a separate modeLabel style that shows up when instant is active. nothing major.

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Fixed PromQL controls sidebar styling to properly display active state for STEP and MODE controls when the step field is focused in instant query mode.

Review Change Stack

@pratik50 pratik50 self-assigned this May 26, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 98b7e2dc-417c-46c1-abcf-3b54b40e77ca

📥 Commits

Reviewing files that changed from the base of the PR and between 88c1801 and d47c56b.

📒 Files selected for processing (1)
  • pkg/model/promql.go

📝 Walkthrough

Walkthrough

This PR updates the PromQL controls sidebar rendering in pkg/model/promql.go to preserve active styling for the STEP and MODE rows when the step field is focused during instant mode, removing a prior condition that disabled active state selection.

Changes

PromQL Controls Sidebar Styling

Layer / File(s) Summary
Instant mode step focus sidebar active state
pkg/model/promql.go
The sidebar row prefix logic is changed from stepHi && !instant to stepHi, allowing STEP and MODE rows to remain marked as active when the step input has focus in instant mode. A modeLabel variable controls MODE row styling when both stepHi and instant are true.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A step in the spotlight, now instant and bright, 🌟
The sidebar rows dance, no longer held tight,
When focused and ready, both STEP and MODE glow,
The rabbit hops forward with style, row by row! 🐰

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing MODE row highlighting in instant query mode, which is the core focus of the changeset.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Comment @coderabbitai help to get the list of available commands and usage tips.

@nitisht nitisht merged commit 8c87421 into parseablehq:main May 27, 2026
3 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants