Skip to content

fix(textarea): fix height logic for autoresize textarea #11922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolethoen merged 2 commits into from
Jul 25, 2025
+6 −4
Merged

fix(textarea): fix height logic for autoresize textarea #11922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0dbaaab
fix(textarea): fix height logic for autoresize textarea
evwilkin Jul 11, 2025
b64ea01
fix(textarea): update snapshot
evwilkin Jul 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/react-core/src/components/TextArea/TextArea.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,15 @@ class TextAreaBase extends Component<TextAreaProps> {
const parent = field.parentElement;
parent.style.setProperty('height', 'inherit');
const computed = window.getComputedStyle(field);
const parentComputed = window.getComputedStyle(parent);
// Calculate the height
const height =
parseInt(computed.getPropertyValue('border-top-width')) +
parseInt(computed.getPropertyValue('padding-top')) +
field.scrollHeight +
parseInt(computed.getPropertyValue('padding-bottom')) +
parseInt(computed.getPropertyValue('border-bottom-width'));
parseInt(computed.getPropertyValue('border-bottom-width')) +
parseInt(parentComputed.getPropertyValue('padding-top')) +
parseInt(parentComputed.getPropertyValue('padding-bottom'));

parent.style.setProperty('height', `${height}px`);
};

Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/src/components/TextArea/__tests__/__snapshots__/TextArea.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ exports[`Matches the snapshot 1`] = `
<DocumentFragment>
<span
class="pf-v6-c-form-control pf-m-textarea pf-m-resize-both pf-m-disabled custom class"
style="height: 6px;"
style="height: inherit;"
>
<textarea
aria-invalid="false"
Expand Down
Loading