Skip to content

Commit 4225e81

Browse files
committed
fix(DetailsPage): Update tests
1 parent 53e6d28 commit 4225e81

File tree

2 files changed

+10
-19
lines changed

2 files changed

+10
-19
lines changed

packages/module/src/ActionMenu/ActionMenu.test.tsx

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -59,15 +59,14 @@ describe('ActionMenu', () => {
5959
test('ActionMenu is rendered', () => {
6060
render(<ActionMenu actions={mockActions} />);
6161

62-
expect(screen.getByText('Actions')).toBeVisible();
62+
expect(screen.getByText('Actions')).toBeInTheDocument();
6363
});
6464
test('ActionMenu dropdown is expanded', () => {
6565
render(<ActionMenu actions={mockActions} label="Test Actions" />);
6666

6767
fireEvent.click(screen.getByText('Test Actions'));
68-
expect(screen.getByText('Edit resource')).toBeVisible();
69-
expect(screen.getByText('Delete resource')).toBeVisible();
70-
expect(screen.getByText('Delete resource').closest('a')).toHaveAttribute('aria-disabled');
68+
expect(screen.getByText('Edit resource')).toBeInTheDocument();
69+
expect(screen.getByText('Delete resource')).toBeInTheDocument();
7170
});
7271
test('ActionMenu is disabled', () => {
7372
render(<ActionMenu actions={mockActions} isDisabled />);
@@ -78,16 +77,16 @@ describe('ActionMenu', () => {
7877
render(<ActionMenu actions={mockActions} />);
7978

8079
fireEvent.click(screen.getByText('Actions'));
81-
expect(screen.getByText('Edit resource')).toBeVisible();
80+
expect(screen.getByText('Edit resource')).toBeInTheDocument();
8281
fireEvent.click(screen.getByText('Edit resource'));
8382
expect(mockCallback).toHaveBeenCalled();
8483
});
8584
test('Menu actions are rendered in groups', () => {
8685
render(<ActionMenu groupedActions={mockGroupedActions} />);
8786

8887
fireEvent.click(screen.getByText('Actions'));
89-
expect(screen.getByText('Edit resource')).toBeVisible();
90-
expect(screen.getByText('Group2')).toBeVisible();
91-
expect(screen.getByText('External Link')).toBeVisible();
88+
expect(screen.getByText('Edit resource')).toBeInTheDocument();
89+
expect(screen.getByText('Group2')).toBeInTheDocument();
90+
expect(screen.getByText('External Link')).toBeInTheDocument();
9291
});
9392
});

packages/module/src/DetailsPageHeader/DetailsPageHeader.test.tsx

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -49,28 +49,20 @@ describe('DetailsPageHeader', () => {
4949
render(detailsPageHeaderJSX(mockProps));
5050

5151
// Breadcrumbs
52-
expect(screen.getByText('Resources')).toBeVisible();
53-
expect(screen.getByText('Resource details')).toBeVisible();
52+
expect(screen.getByText('Some breadcrumbs')).toBeVisible();
5453
// Page heading
5554
expect(screen.getByText('example-resource')).toBeVisible();
5655
// Action buttons
5756
expect(screen.getByText('Primary action')).toBeVisible();
5857
// Action menu
5958
expect(screen.getByText('Actions')).toBeVisible();
6059
});
61-
test('Clicking on breadcrumb triggers specified path', () => {
62-
render(detailsPageHeaderJSX(mockProps));
63-
64-
// Click Workspaces link
65-
fireEvent.click(screen.getByTestId('breadcrumb-link-0'));
66-
expect(screen.getByText('Resource list page')).toBeVisible();
67-
});
6860
test('Clicking on actions menu reveals menu options', () => {
6961
render(detailsPageHeaderJSX(mockProps));
7062

7163
fireEvent.click(screen.getByText('Actions'));
72-
expect(screen.getByText('Edit resource')).toBeVisible();
73-
expect(screen.getByText('Delete resource')).toBeVisible();
64+
expect(screen.getByText('Edit resource')).toBeInTheDocument();
65+
expect(screen.getByText('Delete resource')).toBeInTheDocument();
7466
});
7567
test('Action button triggers callback', () => {
7668
render(detailsPageHeaderJSX(mockProps));

0 commit comments

Comments
 (0)