Skip to content

fix: annotate conference list with has_errors, has_warnings, participants_count #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agonza1 merged 3 commits into from
Apr 10, 2026
Merged

fix: annotate conference list with has_errors, has_warnings, participants_count #22

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d8f7df3
fix: annotate conference list with has_errors, has_warnings, particip…
Boanerges1996 Apr 9, 2026
638cab3
fix: use Subquery for participants_count to avoid filtered join bug
Boanerges1996 Apr 10, 2026
1e4565b
fix: exclude soft-deleted participants from participants_count
Boanerges1996 Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions app/views/conference_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
import datetime

from django.core.exceptions import ValidationError
from django.db.models import Count, Exists, IntegerField, OuterRef, Subquery

from ..errors import (INVALID_PARAMETERS, CONFERENCE_NOT_FOUND,
MISSING_PARAMETERS, PMError)
from ..utils import JSONHttpResponse, serialize, paginate_and_serialize
from ..models.conference import Conference
from ..models.issue import Issue
from ..models.participant import Participant
from .generic_view import GenericView

class ConferencesView(GenericView):
Expand Down Expand Up @@ -40,12 +43,31 @@ def filter(cls, request):
filters['created_at__gt'] = datetime.datetime.fromisoformat(filters.get('created_at__gt'))

try:
objs = Conference.filter(**filters)
objs = Conference.filter(**filters).annotate(
has_errors=Exists(
Issue.objects.filter(conference=OuterRef('pk'), type='e', is_active=True)
),
has_warnings=Exists(
Issue.objects.filter(conference=OuterRef('pk'), type='w', is_active=True)
),
participants_count=Subquery(
Participant.objects.filter(
conferences=OuterRef('pk'),
is_active=True,
).order_by().values('conferences').annotate(
cnt=Count('id', distinct=True)
).values('cnt')[:1],
output_field=IntegerField(),
),
)
except ValidationError:
raise PMError(status=400, app_error=INVALID_PARAMETERS)

return JSONHttpResponse(
content=paginate_and_serialize(request, objs),
content=paginate_and_serialize(
request, objs,
properties=['has_errors', 'has_warnings', 'participants_count'],
),
)

@classmethod
Expand Down