fix: use participants_count from API for participants chart#23
Merged
agonza1 merged 1 commit intoApr 10, 2026
Merged
Conversation
Uses conf.participants_count (annotated by api#22) instead of conf.participants.length. Falls back to participants.length for detail views where the full array is still available.
Contributor
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The "Number of participants" chart shows all zeros because
conf.participantsis undefined on list responses (expand_fields removed in api#19).Fix
Uses
conf.participants_count(annotated integer from api#22) instead ofconf.participants.length. Falls back toparticipants.lengthfor conference detail views where the full array is still available.Dependencies
Requires peermetrics/api#22 to be deployed.
Test plan