Merge pull request #1327 from pharo-spec/dev-2.0

new settings browser re-work

Author: estebanlm

src/NewTools-Debugger/StDebugger.class.st

@@ -3,13 +3,11 @@ The StDebugger is a presenter that provides Pharo debugging functionality by usi
 
 The debugging logic is in DebugSession and the corresponding debugging actions. 
 
-SpecDebugger only provides a graphical interface to access that functionality. 
-To interact with the DebugSession, the debugger uses a StDebuggerActionModel, which has responsibility to perform actions to the execution context.
+StDebugger only provides a graphical interface to access that functionality. 
+To interact with the `DebugSession`, the debugger uses a `StDebuggerClientModel`, which has responsibility to perform actions to the execution context.
 
-
-!!Structure of the Pharo debugger
-
-!!!Sub-presenters and layouts
+## Structure of the Pharo debugger
+### Sub-presenters and layouts
 The debugger is composed of default views and extension views.
 Default views are the stack, the commands, the status line, the code pane and the inspector.
 An extension view automatically appears if any debugging extension is present and if extensions are activated in the settings.
@@ -19,9 +17,9 @@ Default and extension views are available in a vertical and an horizontal layout
 It is configureable in the settings under ==Tools >> Debugging >> Debugger layout==.
 It is possible to fully customize the debugger layout, and therefore to add or remove any view.
 The customized layout must then me selected in the aforementioned setting to be set as default.
-To appear in that setting's list of possible values, the layout must be implemented in a method under the ==specs== protocol of the ==StDebugger== class side.
+To appear in that setting's list of possible values, the layout must be implemented in a method under the ==specs== protocol of the `StDebugger`  class side.
 
-""""The stack.""""
+### The stack
 It shows the call stack of the current interrupted context.
 Each element in the stack is a context representing a message send.
 
@@ -30,33 +28,33 @@ The context menu (through right click) provides different interactions with the
 By default, only a small part of the stack is shown.
 More of the stack is observable by either clicking on the bottom context (the last in the stack) or through the context menu.
 
-""""Commands.""""
+### Commands
 Commands are actions applicable to the current context
 After each debugging action (''e.g.'', a step), the list of commands is being updated.
 New commands may appear or disappear.
 It depends if they are applicable or not to the current context and debugging session.
 For instance, when a ==doesNotUnderstand== exception is raised (''i.e.'', a method does not exist), the command ''createMethod'' will appear.
 In that case, it gives users the possibility to create the missing method and continue the execution.
 
-""""The status line.""""
+### The status line
 This view provides information about the current context.
 Non-critical information, such as the current instruction being stepped, are displayed in gray.
 Critical information ,such as halts or breakpoints or DNU exceptions, are displayed in red.
 
-""""The code.""""
+### The code
 The code pane shows the source code of the interrupted context's method.
 The source code is annotated with informations about the position of the interrupted execution.
 This position corresponds to the next execution that will be executed if a step action is performed.
 It is coloured in blue if that instruction is selected in the source code, or in orange and underlined if the selection is empty.
 
 A context menu (through right click) provides inspection, exploration, and stepping actions applicable to the context.
-Such actions include, ''e.g.'', browse implementors of a selected message or skip execution of selected parts of the code.
+Such actions include, *e.g.*, browse implementors of a selected message or skip execution of selected parts of the code.
 
-""""The inspector.""""
+### The inspector
 It provides views on the current context.
 It contains tabs with different inspections or views on the current context or on the system.
 
-The raw inspection shows three items: ''Receiver'', ''Temps'' and ''Context''.
+The raw inspection shows three items: *Receiver*, *Temps* and *Context*.
 The receiver item shows information about the receiver of the message, or the object executing the method from the context.
 The temps item shows the temporary variables of the current context.
 Finally, the context item shows lower-level details, such as the interrupted context, the debug session or the debugger itself.

src/NewTools-FileBrowser/StDirectoryTreePresenter.class.st

@@ -71,7 +71,8 @@ StDirectoryTreePresenter >> expandPath: aFileLocator [
 
 	directoryTreePresenter selectPath: aPathForSpec scrollToSelection: true. "The Morphic `configureScrolling` is executed **AFTER** the desired scroll was configured from the `StDirectoryTreePresenter`. Furthermore, the `configureScrolling` uses the `desiredVisibleRow` which is always set to 1. This statement updates the desired visible row to the last visible index of whatever the selection is pointing to."
 
-	directoryTreePresenter verticalAlignment lastVisibleRowIndex ifNotNil: [ :index | directoryTreePresenter verticalAlignment desiredVisibleRow: index ]
+	directoryTreePresenter verticalAlignment lastVisibleRowIndex ifNotNil: [ :index |
+		directoryTreePresenter verticalAlignment desiredVisibleRow: index ]
 ]
 
 { #category : 'initialization' }

src/NewTools-Gtk/StPharoGtkConfiguration.class.st

@@ -33,7 +33,7 @@ StPharoGtkConfiguration >> configureGeneral: anApplication [
 	self addCSSProviderFromString: self commonStyle.
 	anApplication 
 		propertyAt: #syntaxHighlightTheme
-		put: self syntaxHighlightThemeName
+		put: self syntaxHighlightTheme
 ]
 
 { #category : 'configuring' }

src/NewTools-Inspector-Extensions/AbstractFileReference.extension.st

@@ -173,6 +173,7 @@ AbstractFileReference >> inspectionPng: aBuilder [
 	<inspectorPresentationOrder: 0 title: 'Picture'>
 
 	^ aBuilder newImage
+		autoScale: true;
 		image: (self binaryReadStreamDo: [ :stream | PNGReadWriter formFromStream: stream ]);
 		yourself
 ]

src/NewTools-Inspector-Extensions/MetacelloMemberListSpec.extension.st

@@ -28,6 +28,12 @@ StInspectorInspectSelectedCommand class >> defaultName [
 	^ 'Inspect'
 ]
 
+{ #category : 'initialization' }
+StInspectorInspectSelectedCommand class >> defaultShortcutKey [
+
+	^ $i actionModifier
+]
+
 { #category : 'documentation' }
 StInspectorInspectSelectedCommand class >> documentContextRequiredSelectors [
 
@@ -36,7 +42,6 @@ StInspectorInspectSelectedCommand class >> documentContextRequiredSelectors [
 
 { #category : 'execution' }
 StInspectorInspectSelectedCommand >> execute [ 
-
 	self context systemNavigation inspect: self interestingObject
 
 ]

src/NewTools-Inspector/StInspectorInspectSelectedCommand.class.st

@@ -16,6 +16,7 @@ Class {
 
 { #category : 'commands' }
 StRawInspectionPresenter class >> buildCommandsGroupWith: presenter forRoot: aCmCommandsGroup [
+	
 	aCmCommandsGroup
 		beDisplayedAsGroup;
 		register: (StInspectorInspectSelectedCommand forSpecContext: presenter);
@@ -100,6 +101,7 @@ StRawInspectionPresenter >> initializePresenters [
 			transfer target save: (transfer shouldCopy ifTrue: [ value copy ] ifFalse: [ value ]).
 			self step ];
 		yourself.
+		
 	self addVariablesColumn.
 	self addValuesColumn.
 	self setAttributeTable

src/NewTools-Inspector/StRawInspectionPresenter.class.st

@@ -455,7 +455,7 @@ StMethodBrowser >> installIconStylerFor: anItem [
 
 	IconStyler withStaticStylers 
 		styleText: textPresenter 
-		withAst: anItem ast.
+		withAst: anItem ast
 ]
 
 { #category : 'private' }

src/NewTools-MethodBrowsers/StMethodBrowser.class.st

@@ -35,6 +35,7 @@ StPlaygroundInteractionModel >> addBindings: aCollection [
 
 { #category : 'binding' }
 StPlaygroundInteractionModel >> addBindingsByDictionary: aDictionary [
+
 	aDictionary keysAndValuesDo: [ :key :value | self addBinding: (WorkspaceVariable key: key value: value) ].
 
 ]

src/NewTools-Playground/StPlaygroundInteractionModel.class.st

@@ -210,6 +210,13 @@ StPlaygroundPage >> readStreamDo: aBlock [
 		ifAbsent: [ nil ]
 ]
 
+{ #category : 'removing' }
+StPlaygroundPage >> removeAllContents [
+
+	(self fileReference withExtension: 'ombu') ensureDelete.
+	self fileReference ensureDelete
+]
+
 { #category : 'accessing' }
 StPlaygroundPage >> renameTo: aFileName [
 	self fileReference renameTo: aFileName, '.', self class pageExtension.