The key length check was not taking the prefix into account#556
Merged
m6w6 merged 2 commits intophp-memcached-dev:masterfrom Sep 26, 2024
Merged
The key length check was not taking the prefix into account#556m6w6 merged 2 commits intophp-memcached-dev:masterfrom
m6w6 merged 2 commits intophp-memcached-dev:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
MEMC_CHECK_KEYmacro meant to make sure keys are valid was not taking a prefix into account when checking the length of the key. This is especially important to get right in case NOREPLY sets are used on a persistent connection because the server will send a parser error back on a long key and the client is not expecting a reply which in turn messes up subsequent requests on this persistent connection.