From a34b059c0143859f9ef2f0e38cc6fabbd3b1e7e7 Mon Sep 17 00:00:00 2001 From: Sergey Panteleev Date: Tue, 29 Oct 2024 20:35:06 +0300 Subject: [PATCH 1/2] [PHP 8.4] Add errors for curl_multi_select --- reference/curl/functions/curl-multi-select.xml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/reference/curl/functions/curl-multi-select.xml b/reference/curl/functions/curl-multi-select.xml index 8cd8f7d2f67d..a29027be1549 100644 --- a/reference/curl/functions/curl-multi-select.xml +++ b/reference/curl/functions/curl-multi-select.xml @@ -50,6 +50,14 @@ + + &reftitle.errors; + + Throws a ValueError if timeout + is less than 0 or greater than PHP_INT_MAX. + + + &reftitle.changelog; @@ -61,6 +69,13 @@ + + 8.4.0 + + Now throws a ValueError if timeout + is less than 0 or greater than PHP_INT_MAX. + + &curl.changelog.multi-handle-param; From e48966267edbdc66d2961f09e06a0250027a6419 Mon Sep 17 00:00:00 2001 From: Sergey Panteleev Date: Tue, 29 Oct 2024 22:46:34 +0300 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: Gina Peter Banyard --- reference/curl/functions/curl-multi-select.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/reference/curl/functions/curl-multi-select.xml b/reference/curl/functions/curl-multi-select.xml index a29027be1549..c2ae4036325e 100644 --- a/reference/curl/functions/curl-multi-select.xml +++ b/reference/curl/functions/curl-multi-select.xml @@ -53,7 +53,7 @@ &reftitle.errors; - Throws a ValueError if timeout + Throws a ValueError if timeout is less than 0 or greater than PHP_INT_MAX. @@ -72,7 +72,7 @@ 8.4.0 - Now throws a ValueError if timeout + Now throws a ValueError if timeout is less than 0 or greater than PHP_INT_MAX.