chore(ci): move security audit from PR checks to release gate#69
Open
chore(ci): move security audit from PR checks to release gate#69
Conversation
Bugbot already handles vulnerability scanning on PRs, making the npm audit step in CI redundant and disruptive. Moving it to the release workflow ensures high/critical CVEs block publishing without blocking unrelated PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bugbot already handles vulnerability scanning on PRs, making the
npm auditstep in CI redundant there. Running it in PR CI also causes friction by blocking merges for vulnerabilities unrelated to the PR's changes. Moving the check to the release workflow ensures high/critical CVEs still block publishing without disrupting PR flow.Changes
npm audit --audit-level=highfrom.github/workflows/ci.ymlnpm audit --audit-level=highto.github/workflows/release.ymlafter theSetupstep, before any version bumping — so a vulnerability stops the release before anything is committed or published to npmTest Plan
Note
Medium Risk
Release pipeline behavior changes: publishes will now fail early on high/critical
npm auditfindings, and PR CI will no longer surface those failures. Low code risk but can impact release velocity if the audit produces new failures.Overview
Shifts vulnerability gating from PR CI to release time. The
npm audit --audit-level=highstep is removed from.github/workflows/ci.yml, so pull-request checks no longer fail due to audit results.Adds a release gate before any version/publish side effects.
.github/workflows/release.ymlnow runs the samenpm auditimmediately afterSetupand before version bumping, ensuring high/critical findings block the release workflow early.Written by Cursor Bugbot for commit 1a468b3. This will update automatically on new commits. Configure here.