Skip to content

Commit 281fc04

Browse files
committed
fix: include short commit SHA in nightly release name
The name template in resolveNightlyReleaseMetadata was missing the short commit SHA, contradicting docs/release.md which states the release name includes the short commit SHA. Append (shortSha) to the name field.
1 parent 5424cfb commit 281fc04

1 file changed

Lines changed: 10 additions & 7 deletions

File tree

scripts/resolve-nightly-release.ts

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,16 @@ const resolveNightlyReleaseMetadata = (
3434
date: string,
3535
runNumber: number,
3636
sha: string,
37-
) => ({
38-
baseVersion,
39-
version: `${baseVersion}-nightly.${date}.${runNumber}`,
40-
tag: `nightly-v${baseVersion}-nightly.${date}.${runNumber}`,
41-
name: `T3 Code Nightly ${baseVersion}-nightly.${date}.${runNumber}`,
42-
shortSha: sha.slice(0, 12),
43-
});
37+
) => {
38+
const shortSha = sha.slice(0, 12);
39+
return {
40+
baseVersion,
41+
version: `${baseVersion}-nightly.${date}.${runNumber}`,
42+
tag: `nightly-v${baseVersion}-nightly.${date}.${runNumber}`,
43+
name: `T3 Code Nightly ${baseVersion}-nightly.${date}.${runNumber} (${shortSha})`,
44+
shortSha,
45+
};
46+
};
4447

4548
const readDesktopBaseVersion = Effect.fn("readDesktopBaseVersion")(function* (
4649
rootDir: string | undefined,

0 commit comments

Comments
 (0)