Unify exit code field name: rename ExecuteGitResult.code to .exitCode

Rename the `code` field in `ExecuteGitResult` to `exitCode` to match
`VcsProcessOutput.exitCode`, eliminating the naming inconsistency across
the same abstraction boundary. Both interfaces now use `exitCode` for
the process exit code, preventing future bugs from field name confusion.

Author: cursoragent

apps/server/src/git/GitManager.test.ts

@@ -224,7 +224,7 @@ function runGit(
       allowNonZeroExit,
     });
     return {
-      code: result.code,
+      code: result.exitCode,
       stdout: result.stdout,
       stderr: result.stderr,
     };

apps/server/src/sourceControl/SourceControlProviderRegistry.test.ts

@@ -8,7 +8,7 @@ import * as SourceControlProviderRegistry from "./SourceControlProviderRegistry.
 const processResult = (stdout: string) => ({
   stdout,
   stderr: "",
-  code: 0,
+  exitCode: 0,
   signal: null,
   timedOut: false,
   stdoutTruncated: false,

apps/server/src/sourceControl/SourceControlProviderRegistry.ts

@@ -89,7 +89,7 @@ export const make = Effect.fn("makeSourceControlProviderRegistry")(function* ()
           })
           .pipe(
             Effect.map((result) =>
-              result.code === 0 ? firstRemoteUrlFromVerboseOutput(result.stdout) : null,
+              result.exitCode === 0 ? firstRemoteUrlFromVerboseOutput(result.stdout) : null,
             ),
             Effect.mapError((error) => providerDetectionError("detectProvider", cwd, error)),
           ));

apps/server/src/vcs/GitVcsDriver.ts

@@ -35,7 +35,7 @@ export interface ExecuteGitInput {
 }
 
 export interface ExecuteGitResult {
-  readonly code: number;
+  readonly exitCode: number;
   readonly stdout: string;
   readonly stderr: string;
   readonly stdoutTruncated: boolean;

apps/server/src/vcs/GitVcsDriverCore.ts

@@ -693,7 +693,7 @@ export const makeGitVcsDriverCore = Effect.fn("makeGitVcsDriverCore")(function*
         }
 
         return {
-          code: exitCode,
+          exitCode,
           stdout: stdout.text,
           stderr: stderr.text,
           stdoutTruncated: stdout.truncated,
@@ -761,7 +761,7 @@ export const makeGitVcsDriverCore = Effect.fn("makeGitVcsDriverCore")(function*
       ...(options.progress ? { progress: options.progress } : {}),
     }).pipe(
       Effect.flatMap((result) => {
-        if (options.allowNonZeroExit || result.code === 0) {
+        if (options.allowNonZeroExit || result.exitCode === 0) {
           return Effect.succeed(result);
         }
         const stderr = result.stderr.trim();
@@ -778,7 +778,7 @@ export const makeGitVcsDriverCore = Effect.fn("makeGitVcsDriverCore")(function*
             operation,
             cwd,
             args,
-            `${commandLabel(args)} failed: code=${result.code ?? "null"}`,
+            `${commandLabel(args)} failed: code=${result.exitCode ?? "null"}`,
           ),
         );
       }),
@@ -823,7 +823,7 @@ export const makeGitVcsDriverCore = Effect.fn("makeGitVcsDriverCore")(function*
         allowNonZeroExit: true,
         timeoutMs: 5_000,
       },
-    ).pipe(Effect.map((result) => result.code === 0));
+    ).pipe(Effect.map((result) => result.exitCode === 0));
 
   const resolveAvailableBranchName = Effect.fn("resolveAvailableBranchName")(function* (
     cwd: string,
@@ -939,7 +939,7 @@ export const makeGitVcsDriverCore = Effect.fn("makeGitVcsDriverCore")(function*
       { allowNonZeroExit: true },
     ).pipe(
       Effect.map((result) => {
-        if (result.code !== 0) {
+        if (result.exitCode !== 0) {
           return null;
         }
         return parseDefaultBranchFromRemoteHeadRef(result.stdout, remoteName);
@@ -958,12 +958,12 @@ export const makeGitVcsDriverCore = Effect.fn("makeGitVcsDriverCore")(function*
       {
         allowNonZeroExit: true,
       },
-    ).pipe(Effect.map((result) => result.code === 0));
+    ).pipe(Effect.map((result) => result.exitCode === 0));
 
   const originRemoteExists = (cwd: string): Effect.Effect<boolean, GitCommandError> =>
     executeGit("GitVcsDriver.originRemoteExists", cwd, ["remote", "get-url", "origin"], {
       allowNonZeroExit: true,
-    }).pipe(Effect.map((result) => result.code === 0));
+    }).pipe(Effect.map((result) => result.exitCode === 0));
 
   const listRemoteNames = (cwd: string): Effect.Effect<ReadonlyArray<string>, GitCommandError> =>
     runGitStdout("GitVcsDriver.listRemoteNames", cwd, ["remote"]).pipe(
@@ -1115,7 +1115,7 @@ export const makeGitVcsDriverCore = Effect.fn("makeGitVcsDriverCore")(function*
       ["rev-list", "--count", `${baseRef}..HEAD`],
       { allowNonZeroExit: true },
     );
-    if (result.code !== 0) {
+    if (result.exitCode !== 0) {
       return 0;
     }
 
@@ -1140,7 +1140,7 @@ export const makeGitVcsDriverCore = Effect.fn("makeGitVcsDriverCore")(function*
     );
 
     const branchLastCommit = new Map<string, number>();
-    if (branchRecency.code !== 0) {
+    if (branchRecency.exitCode !== 0) {
       return branchLastCommit;
     }
 
@@ -1173,7 +1173,7 @@ export const makeGitVcsDriverCore = Effect.fn("makeGitVcsDriverCore")(function*
       return NON_REPOSITORY_STATUS_DETAILS;
     }
 
-    if (statusResult.code !== 0) {
+    if (statusResult.exitCode !== 0) {
       const stderr = statusResult.stderr.trim();
       return yield* createGitCommandError(
         "GitVcsDriver.statusDetails.status",
@@ -1206,7 +1206,7 @@ export const makeGitVcsDriverCore = Effect.fn("makeGitVcsDriverCore")(function*
       );
     const statusStdout = statusResult.stdout;
     const defaultBranch =
-      defaultRefResult.code === 0
+      defaultRefResult.exitCode === 0
         ? defaultRefResult.stdout.trim().replace(/^refs\/remotes\/origin\//, "")
         : null;
 
@@ -1614,7 +1614,7 @@ export const makeGitVcsDriverCore = Effect.fn("makeGitVcsDriverCore")(function*
     ).pipe(
       Effect.catchIf(isMissingGitCwdError, () =>
         Effect.succeed({
-          code: 128,
+          exitCode: 128,
           stdout: "",
           stderr: "fatal: not a git repository",
           stdoutTruncated: false,
@@ -1623,7 +1623,7 @@ export const makeGitVcsDriverCore = Effect.fn("makeGitVcsDriverCore")(function*
       ),
     );
 
-    if (localBranchResult.code !== 0) {
+    if (localBranchResult.exitCode !== 0) {
       const stderr = localBranchResult.stderr.trim();
       if (stderr.toLowerCase().includes("not a git repository")) {
         return {
@@ -1654,7 +1654,7 @@ export const makeGitVcsDriverCore = Effect.fn("makeGitVcsDriverCore")(function*
       Effect.catch((error) =>
         Effect.logWarning(
           `GitVcsDriver.listRefs: remote refName lookup failed for ${input.cwd}: ${error.message}. Falling back to an empty remote refName list.`,
-        ).pipe(Effect.as({ code: 1, stdout: "", stderr: "" })),
+        ).pipe(Effect.as({ exitCode: 1, stdout: "", stderr: "" })),
       ),
     );
 
@@ -1670,7 +1670,7 @@ export const makeGitVcsDriverCore = Effect.fn("makeGitVcsDriverCore")(function*
       Effect.catch((error) =>
         Effect.logWarning(
           `GitVcsDriver.listRefs: remote name lookup failed for ${input.cwd}: ${error.message}. Falling back to an empty remote name list.`,
-        ).pipe(Effect.as({ code: 1, stdout: "", stderr: "" })),
+        ).pipe(Effect.as({ exitCode: 1, stdout: "", stderr: "" })),
       ),
     );
 
@@ -1703,25 +1703,25 @@ export const makeGitVcsDriverCore = Effect.fn("makeGitVcsDriverCore")(function*
       );
 
     const remoteNames =
-      remoteNamesResult.code === 0 ? parseRemoteNames(remoteNamesResult.stdout) : [];
-    if (remoteBranchResult.code !== 0 && remoteBranchResult.stderr.trim().length > 0) {
+      remoteNamesResult.exitCode === 0 ? parseRemoteNames(remoteNamesResult.stdout) : [];
+    if (remoteBranchResult.exitCode !== 0 && remoteBranchResult.stderr.trim().length > 0) {
       yield* Effect.logWarning(
-        `GitVcsDriver.listRefs: remote refName lookup returned code ${remoteBranchResult.code} for ${input.cwd}: ${remoteBranchResult.stderr.trim()}. Falling back to an empty remote refName list.`,
+        `GitVcsDriver.listRefs: remote refName lookup returned code ${remoteBranchResult.exitCode} for ${input.cwd}: ${remoteBranchResult.stderr.trim()}. Falling back to an empty remote refName list.`,
       );
     }
-    if (remoteNamesResult.code !== 0 && remoteNamesResult.stderr.trim().length > 0) {
+    if (remoteNamesResult.exitCode !== 0 && remoteNamesResult.stderr.trim().length > 0) {
       yield* Effect.logWarning(
-        `GitVcsDriver.listRefs: remote name lookup returned code ${remoteNamesResult.code} for ${input.cwd}: ${remoteNamesResult.stderr.trim()}. Falling back to an empty remote name list.`,
+        `GitVcsDriver.listRefs: remote name lookup returned code ${remoteNamesResult.exitCode} for ${input.cwd}: ${remoteNamesResult.stderr.trim()}. Falling back to an empty remote name list.`,
       );
     }
 
     const defaultBranch =
-      defaultRef.code === 0
+      defaultRef.exitCode === 0
         ? defaultRef.stdout.trim().replace(/^refs\/remotes\/origin\//, "")
         : null;
 
     const worktreeMap = new Map<string, string>();
-    if (worktreeList.code === 0) {
+    if (worktreeList.exitCode === 0) {
       let currentPath: string | null = null;
       for (const line of worktreeList.stdout.split("\n")) {
         if (line.startsWith("worktree ")) {
@@ -1762,7 +1762,7 @@ export const makeGitVcsDriverCore = Effect.fn("makeGitVcsDriverCore")(function*
       });
 
     const remoteBranches =
-      remoteBranchResult.code === 0
+      remoteBranchResult.exitCode === 0
         ? remoteBranchResult.stdout
             .split("\n")
             .map(parseBranchLine)
@@ -1943,7 +1943,7 @@ export const makeGitVcsDriverCore = Effect.fn("makeGitVcsDriverCore")(function*
             timeoutMs: 5_000,
             allowNonZeroExit: true,
           },
-        ).pipe(Effect.map((result) => result.code === 0)),
+        ).pipe(Effect.map((result) => result.exitCode === 0)),
         executeGit(
           "GitVcsDriver.switchRef.remoteExists",
           input.cwd,
@@ -1952,7 +1952,7 @@ export const makeGitVcsDriverCore = Effect.fn("makeGitVcsDriverCore")(function*
             timeoutMs: 5_000,
             allowNonZeroExit: true,
           },
-        ).pipe(Effect.map((result) => result.code === 0)),
+        ).pipe(Effect.map((result) => result.exitCode === 0)),
       ],
       { concurrency: "unbounded" },
     );
@@ -1968,7 +1968,7 @@ export const makeGitVcsDriverCore = Effect.fn("makeGitVcsDriverCore")(function*
           },
         ).pipe(
           Effect.map((result) =>
-            result.code === 0
+            result.exitCode === 0
               ? parseTrackingBranchByUpstreamRef(result.stdout, input.refName)
               : null,
           ),
@@ -1986,7 +1986,7 @@ export const makeGitVcsDriverCore = Effect.fn("makeGitVcsDriverCore")(function*
               timeoutMs: 5_000,
               allowNonZeroExit: true,
             },
-          ).pipe(Effect.map((result) => result.code === 0))
+          ).pipe(Effect.map((result) => result.exitCode === 0))
         : false;
 
     const checkoutArgs = localInputExists