fix: skip outside-root candidates in findExistingFile instead of aborting

In findExistingFile, resolveRelativePathWithinRoot failures (e.g. paths
outside the workspace from icon metadata) now skip the candidate instead
of aborting the entire effect. This restores the scan-order behavior so
that a bad icon href in an earlier ICON_SOURCE_FILES entry does not
prevent later sources from being consulted.

Updated the test to reflect the corrected behavior and added a test
verifying that a valid icon from a later source file is found even when
an earlier source has an outside-root href.

Author: cursoragent

apps/server/src/project/ProjectFaviconResolver.test.ts

@@ -167,21 +167,30 @@ it.layer(TestLayer)("ProjectFaviconResolverLive", (it) => {
       }),
     );
 
-    it.effect("rejects icon metadata paths outside the workspace", () =>
+    it.effect("skips icon metadata paths outside the workspace", () =>
       Effect.gen(function* () {
         const resolver = yield* ProjectFaviconResolver.ProjectFaviconResolver;
         const cwd = yield* makeTempDir;
         yield* writeTextFile(cwd, "index.html", '<link rel="icon" href="../../secret.svg">');
 
-        const error = yield* resolver.resolvePath(cwd).pipe(Effect.flip);
+        const resolved = yield* resolver.resolvePath(cwd);
 
-        expect(error).toMatchObject({
-          _tag: "ProjectFaviconResolutionError",
-          operation: "resolve-path",
-          workspaceRoot: cwd,
-          relativePath: "../secret.svg",
-        });
-        expect(error.cause).toBeInstanceOf(WorkspacePaths.WorkspacePathOutsideRootError);
+        expect(resolved).toBeNull();
+      }),
+    );
+
+    it.effect("skips outside-root href and finds valid icon from later source", () =>
+      Effect.gen(function* () {
+        const resolver = yield* ProjectFaviconResolver.ProjectFaviconResolver;
+        const cwd = yield* makeTempDir;
+        yield* writeTextFile(cwd, "index.html", '<link rel="icon" href="../../secret.svg">');
+        yield* writeTextFile(cwd, "public/index.html", '<link rel="icon" href="/brand/logo.svg">');
+        yield* writeTextFile(cwd, "public/brand/logo.svg", "<svg>brand</svg>");
+
+        const resolved = yield* resolver.resolvePath(cwd);
+
+        expect(resolved).not.toBeNull();
+        expect(resolved).toContain("public/brand/logo.svg");
       }),
     );
   });

apps/server/src/project/ProjectFaviconResolver.ts

@@ -134,30 +134,26 @@ export const make = Effect.gen(function* () {
           relativePath,
         })
         .pipe(
-          Effect.mapError(
-            (cause) =>
-              new ProjectFaviconResolutionError({
-                operation: "resolve-path",
-                workspaceRoot: projectCwd,
-                relativePath,
-                cause,
-              }),
-          ),
+          Effect.map(Option.some),
+          Effect.orElseSucceed(() => Option.none<{ absolutePath: string; relativePath: string }>()),
         );
-      const stats = yield* optionOnNotFound(fileSystem.stat(candidate.absolutePath)).pipe(
+      if (Option.isNone(candidate)) {
+        continue;
+      }
+      const stats = yield* optionOnNotFound(fileSystem.stat(candidate.value.absolutePath)).pipe(
         Effect.mapError(
           (cause) =>
             new ProjectFaviconResolutionError({
               operation: "stat-candidate",
               workspaceRoot: projectCwd,
               relativePath,
-              absolutePath: candidate.absolutePath,
+              absolutePath: candidate.value.absolutePath,
               cause,
             }),
         ),
       );
       if (Option.isSome(stats) && stats.value.type === "File") {
-        return candidate.absolutePath;
+        return candidate.value.absolutePath;
       }
     }
     return null;