Skip to content

Commit 90fc3ed

Browse files
committed
fix: use WS_METHODS constants and add serverSignalProcess to tracing disabled set
- Replace hardcoded string literals with WS_METHODS constants from @t3tools/contracts to prevent drift if method names change. - Add serverSignalProcess to RPC_METHODS_WITH_TRACING_DISABLED so diagnostic signal actions don't pollute the trace diagnostics view.
1 parent 9f442a7 commit 90fc3ed

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

apps/server/src/observability/RpcInstrumentation.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import { WS_METHODS } from "@t3tools/contracts";
12
import { Duration, Effect, Exit, Metric, Stream } from "effect";
23

34
import { outcomeFromExit } from "./Attributes.ts";
@@ -9,8 +10,9 @@ const DEFAULT_RPC_SPAN_ATTRIBUTES = {
910
"rpc.system": "effect-rpc",
1011
} as const;
1112
const RPC_METHODS_WITH_TRACING_DISABLED = new Set([
12-
"server.getTraceDiagnostics",
13-
"server.getProcessDiagnostics",
13+
WS_METHODS.serverGetTraceDiagnostics,
14+
WS_METHODS.serverGetProcessDiagnostics,
15+
WS_METHODS.serverSignalProcess,
1416
]);
1517

1618
function shouldTraceRpc(method: string): boolean {

0 commit comments

Comments
 (0)