fix: prevent post-send presentation failures from discarding resolved SSH password

After send-prompt-request, the renderer can resolve the deferred password
at any yield boundary. Wrap the post-send presentation operations (window
destroy checks, restore, focus) with Effect.ignore so their failures do
not shadow an already-resolved password. The window-closed listener and
timeout still handle the case where the window is truly gone.

Author: cursoragent

apps/desktop/src/ssh/DesktopSshPasswordPrompts.ts

@@ -413,34 +413,42 @@ export const make = Effect.fn("desktop.sshPasswordPrompts.make")(function* (
       yield* runPresentationOperation("send-prompt-request", () =>
         window.value.webContents.send(SSH_PASSWORD_PROMPT_CHANNEL, promptRequest),
       );
-      const unavailableAfterSend = yield* runPresentationOperation("check-window-after-send", () =>
-        window.value.isDestroyed(),
-      );
-      if (unavailableAfterSend) {
-        return yield* new DesktopSshPromptWindowUnavailableError({
-          destination: input.destination,
-          requestId,
-          stage: "after-send",
-        });
-      }
-      const minimized = yield* runPresentationOperation("check-window-minimized", () =>
-        window.value.isMinimized(),
-      );
-      if (minimized) {
-        yield* runPresentationOperation("restore-window", () => window.value.restore());
-      }
-      const unavailableAfterRestore = yield* runPresentationOperation(
-        "check-window-after-restore",
-        () => window.value.isDestroyed(),
-      );
-      if (unavailableAfterRestore) {
-        return yield* new DesktopSshPromptWindowUnavailableError({
-          destination: input.destination,
-          requestId,
-          stage: "after-restore",
-        });
-      }
-      yield* runPresentationOperation("focus-window", () => window.value.focus());
+      // Once the prompt is sent the renderer can resolve the password at any
+      // scheduling boundary. The remaining steps only improve visibility
+      // (focus / restore) so their failures must not shadow an already-resolved
+      // password. Wrap them as best-effort; the window-closed listener and
+      // timeout still protect against a truly-gone window.
+      yield* Effect.gen(function* () {
+        const unavailableAfterSend = yield* runPresentationOperation(
+          "check-window-after-send",
+          () => window.value.isDestroyed(),
+        );
+        if (unavailableAfterSend) {
+          return yield* new DesktopSshPromptWindowUnavailableError({
+            destination: input.destination,
+            requestId,
+            stage: "after-send",
+          });
+        }
+        const minimized = yield* runPresentationOperation("check-window-minimized", () =>
+          window.value.isMinimized(),
+        );
+        if (minimized) {
+          yield* runPresentationOperation("restore-window", () => window.value.restore());
+        }
+        const unavailableAfterRestore = yield* runPresentationOperation(
+          "check-window-after-restore",
+          () => window.value.isDestroyed(),
+        );
+        if (unavailableAfterRestore) {
+          return yield* new DesktopSshPromptWindowUnavailableError({
+            destination: input.destination,
+            requestId,
+            stage: "after-restore",
+          });
+        }
+        yield* runPresentationOperation("focus-window", () => window.value.focus());
+      }).pipe(Effect.ignore);
       return yield* waitForPassword;
     }).pipe(Effect.ensuring(cleanup));
   });