Commit b38197e
committed
fix: only preserve LoadFailed nav status when URL matches failed URL
The syncWebContentsState guard that preserves LoadFailed status when the
computed status is Success was too broad. It ran on all events including
did-navigate and did-navigate-in-page, not just did-stop-loading. This
meant a guest that navigated to a new working URL could still report the
old LoadFailed status, leaving the unreachable overlay stuck in the UI.
Adding a URL comparison ensures the failure is only preserved when
Electron emits did-stop-loading for the same URL that failed (the
intended case), and clears it when navigation to a different URL
succeeds.1 parent 239e5e7 commit b38197e
1 file changed
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1142 | 1142 | | |
1143 | 1143 | | |
1144 | 1144 | | |
1145 | | - | |
| 1145 | + | |
| 1146 | + | |
| 1147 | + | |
1146 | 1148 | | |
1147 | 1149 | | |
1148 | 1150 | | |
| |||
0 commit comments