Commit b3ce952
committed
fix: use Effect.ignore instead of Effect.asVoid in killDirectChild to prevent SIGKILL phase short-circuit
Effect.asVoid only discards the success value but does not suppress errors.
When child.kill fails (e.g., child already exited), the error propagates
through Effect.all, causing the SIGTERM phase to fail and short-circuiting
the SIGKILL escalation phase. This leaves orphaned serve processes alive.
Effect.ignore both discards the value and suppresses errors, making
killDirectChild infallible and allowing the full kill chain to complete.
Also fix the same issue in the Windows path of killOpenCodeProcessGroup.1 parent b538723 commit b3ce952
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
450 | 450 | | |
451 | 451 | | |
452 | 452 | | |
453 | | - | |
| 453 | + | |
454 | 454 | | |
455 | 455 | | |
456 | 456 | | |
| |||
461 | 461 | | |
462 | 462 | | |
463 | 463 | | |
464 | | - | |
| 464 | + | |
465 | 465 | | |
466 | 466 | | |
467 | 467 | | |
| |||
0 commit comments