Fix queued message loss on non-retryable settings sync failure

Previously, a failed pre-startTurn settings update (metadata, runtime mode,
or interaction mode) would call completeDelivery, which removes the message
from the outbox for non-retryable errors. Since startTurn already carries the
settings in its payload, the message can still be delivered even when a
separate settings command fails.

Replace completeDelivery calls in settings sync blocks with isRetryableFailure
checks that only short-circuit for retryable errors (network/transport issues).
Non-retryable settings failures are now ignored, allowing startTurn to proceed
with the settings embedded in its input.

Author: cursoragent

apps/mobile/src/state/use-thread-outbox-drain.ts

@@ -118,6 +118,12 @@ export function useThreadOutboxDrain(): void {
         }
       };
 
+      const isRetryableFailure = (result: AtomCommandResult<unknown, unknown>): boolean => {
+        if (!AsyncResult.isFailure(result)) return false;
+        const error = Cause.squash(result.cause);
+        return Cause.hasInterruptsOnly(result.cause) || shouldRetryThreadOutboxDelivery(error);
+      };
+
       if (!modelSelectionsEqual(settings.modelSelection, thread.modelSelection)) {
         const updateResult = await updateThreadMetadata({
           environmentId: queuedMessage.environmentId,
@@ -127,8 +133,8 @@ export function useThreadOutboxDrain(): void {
             modelSelection: settings.modelSelection,
           },
         });
-        if (AsyncResult.isFailure(updateResult)) {
-          return completeDelivery(updateResult);
+        if (isRetryableFailure(updateResult)) {
+          return false;
         }
       }
 
@@ -142,8 +148,8 @@ export function useThreadOutboxDrain(): void {
             createdAt: queuedMessage.createdAt,
           },
         });
-        if (AsyncResult.isFailure(runtimeResult)) {
-          return completeDelivery(runtimeResult);
+        if (isRetryableFailure(runtimeResult)) {
+          return false;
         }
       }
 
@@ -157,8 +163,8 @@ export function useThreadOutboxDrain(): void {
             createdAt: queuedMessage.createdAt,
           },
         });
-        if (AsyncResult.isFailure(interactionResult)) {
-          return completeDelivery(interactionResult);
+        if (isRetryableFailure(interactionResult)) {
+          return false;
         }
       }