Commit c698485
committed
fix(desktop): don't apply shift-to-symbol transformation for chord shortcuts
When Shift is combined with Control, Meta, or Alt, browsers report the base
key (e.g. '1') rather than the shifted symbol (e.g. '!'). The resolveKeyDefinition
function was unconditionally applying the shift transformation whenever Shift was
present in modifiers, causing chord shortcuts like Ctrl+Shift+1 to emit '!' instead
of '1' as the key in the CDP packet.
Only apply the shift-to-symbol mapping for printable keys when Shift is the sole
modifier, matching real browser KeyboardEvent behavior.1 parent cfbdaf4 commit c698485
1 file changed
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
114 | 114 | | |
115 | 115 | | |
116 | 116 | | |
117 | | - | |
| 117 | + | |
| 118 | + | |
118 | 119 | | |
119 | 120 | | |
120 | 121 | | |
| |||
0 commit comments