Skip to content

Commit dde41bb

Browse files
committed
Fix duplicate preference keys for custom HTTPS endpoints
Include httpBaseUrl in the fallback path of endpointDefaultPreferenceKey so that multiple custom HTTPS endpoints (which share the same provider, reachability, scheme, and label) produce distinct keys. This fixes: - Duplicate React keys in the MenuItem map for pairing link copy options - Multiple custom endpoints incorrectly showing the 'Default' badge when any one of them is set as the default
1 parent 1001ee1 commit dde41bb

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

apps/web/src/components/settings/ConnectionsSettings.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@ function endpointDefaultPreferenceKey(endpoint: AdvertisedEndpoint): string {
290290
// Keep the stored preference stable even if a custom endpoint is malformed.
291291
}
292292

293-
return `${endpoint.provider.id}:${endpoint.reachability}:${scheme}:${endpoint.label}`;
293+
return `${endpoint.provider.id}:${endpoint.reachability}:${scheme}:${endpoint.label}:${endpoint.httpBaseUrl}`;
294294
}
295295

296296
function resolveAdvertisedEndpointPairingUrl(

0 commit comments

Comments
 (0)