fix: separate advertised endpoints error state and handle malformed custom URLs gracefully

Bug 1: getAdvertisedEndpoints() error was writing to desktopServerExposureError,
sharing state with getServerExposureState(). Added a dedicated
desktopAdvertisedEndpointsError state so endpoint fetch failures don't
overwrite/corrupt the Network access error indicator.

Bug 2: A single malformed URL in T3CODE_DESKTOP_HTTPS_ENDPOINTS caused the
entire resolveDesktopCoreAdvertisedEndpoints to throw, discarding valid
loopback and LAN endpoints. Wrapped the custom URL loop body in try-catch
so bad entries are skipped with a warning.

Author: cursoragent

apps/desktop/src/serverExposure.ts

@@ -156,17 +156,21 @@ export function resolveDesktopCoreAdvertisedEndpoints(
   }
 
   for (const customEndpointUrl of input.customHttpsEndpointUrls ?? []) {
-    endpoints.push(
-      createManualEndpoint({
-        id: `manual:${customEndpointUrl}`,
-        label: "Custom HTTPS",
-        httpBaseUrl: customEndpointUrl,
-        reachability: "public",
-        hostedHttpsCompatibility: "compatible",
-        status: "unknown",
-        description: "User-configured HTTPS endpoint for this desktop backend.",
-      }),
-    );
+    try {
+      endpoints.push(
+        createManualEndpoint({
+          id: `manual:${customEndpointUrl}`,
+          label: "Custom HTTPS",
+          httpBaseUrl: customEndpointUrl,
+          reachability: "public",
+          hostedHttpsCompatibility: "compatible",
+          status: "unknown",
+          description: "User-configured HTTPS endpoint for this desktop backend.",
+        }),
+      );
+    } catch {
+      console.warn(`Skipping malformed custom endpoint URL: ${customEndpointUrl}`);
+    }
   }
 
   return endpoints;

apps/web/src/components/settings/ConnectionsSettings.tsx

@@ -878,6 +878,9 @@ export function ConnectionsSettings() {
     ReadonlyArray<AdvertisedEndpoint>
   >([]);
   const [desktopServerExposureError, setDesktopServerExposureError] = useState<string | null>(null);
+  const [desktopAdvertisedEndpointsError, setDesktopAdvertisedEndpointsError] = useState<
+    string | null
+  >(null);
   const [desktopPairingLinks, setDesktopPairingLinks] = useState<
     ReadonlyArray<ServerPairingLinkRecord>
   >([]);
@@ -1218,12 +1221,13 @@ export function ConnectionsSettings() {
           if (cancelled) return;
           const message =
             error instanceof Error ? error.message : "Failed to load reachable endpoints.";
-          setDesktopServerExposureError(message);
+          setDesktopAdvertisedEndpointsError(message);
         });
     } else {
       setDesktopServerExposureState(null);
       setDesktopAdvertisedEndpoints([]);
       setDesktopServerExposureError(null);
+      setDesktopAdvertisedEndpointsError(null);
     }
 
     return () => {
@@ -1241,6 +1245,7 @@ export function ConnectionsSettings() {
     setDesktopServerExposureState(null);
     setDesktopAdvertisedEndpoints([]);
     setDesktopServerExposureError(null);
+    setDesktopAdvertisedEndpointsError(null);
   }, [canManageLocalBackend]);
   const visibleDesktopPairingLinks = useMemo(
     () => desktopPairingLinks.filter((pairingLink) => pairingLink.role === "client"),
@@ -1337,6 +1342,13 @@ export function ConnectionsSettings() {
                     </AlertDialog>
                   }
                 />
+                {desktopAdvertisedEndpointsError ? (
+                  <div className="px-4 py-2">
+                    <span className="block text-xs text-destructive">
+                      {desktopAdvertisedEndpointsError}
+                    </span>
+                  </div>
+                ) : null}
                 {desktopAdvertisedEndpoints.map((endpoint) => (
                   <AdvertisedEndpointListRow key={endpoint.id} endpoint={endpoint} />
                 ))}