Skip to content

Commit 0543dc8

Browse files
btoueggilbox
authored andcommitted
Fix dynamic imageSrc removal, fix flicker in react-native-maps#738 (react-native-maps#737)
1 parent 3f881ad commit 0543dc8

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

ios/AirGoogleMaps/AIRGoogleMapMarker.m

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -182,6 +182,18 @@ - (void)setImageSrc:(NSString *)imageSrc
182182
_reloadImageCancellationBlock = nil;
183183
}
184184

185+
if (!_imageSrc) {
186+
if (_iconImageView) [_iconImageView removeFromSuperview];
187+
return;
188+
}
189+
190+
if (!_iconImageView) {
191+
// prevent glitch with marker (cf. https://github.com/airbnb/react-native-maps/issues/738)
192+
UIImageView *empyImageView = [[UIImageView alloc] init];
193+
_iconImageView = empyImageView;
194+
[self iconViewInsertSubview:_iconImageView atIndex:0];
195+
}
196+
185197
_reloadImageCancellationBlock = [_bridge.imageLoader loadImageWithURLRequest:[RCTConvert NSURLRequest:_imageSrc]
186198
size:self.bounds.size
187199
scale:RCTScreenScale()

0 commit comments

Comments
 (0)