Skip to content

Fix error stages are not shown for plugin-arch piped created pipeline #5950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khanhtc1202 merged 6 commits into from
Jun 26, 2025
Merged

Fix error stages are not shown for plugin-arch piped created pipeline #5950

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
88f6c06
Fix error stages are not shown for plugin-arch piped created pipeline
khanhtc1202 Jun 13, 2025
2c7271b
Merge branch 'master' into fix-visible-stage-ui
khanhtc1202 Jun 24, 2025
fe0ed83
Merge branch 'master' into fix-visible-stage-ui
khanhtc1202 Jun 25, 2025
f090685
Logic based on deployTarget instead
khanhtc1202 Jun 25, 2025
bfa9395
Update stage showing logic to not dependent on stage.visible field
khanhtc1202 Jun 26, 2025
1460183
Update condition to avoid undefined case error
khanhtc1202 Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions web/src/components/deployments-detail-page/pipeline/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,16 +54,27 @@ const findDefaultActiveStage = (
return stages[stages.length - 1];
};

const isStartedStage = (stage: Stage): boolean => {
return stage.status !== StageStatus.STAGE_NOT_STARTED_YET;
};

const createStagesForRendering = (
deployment: Deployment.AsObject | undefined
): Stage[][] => {
if (!deployment) {
return [];
}

const stages: Stage[][] = [];
const visibleStages = deployment.stagesList.filter((stage) => stage.visible);
let visibleStages: Stage[] = [];
if (deployment.deployTargetsByPluginMap?.length) {
visibleStages = deployment.stagesList.filter(
(stage) => !stage.rollback || isStartedStage(stage)
);
} else {
visibleStages = deployment.stagesList.filter((stage) => stage.visible);
}

const stages: Stage[][] = [];
stages[0] = visibleStages.filter((stage) => stage.requiresList.length === 0);

let index = 0;
Expand All @@ -74,6 +85,7 @@ const createStagesForRendering = (
stage.requiresList.some((id) => previousIds.includes(id))
);
}

return stages;
};

Expand Down