Skip to content

fix: make lint/go for non-interactive environments #6448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Warashi merged 3 commits into from
Mar 9, 2026
+1 −1
Merged

fix: make lint/go for non-interactive environments #6448

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a5641c0
fix make lint/go for non-interactive environments and simplify CI
parshipcy Jan 21, 2026
5b45795
remove lint.yaml changes
parshipcy Jan 25, 2026
24c51b1
Merge branch 'master' into fix-make-lint
Warashi Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ lint: lint/go lint/web lint/helm
.PHONY: lint/go
lint/go: FIX ?= false
lint/go: VERSION ?= sha256:91460846c43b3de53eb77e968b17363e8747e6f3fc190575b52be60c49446e23 # golangci/golangci-lint:v2.4.0
lint/go: FLAGS ?= --rm -e GOCACHE=/repo/.cache/go-build -e GOLANGCI_LINT_CACHE=/repo/.cache/golangci-lint -v ${PWD}:/repo -it
lint/go: FLAGS ?= --rm -e GOCACHE=/repo/.cache/go-build -e GOLANGCI_LINT_CACHE=/repo/.cache/golangci-lint -v ${PWD}:/repo
lint/go: MODULES ?= $(shell find . -name go.mod | while read -r dir; do dirname "$$dir"; done | paste -sd, -) # comma separated list of modules. eg: MODULES=.,pkg/plugin/sdk
lint/go:
@echo "Linting go modules..."
Expand Down